From: zhouqiao@marvell•com (Qiao Zhou)
To: linux-arm-kernel@lists•infradead.org
Subject: Build warning in drivers/dma/mmp_tdma.c
Date: Wed, 4 Dec 2013 10:44:10 +0800 [thread overview]
Message-ID: <529E96FA.5050404@marvell.com> (raw)
In-Reply-To: <CAMj5Bkijhhk9-V74=NKXFO_uocyzU7furKyB4E0E_AFWKKtF_A@mail.gmail.com>
On 12/04/2013 10:34 AM, Zhangfei Gao wrote:
> On Wed, Dec 4, 2013 at 10:28 AM, Qiao Zhou <zhouqiao@marvell•com> wrote:
>> On 12/04/2013 10:15 AM, Dan Williams wrote:
>>>
>>> On Tue, Dec 3, 2013 at 5:58 PM, Qiao Zhou <zhouqiao@marvell•com> wrote:
>>>>
>>>> On 12/04/2013 09:32 AM, Dan Williams wrote:
>>>>>
>>>>>
>>>>> Please read the question, you can refer to of_get_named_gen_pool() for
>>>>> why I have a question. Something in the system needs to do the
>>>>> devm_gen_pool_create() for that device. If you are removing the mmp2
>>>>> sram driver are you switching to the generic sram driver? If so
>>>>> shouldn't you ensure it is built? Otherwise this will always fail:
>>>>
>>>>
>>>> For CPU_MMP2 specifically, it switches to use generic sram driver. But
>
> Do you mean CPU_MMP2 still need arch/arm/mach-mmp/sram.c?
> Is it can be replaced by drivers/misc/sram.c and be removed at all?
> So only "SRAM" is depends or selected.
drivers/misc/sram.c is enough for CPU_MMP2.
>
>>>> generally it may not use sram only, a DDR buffer(or other buffer) may
>>>> also
>>>> be a pool. So here we don't add "select SRAM" directly. In this case we
>>>> need
>>>> to enable CONFIG_SRAM in mmp2_defconfig.
>>>>
>>>> If no sram or other similar drivers are enabled, it will throw an error
>>>> for
>>>> warning.
>>>>
>>>
>>> Ok, So, please turn this into a compile time dependency (depends on
>>> (SRAM || MMP_SRAM)) so that someone does not need to boot a platform
>>> to figure out they forgot to enable a driver.
>>>
>> Actually I'm not sure it's good to add such dependency.
>> sound/core/memalloc.c provides the same way for sram buffer allocation. It
>> doesn't add such dependency.
>
> SRAM can be selected or depended, while MMP_SRAM should be removed latter.
OK.
>>
>> Zhangfei, Haojian, how do you think?
>>
>> --
>>
>> Best Regards
>> Qiao
--
Best Regards
Qiao
prev parent reply other threads:[~2013-12-04 2:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 22:58 Build warning in drivers/dma/mmp_tdma.c Dan Williams
2013-11-29 5:31 ` Vinod Koul
2013-12-02 6:42 ` Zhangfei Gao
2013-12-02 7:34 ` Qiao Zhou
2013-12-02 7:42 ` Zhangfei Gao
[not found] ` <CAPcyv4jfk+JBv7WY_njuYtx8hERZHhoCAij=FOfqxAhLJAHnFA@mail.gmail.com>
2013-12-03 2:13 ` Zhangfei Gao
2013-12-03 2:31 ` Haojian Zhuang
2013-12-03 10:43 ` Qiao Zhou
2013-12-03 11:05 ` Zhangfei Gao
2013-12-04 1:09 ` Qiao Zhou
2013-12-03 21:02 ` Dan Williams
2013-12-04 1:08 ` Qiao Zhou
2013-12-04 1:32 ` Dan Williams
2013-12-04 1:58 ` Qiao Zhou
2013-12-04 2:15 ` Dan Williams
2013-12-04 2:28 ` Qiao Zhou
2013-12-04 2:34 ` Zhangfei Gao
2013-12-04 2:44 ` Qiao Zhou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529E96FA.5050404@marvell.com \
--to=zhouqiao@marvell$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox