From: santosh.shilimkar@ti•com (Santosh Shilimkar)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/5] usb: dwc3: Add Keystone specific glue layer
Date: Fri, 6 Dec 2013 16:39:49 -0500 [thread overview]
Message-ID: <52A24425.7030802@ti.com> (raw)
In-Reply-To: <20131206202844.GG21086@saruman.home>
On Friday 06 December 2013 03:28 PM, Felipe Balbi wrote:
> Hi,
>
> On Wed, Dec 04, 2013 at 03:10:07PM -0500, WingMan Kwok wrote:
>> Add Keystone platform specific glue layer to support
>> USB3 Host mode.
>>
>> Cc: Santosh Shilimkar <santosh.shilimkar@ti•com>
>> Cc: Felipe Balbi <balbi@ti•com>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
>> Signed-off-by: WingMan Kwok <w-kwok2@ti•com>
>> ---
>> drivers/usb/dwc3/Kconfig | 7 ++
>> drivers/usb/dwc3/Makefile | 1 +
>> drivers/usb/dwc3/dwc3-keystone.c | 210 ++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 218 insertions(+)
>> create mode 100644 drivers/usb/dwc3/dwc3-keystone.c
[..]
>> +static irqreturn_t dwc3_keystone_interrupt(int irq, void *_kdwc)
>> +{
>> + struct dwc3_keystone *kdwc = _kdwc;
>> +
>> + spin_lock(&kdwc->lock);
>
> Isn't this lock unnecessary ? This handler will run with IRQs disabled
> anyway.
>
Indeed.
>> + kdwc3_writel(kdwc->usbss, USBSS_IRQENABLE_CLR_0, USBSS_IRQ_COREIRQ_CLR);
>> + kdwc3_writel(kdwc->usbss, USBSS_IRQSTATUS_0, USBSS_IRQ_EVENT_ST);
>> + kdwc3_writel(kdwc->usbss, USBSS_IRQENABLE_SET_0, USBSS_IRQ_COREIRQ_EN);
>> + kdwc3_writel(kdwc->usbss, USBSS_IRQ_EOI, USBSS_IRQ_EOI_LINE(0));
>> + spin_unlock(&kdwc->lock);
>> +
>> + return IRQ_HANDLED;
>> +}
>> +
>> +static int kdwc3_probe(struct platform_device *pdev)
>> +{
>> + struct device_node *node = pdev->dev.of_node;
>> + struct device *dev = &pdev->dev;
>
> if you invert these lines, it'll look a little nicer:
>
> struct device *dev = &pdev->dev;
> struct device_node *node = dev->of_node;
>
> everything else looks pretty good, thanks
>
Looks good to me as well. With above update,
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti•com>
next prev parent reply other threads:[~2013-12-06 21:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 20:10 [PATCH v2 0/5] Kesytone II USB support WingMan Kwok
2013-12-04 20:10 ` [PATCH v2 1/5] usb: dwc3: Add Keystone specific glue layer WingMan Kwok
2013-12-06 20:28 ` Felipe Balbi
2013-12-06 21:39 ` Santosh Shilimkar [this message]
2013-12-06 22:23 ` Paul Zimmerman
2013-12-07 5:25 ` Shilimkar, Santosh
2013-12-07 6:25 ` Paul Zimmerman
2013-12-07 17:53 ` Felipe Balbi
2013-12-04 20:10 ` [PATCH v2 2/5] usb: phy: Add keystone usb phy driver WingMan Kwok
2013-12-06 20:29 ` Felipe Balbi
2013-12-06 21:41 ` Santosh Shilimkar
2013-12-04 20:10 ` [PATCH v2 3/5] ARM: dts: keystone: Add usb phy devicetree bindings WingMan Kwok
2013-12-06 20:30 ` Felipe Balbi
2013-12-06 21:43 ` Santosh Shilimkar
2013-12-04 20:10 ` [PATCH v2 4/5] ARM: dts: keystone: Add usb " WingMan Kwok
2013-12-06 20:30 ` Felipe Balbi
2013-12-04 20:10 ` [PATCH v2 5/5] ARM: keystone: defconfig: enable USB support WingMan Kwok
2013-12-06 21:48 ` [PATCH v2 0/5] Kesytone II " Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A24425.7030802@ti.com \
--to=santosh.shilimkar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox