From: santosh.shilimkar@ti•com (Santosh Shilimkar)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 3/5] ARM: dts: keystone: Add usb phy devicetree bindings
Date: Fri, 6 Dec 2013 16:43:10 -0500 [thread overview]
Message-ID: <52A244EE.4090301@ti.com> (raw)
In-Reply-To: <20131206203003.GI21086@saruman.home>
On Friday 06 December 2013 03:30 PM, Felipe Balbi wrote:
> On Wed, Dec 04, 2013 at 03:10:09PM -0500, WingMan Kwok wrote:
>> Added device tree support for TI's Keystone USB PHY driver and updated the
>> Documentation with device tree binding information.
>>
>> Cc: Santosh Shilimkar <santosh.shilimkar@ti•com>
>> Signed-off-by: WingMan Kwok <w-kwok2@ti•com>
>> ---
>> .../devicetree/bindings/usb/keystone-phy.txt | 19 +++++++++++++++++++
>> arch/arm/boot/dts/keystone.dtsi | 7 +++++++
>> 2 files changed, 26 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/usb/keystone-phy.txt
>>
>> diff --git a/Documentation/devicetree/bindings/usb/keystone-phy.txt b/Documentation/devicetree/bindings/usb/keystone-phy.txt
>> new file mode 100644
>> index 0000000..300830d
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/usb/keystone-phy.txt
>> @@ -0,0 +1,19 @@
>> +TI Keystone USB PHY
>> +
>> +Required properties:
>> + - compatible: should be "ti,keystone-usbphy".
>> + - #address-cells, #size-cells : should be '1' if the device has sub-nodes
>> + with 'reg' property.
>> + - reg : Address and length of the usb phy control register set.
>> +
>> +The main purpose of this PHY driver is to enable the USB PHY reference clock
>> +gate on the Keystone SOC for both the USB2 and USB3 PHY. Otherwise it is just
>> +an NOP PHY driver. Hence this node is referenced as both the usb2 and usb3
>> +phy node in the USB Glue layer driver node.
>> +
>> +usb_phy: usb_phy at 2620738 {
>> + compatible = "ti,keystone-usbphy";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + reg = <0x2620738 32>;
>> +};
>> diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
>> index f6d6d9e..d497d9e 100644
>> --- a/arch/arm/boot/dts/keystone.dtsi
>> +++ b/arch/arm/boot/dts/keystone.dtsi
>> @@ -181,5 +181,12 @@
>> interrupts = <GIC_SPI 300 IRQ_TYPE_EDGE_RISING>;
>> clocks = <&clkspi>;
>> };
>> +
>> + usb_phy: usb_phy at 2620738 {
>> + compatible = "ti,keystone-usbphy";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + reg = <0x2620738 32>;
>
> should this one have status = "disabled"; and let board dts enable the
> PHY ?
>
Currently there is only one board but probably not a bad idea to enable
it from board dts. Lets do that
Regards,
Santosh
next prev parent reply other threads:[~2013-12-06 21:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 20:10 [PATCH v2 0/5] Kesytone II USB support WingMan Kwok
2013-12-04 20:10 ` [PATCH v2 1/5] usb: dwc3: Add Keystone specific glue layer WingMan Kwok
2013-12-06 20:28 ` Felipe Balbi
2013-12-06 21:39 ` Santosh Shilimkar
2013-12-06 22:23 ` Paul Zimmerman
2013-12-07 5:25 ` Shilimkar, Santosh
2013-12-07 6:25 ` Paul Zimmerman
2013-12-07 17:53 ` Felipe Balbi
2013-12-04 20:10 ` [PATCH v2 2/5] usb: phy: Add keystone usb phy driver WingMan Kwok
2013-12-06 20:29 ` Felipe Balbi
2013-12-06 21:41 ` Santosh Shilimkar
2013-12-04 20:10 ` [PATCH v2 3/5] ARM: dts: keystone: Add usb phy devicetree bindings WingMan Kwok
2013-12-06 20:30 ` Felipe Balbi
2013-12-06 21:43 ` Santosh Shilimkar [this message]
2013-12-04 20:10 ` [PATCH v2 4/5] ARM: dts: keystone: Add usb " WingMan Kwok
2013-12-06 20:30 ` Felipe Balbi
2013-12-04 20:10 ` [PATCH v2 5/5] ARM: keystone: defconfig: enable USB support WingMan Kwok
2013-12-06 21:48 ` [PATCH v2 0/5] Kesytone II " Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A244EE.4090301@ti.com \
--to=santosh.shilimkar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox