From: santosh.shilimkar@ti•com (Santosh Shilimkar)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 2/2] usb: phy: Add keystone usb phy driver
Date: Tue, 10 Dec 2013 10:17:07 -0500 [thread overview]
Message-ID: <52A73073.5020505@ti.com> (raw)
In-Reply-To: <20131210044728.GB28252@saruman.home>
On Monday 09 December 2013 11:47 PM, Felipe Balbi wrote:
> Hi again,
>
> On Mon, Dec 09, 2013 at 05:17:04PM -0500, WingMan Kwok wrote:
>> +static int keystone_usbphy_init(struct usb_phy *phy)
>> +{
>> + struct keystone_usbphy *k_phy = dev_get_drvdata(phy->dev);
>> + u32 val;
>> +
>> + val = keystone_usbphy_readl(k_phy->phy_ctrl, USB_PHY_CTL_CLOCK);
>> + keystone_usbphy_writel(k_phy->phy_ctrl, USB_PHY_CTL_CLOCK,
>> + val | PHY_REF_SSP_EN);
>
> you need to enable this device's clock to access its registers right ?
>
Nope.. This clock is always running for CFG block where the phy control
is residing.
>> + udelay(20);
>
> why the magic 20 usecs ? Where does that come from ? Empirically found
> or is there a documentation reference ? At least add a comment there.
>
Above probably isn't needed either but good to check why was this added.
In refreshed patch, this can be either removed or a comment can be
added accordingly.
Thanks for spotting that.
Regards,
Santosh
prev parent reply other threads:[~2013-12-10 15:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 22:17 [PATCH v3 0/2] Kesytone II USB host and PHY drivers WingMan Kwok
2013-12-09 22:17 ` [PATCH v3 1/2] usb: dwc3: Add Keystone specific glue layer WingMan Kwok
2013-12-10 2:51 ` Felipe Balbi
2013-12-10 15:11 ` Santosh Shilimkar
2013-12-12 17:48 ` Felipe Balbi
2013-12-12 19:36 ` Santosh Shilimkar
2013-12-12 19:41 ` Felipe Balbi
2013-12-12 19:52 ` Santosh Shilimkar
2013-12-09 22:17 ` [PATCH v3 2/2] usb: phy: Add keystone usb phy driver WingMan Kwok
2013-12-10 2:54 ` Felipe Balbi
2013-12-10 15:14 ` Santosh Shilimkar
2013-12-12 17:20 ` Kwok, WingMan
2013-12-12 17:47 ` Felipe Balbi
2013-12-10 3:09 ` Roger Quadros
2013-12-12 17:24 ` Kwok, WingMan
2013-12-10 4:47 ` Felipe Balbi
2013-12-10 15:17 ` Santosh Shilimkar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A73073.5020505@ti.com \
--to=santosh.shilimkar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox