From: santosh.shilimkar@ti•com (Santosh Shilimkar)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 1/2] usb: dwc3: Add Keystone specific glue layer
Date: Thu, 12 Dec 2013 14:36:01 -0500 [thread overview]
Message-ID: <52AA1021.2010505@ti.com> (raw)
In-Reply-To: <20131212174838.GE1939@saruman.home>
On Thursday 12 December 2013 12:48 PM, Felipe Balbi wrote:
> Hi,
>
> On Tue, Dec 10, 2013 at 10:11:36AM -0500, Santosh Shilimkar wrote:
>>>> +static int kdwc3_remove(struct platform_device *pdev)
>>>> +{
>>>> + struct dwc3_keystone *kdwc = platform_get_drvdata(pdev);
>>>> +
>>>> + kdwc3_disable_irqs(kdwc);
>>>> + clk_disable_unprepare(kdwc->clk);
>>>
>>> I hope the clock isn't shared between core and wrapper, otherwise you
>>> could run into some troubles here. Can you confirm ?
>>>
>> Yes. the clock isn't shared. Thanks for taking care of other parts.
>
> so clock for core is always running too ?
>
I take that back. The clock is actually common so we should disable
it after removing the kdwc3_remove_core() as you suggested.
You won't see issue since the kdwc3_remove_core() not doing
any register access but moving the clock disable after
the core remove is right thing to do.
Regards,
Santosh
next prev parent reply other threads:[~2013-12-12 19:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 22:17 [PATCH v3 0/2] Kesytone II USB host and PHY drivers WingMan Kwok
2013-12-09 22:17 ` [PATCH v3 1/2] usb: dwc3: Add Keystone specific glue layer WingMan Kwok
2013-12-10 2:51 ` Felipe Balbi
2013-12-10 15:11 ` Santosh Shilimkar
2013-12-12 17:48 ` Felipe Balbi
2013-12-12 19:36 ` Santosh Shilimkar [this message]
2013-12-12 19:41 ` Felipe Balbi
2013-12-12 19:52 ` Santosh Shilimkar
2013-12-09 22:17 ` [PATCH v3 2/2] usb: phy: Add keystone usb phy driver WingMan Kwok
2013-12-10 2:54 ` Felipe Balbi
2013-12-10 15:14 ` Santosh Shilimkar
2013-12-12 17:20 ` Kwok, WingMan
2013-12-12 17:47 ` Felipe Balbi
2013-12-10 3:09 ` Roger Quadros
2013-12-12 17:24 ` Kwok, WingMan
2013-12-10 4:47 ` Felipe Balbi
2013-12-10 15:17 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AA1021.2010505@ti.com \
--to=santosh.shilimkar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox