From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: tegra: add device tree for SHIELD
Date: Mon, 24 Feb 2014 11:53:33 -0700 [thread overview]
Message-ID: <530B952D.2000006@wwwdotorg.org> (raw)
In-Reply-To: <1393237593-28121-1-git-send-email-acourbot@nvidia.com>
On 02/24/2014 03:26 AM, Alexandre Courbot wrote:
> Add a device tree for NVIDIA SHIELD. The set of enabled features is
> still minimal with no display option (although HDMI should be easy
> to get to work) and USB requiring external power.
You could add a simple-framebuffer node for now, I think?
> diff --git a/arch/arm/boot/dts/tegra114-roth.dts b/arch/arm/boot/dts/tegra114-roth.dts
> + memory {
> + reg = <0x80000000 0x79600000>;
It might be worth a comment here pointing out that the rest of RAM is
reserved for some carveouts/..., or at least that these values are set
this way in order to match what the bootloader usually passes to
downstream kernels in the command-line?
> + i2c at 7000d000 {
> + palmas: pmic at 58 {
> + compatible = "ti,palmas";
> + reg = <0x58>;
> + interrupts = <0 86 IRQ_TYPE_LEVEL_HIGH>;
> + ti,irq-externally-inverted;
Unfortunately, the patch I sent to document/implement that last property
hasn't yet been ack'd/applied, so I'll hold off applying this until it has.
> + /* Wifi */
> + sdhci at 78000000 {
> + status = "okay";
> + bus-width = <4>;
> + broken-cd;
> + keep-power-in-suspend;
> + cap-sdio-irq;
Is non-removable better than broken-cd, or are they entirely unrelated?
Should we add broken-cd and/or cap-sdio-irq to the SDIO WiFi on other
boards (Springbank, Ventana, Cardhu)?
> + usb-phy at 7d000000 {
> + status = "okay";
> + nvidia,xcvr-setup = <7>;
> + nvidia,xcvr-lsfslew = <2>;
> + nvidia,xcvr-lsrslew = <2>;
> + interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
> + dr_mode = "otg";
While opt is probably accurate, we don't actually support otg upstream,
but only host. While the DT is supposed to represent HW rather than
SW/OS details, I've tried to avoid putting otg into the DT, since I'm
not sure that the DT binding for otg is stable, since we can't test it,
whereas host probably is. Still, this is a pretty minor detail, and we
can ignore that if you want ("otg" evidently /works/ fine on Seaboard,
so it's OK if you keep this).
next prev parent reply other threads:[~2014-02-24 18:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 10:26 [PATCH] ARM: tegra: add device tree for SHIELD Alexandre Courbot
2014-02-24 18:53 ` Stephen Warren [this message]
2014-02-25 2:13 ` Alexandre Courbot
2014-02-25 9:52 ` Arend van Spriel
2014-02-26 4:52 ` Alexandre Courbot
2014-02-26 21:10 ` Arend van Spriel
2014-02-25 22:38 ` Stephen Warren
2014-02-26 4:58 ` Alexandre Courbot
2014-02-26 5:02 ` Stephen Warren
2014-02-26 5:12 ` Alexandre Courbot
-- strict thread matches above, loose matches on Subject: below --
2014-03-03 3:49 Alexandre Courbot
2014-03-03 3:53 ` Alexandre Courbot
2014-03-03 17:00 ` Stephen Warren
2014-03-04 1:24 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530B952D.2000006@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox