From: acourbot@nvidia•com (Alexandre Courbot)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: tegra: add device tree for SHIELD
Date: Tue, 4 Mar 2014 10:24:13 +0900 [thread overview]
Message-ID: <53152B3D.3090509@nvidia.com> (raw)
In-Reply-To: <5314B53B.4010107@wwwdotorg.org>
On 03/04/2014 02:00 AM, Stephen Warren wrote:
> On 03/02/2014 08:49 PM, Alexandre Courbot wrote:
>> Add a device tree for NVIDIA SHIELD. The set of enabled features is
>> still minimal with no display option and USB requiring external power.
>>
>> A default kernel command-line as well as initrd addresses are hardcoded
>> to match the static values the bootloader is known to use. This allows
>> booting from an appended DTB without having to alter it at boot time,
>> since the bootloader has no Device Tree support.
>
> This and the TN7 patch look fine. Hopefully I'll apply them soon,
> pending the ti,irq-externally-inverted discussion.
Great, thanks! That means only small hacks remain in my out-of-tree
branch. Will make it easier to enable the remaining features (panel,
Wifi, audio, etc.) from now on.
>
>> + /* SD card */
>
> Oh, that's all you meant by wanting to add comments? I guess I just
> recognize SD-vs-eMMC by the bus width, but adding the comments is a good
> idea.
Haha no, I actually meant to add small descriptive comments in front of
each pinmux group, but thinking twice it doesn't seem to bring as much
readability as I initially thought,
Thanks,
Alex.
next prev parent reply other threads:[~2014-03-04 1:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 3:49 [PATCH] ARM: tegra: add device tree for SHIELD Alexandre Courbot
2014-03-03 3:53 ` Alexandre Courbot
2014-03-03 17:00 ` Stephen Warren
2014-03-04 1:24 ` Alexandre Courbot [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-02-24 10:26 Alexandre Courbot
2014-02-24 18:53 ` Stephen Warren
2014-02-25 2:13 ` Alexandre Courbot
2014-02-25 9:52 ` Arend van Spriel
2014-02-26 4:52 ` Alexandre Courbot
2014-02-26 21:10 ` Arend van Spriel
2014-02-25 22:38 ` Stephen Warren
2014-02-26 4:58 ` Alexandre Courbot
2014-02-26 5:02 ` Stephen Warren
2014-02-26 5:12 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53152B3D.3090509@nvidia.com \
--to=acourbot@nvidia$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox