[PATCH v2 0/4] Introduce new Kconfig for Samsung common clock

public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed

* [PATCH v2 0/4] Introduce new Kconfig for Samsung common clock
@ 2014-03-12  4:32 Pankaj Dubey
  2014-03-12  4:32 ` [PATCH v2 1/4] clk: samsung: add new Kconfig for Samsung common clock options Pankaj Dubey
                   ` (5 more replies)
  0 siblings, 6 replies; 16+ messages in thread
From: Pankaj Dubey @ 2014-03-12  4:32 UTC (permalink / raw)
  To: linux-arm-kernel

Introduce a new Kconfig file for Samsung common clock infrastructure
related config options. As current Samsung common clock gets compiled
based on PLAT_SAMSUNG, but moving ahead with ARM64 we can not have any
more such config options, so this patch introduce new COMMON_CLK_SAMSUNG
invisible option. This option also select COMMON_CLK so ARCH Kconfig just
need to select COMMON_CLK_SAMSUNG in case they want to use Samsung common
clock.

This series is based on Kukjin's for-next branch.

V2:
 1) Adding new Kconfig file for Samsung common clock.
 2) Make COMMON_CLK_SAMSUNG option invisible. (as suggested by Tomasz Figa)
 3) Let COMMON_CLK_SAMSUNG select COMMON_CLK. (as suggested by Tomasz Figa)
 4) Move S3C24XX clock config option in new Kconfig file.

Pankaj Dubey (4):
  clk: samsung: add new Kconfig for Samsung common clock options
  drivers: clk: use CONFIG_COMMON_CLK_SAMSUNG for Samsung clock support
  ARM: select COMMON_CLK_SAMSUNG for ARCH_EXYNOS and ARCH_S3C64XX
  ARM: S3C24XX: remove S3C24XX specific clock Kconfig options

 arch/arm/Kconfig              |    4 ++--
 arch/arm/mach-s3c24xx/Kconfig |   14 --------------
 drivers/clk/Kconfig           |    2 ++
 drivers/clk/Makefile          |    2 +-
 drivers/clk/samsung/Kconfig   |   11 +++++++++++
 5 files changed, 16 insertions(+), 17 deletions(-)
 create mode 100644 drivers/clk/samsung/Kconfig

-- 
1.7.9.5

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH v2 1/4] clk: samsung: add new Kconfig for Samsung common clock options
  2014-03-12  4:32 [PATCH v2 0/4] Introduce new Kconfig for Samsung common clock Pankaj Dubey
@ 2014-03-12  4:32 ` Pankaj Dubey
  2014-03-19 12:19   ` Tomasz Figa
  2014-03-12  4:32 ` [PATCH v2 2/4] drivers: clk: use CONFIG_COMMON_CLK_SAMSUNG for Samsung clock support Pankaj Dubey
                   ` (4 subsequent siblings)
  5 siblings, 1 reply; 16+ messages in thread
From: Pankaj Dubey @ 2014-03-12  4:32 UTC (permalink / raw)
  To: linux-arm-kernel

This patch adds new Kconfig file for adding new config option
as COMMON_CLK_SAMSUNG for Samsung common clock. This patch also
moves S3C24XX specific clock options here in this file.

Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung•com>
---
 drivers/clk/samsung/Kconfig |   11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 drivers/clk/samsung/Kconfig

diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig
new file mode 100644
index 0000000..26eb446
--- /dev/null
+++ b/drivers/clk/samsung/Kconfig
@@ -0,0 +1,11 @@
+config COMMON_CLK_SAMSUNG
+	bool
+	select COMMON_CLK
+
+config S3C2412_COMMON_CLK
+	bool
+	select COMMON_CLK_SAMSUNG
+
+config S3C2443_COMMON_CLK
+	bool
+	select COMMON_CLK_SAMSUNG
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v2 1/4] clk: samsung: add new Kconfig for Samsung common clock options
  2014-03-12  4:32 ` [PATCH v2 1/4] clk: samsung: add new Kconfig for Samsung common clock options Pankaj Dubey
@ 2014-03-19 12:19   ` Tomasz Figa
  2014-03-20  4:27     ` Pankaj Dubey
  0 siblings, 1 reply; 16+ messages in thread
From: Tomasz Figa @ 2014-03-19 12:19 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Pankaj,

On 12.03.2014 05:32, Pankaj Dubey wrote:
> This patch adds new Kconfig file for adding new config option
> as COMMON_CLK_SAMSUNG for Samsung common clock. This patch also
> moves S3C24XX specific clock options here in this file.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung•com>
> ---
>   drivers/clk/samsung/Kconfig |   11 +++++++++++
>   1 file changed, 11 insertions(+)
>   create mode 100644 drivers/clk/samsung/Kconfig
>
> diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig
> new file mode 100644
> index 0000000..26eb446
> --- /dev/null
> +++ b/drivers/clk/samsung/Kconfig
> @@ -0,0 +1,11 @@
> +config COMMON_CLK_SAMSUNG
> +	bool
> +	select COMMON_CLK
> +
> +config S3C2412_COMMON_CLK
> +	bool
> +	select COMMON_CLK_SAMSUNG
> +
> +config S3C2443_COMMON_CLK
> +	bool
> +	select COMMON_CLK_SAMSUNG
>

This patch adds S3C2412_COMMON_CLK and S3C2443_COMMON_CLK to 
drivers/clk/samsung/Kconfig, but they are still present in 
arch/arm/mach-s3c24xx/Kconfig, so after this patch there are duplicate 
definitions.

Best regards,
Tomasz

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH v2 1/4] clk: samsung: add new Kconfig for Samsung common clock options
  2014-03-19 12:19   ` Tomasz Figa
@ 2014-03-20  4:27     ` Pankaj Dubey
  0 siblings, 0 replies; 16+ messages in thread
From: Pankaj Dubey @ 2014-03-20  4:27 UTC (permalink / raw)
  To: linux-arm-kernel

On 03/19/2014 09:19 PM, Tomasz Figa wrote:
> Hi Pankaj,
>
> On 12.03.2014 05:32, Pankaj Dubey wrote:
>> This patch adds new Kconfig file for adding new config option
>> as COMMON_CLK_SAMSUNG for Samsung common clock. This patch also
>> moves S3C24XX specific clock options here in this file.
>>
>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung•com>
>> ---
>>   drivers/clk/samsung/Kconfig |   11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>   create mode 100644 drivers/clk/samsung/Kconfig
>>
>> diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig
>> new file mode 100644
>> index 0000000..26eb446
>> --- /dev/null
>> +++ b/drivers/clk/samsung/Kconfig
>> @@ -0,0 +1,11 @@
>> +config COMMON_CLK_SAMSUNG
>> +    bool
>> +    select COMMON_CLK
>> +
>> +config S3C2412_COMMON_CLK
>> +    bool
>> +    select COMMON_CLK_SAMSUNG
>> +
>> +config S3C2443_COMMON_CLK
>> +    bool
>> +    select COMMON_CLK_SAMSUNG
>>
>
> This patch adds S3C2412_COMMON_CLK and S3C2443_COMMON_CLK to 
> drivers/clk/samsung/Kconfig, but they are still present in 
> arch/arm/mach-s3c24xx/Kconfig, so after this patch there are duplicate 
> definitions.
>
> Best regards,
> Tomasz
>

OK, In that case I will club change in arm/mach-s3c24xx/Kconfig and 
clk/samsung/Kconfig together
  and resubmit once again.

-- 
Best Regards,
Pankaj Dubey

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH v2 2/4] drivers: clk: use CONFIG_COMMON_CLK_SAMSUNG for Samsung clock support
  2014-03-12  4:32 [PATCH v2 0/4] Introduce new Kconfig for Samsung common clock Pankaj Dubey
  2014-03-12  4:32 ` [PATCH v2 1/4] clk: samsung: add new Kconfig for Samsung common clock options Pankaj Dubey
@ 2014-03-12  4:32 ` Pankaj Dubey
  2014-03-19 12:18   ` Tomasz Figa
  2014-03-12  4:33 ` [PATCH v2 3/4] ARM: select COMMON_CLK_SAMSUNG for ARCH_EXYNOS and ARCH_S3C64XX Pankaj Dubey
                   ` (3 subsequent siblings)
  5 siblings, 1 reply; 16+ messages in thread
From: Pankaj Dubey @ 2014-03-12  4:32 UTC (permalink / raw)
  To: linux-arm-kernel

This patch includes Samsung clock Kconfig file, and replaces PLAT_SAMSUNG
with COMMON_CLK_SAMSUNG for Samsung common clock support.
Any Samsung SoC want to use Samsung common clock infrastructure can simply
select COMMON_CLK_SAMSUNG.

Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung•com>
---
 drivers/clk/Kconfig  |    2 ++
 drivers/clk/Makefile |    2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index 7641965..f2b6179 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -112,3 +112,5 @@ source "drivers/clk/qcom/Kconfig"
 endmenu
 
 source "drivers/clk/mvebu/Kconfig"
+
+source "drivers/clk/samsung/Kconfig"
diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile
index a367a98..f1da6ee 100644
--- a/drivers/clk/Makefile
+++ b/drivers/clk/Makefile
@@ -38,7 +38,7 @@ obj-$(CONFIG_PLAT_ORION)		+= mvebu/
 obj-$(CONFIG_ARCH_MXS)			+= mxs/
 obj-$(CONFIG_COMMON_CLK_QCOM)		+= qcom/
 obj-$(CONFIG_ARCH_ROCKCHIP)		+= rockchip/
-obj-$(CONFIG_PLAT_SAMSUNG)		+= samsung/
+obj-$(CONFIG_COMMON_CLK_SAMSUNG)	+= samsung/
 obj-$(CONFIG_ARCH_SHMOBILE_MULTI)	+= shmobile/
 obj-$(CONFIG_ARCH_SIRF)			+= sirf/
 obj-$(CONFIG_ARCH_SOCFPGA)		+= socfpga/
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v2 2/4] drivers: clk: use CONFIG_COMMON_CLK_SAMSUNG for Samsung clock support
  2014-03-12  4:32 ` [PATCH v2 2/4] drivers: clk: use CONFIG_COMMON_CLK_SAMSUNG for Samsung clock support Pankaj Dubey
@ 2014-03-19 12:18   ` Tomasz Figa
  2014-03-20  4:23     ` Pankaj Dubey
  0 siblings, 1 reply; 16+ messages in thread
From: Tomasz Figa @ 2014-03-19 12:18 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Pankaj,

On 12.03.2014 05:32, Pankaj Dubey wrote:
> This patch includes Samsung clock Kconfig file, and replaces PLAT_SAMSUNG
> with COMMON_CLK_SAMSUNG for Samsung common clock support.
> Any Samsung SoC want to use Samsung common clock infrastructure can simply
> select COMMON_CLK_SAMSUNG.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung•com>
> ---
>   drivers/clk/Kconfig  |    2 ++
>   drivers/clk/Makefile |    2 +-
>   2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index 7641965..f2b6179 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -112,3 +112,5 @@ source "drivers/clk/qcom/Kconfig"
>   endmenu
>
>   source "drivers/clk/mvebu/Kconfig"
> +
> +source "drivers/clk/samsung/Kconfig"
> diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile
> index a367a98..f1da6ee 100644
> --- a/drivers/clk/Makefile
> +++ b/drivers/clk/Makefile
> @@ -38,7 +38,7 @@ obj-$(CONFIG_PLAT_ORION)		+= mvebu/
>   obj-$(CONFIG_ARCH_MXS)			+= mxs/
>   obj-$(CONFIG_COMMON_CLK_QCOM)		+= qcom/
>   obj-$(CONFIG_ARCH_ROCKCHIP)		+= rockchip/
> -obj-$(CONFIG_PLAT_SAMSUNG)		+= samsung/
> +obj-$(CONFIG_COMMON_CLK_SAMSUNG)	+= samsung/
>   obj-$(CONFIG_ARCH_SHMOBILE_MULTI)	+= shmobile/
>   obj-$(CONFIG_ARCH_SIRF)			+= sirf/
>   obj-$(CONFIG_ARCH_SOCFPGA)		+= socfpga/
>

This patch makes samsung/ subdirectory compile depending on 
CONFIG_COMMON_CLK_SAMSUNG, but nothing selects it yet and thus breaking 
bisection.

Best regards,
Tomasz

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH v2 2/4] drivers: clk: use CONFIG_COMMON_CLK_SAMSUNG for Samsung clock support
  2014-03-19 12:18   ` Tomasz Figa
@ 2014-03-20  4:23     ` Pankaj Dubey
  0 siblings, 0 replies; 16+ messages in thread
From: Pankaj Dubey @ 2014-03-20  4:23 UTC (permalink / raw)
  To: linux-arm-kernel

On 03/19/2014 09:18 PM, Tomasz Figa wrote:
> Hi Pankaj,
>
> On 12.03.2014 05:32, Pankaj Dubey wrote:
>> This patch includes Samsung clock Kconfig file, and replaces PLAT_SAMSUNG
>> with COMMON_CLK_SAMSUNG for Samsung common clock support.
>> Any Samsung SoC want to use Samsung common clock infrastructure can simply
>> select COMMON_CLK_SAMSUNG.
>>
>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung•com>
>> ---
>>   drivers/clk/Kconfig  |    2 ++
>>   drivers/clk/Makefile |    2 +-
>>   2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
>> index 7641965..f2b6179 100644
>> --- a/drivers/clk/Kconfig
>> +++ b/drivers/clk/Kconfig
>> @@ -112,3 +112,5 @@ source "drivers/clk/qcom/Kconfig"
>>   endmenu
>>
>>   source "drivers/clk/mvebu/Kconfig"
>> +
>> +source "drivers/clk/samsung/Kconfig"
>> diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile
>> index a367a98..f1da6ee 100644
>> --- a/drivers/clk/Makefile
>> +++ b/drivers/clk/Makefile
>> @@ -38,7 +38,7 @@ obj-$(CONFIG_PLAT_ORION)        += mvebu/
>>   obj-$(CONFIG_ARCH_MXS)            += mxs/
>>   obj-$(CONFIG_COMMON_CLK_QCOM)        += qcom/
>>   obj-$(CONFIG_ARCH_ROCKCHIP)        += rockchip/
>> -obj-$(CONFIG_PLAT_SAMSUNG)        += samsung/
>> +obj-$(CONFIG_COMMON_CLK_SAMSUNG)    += samsung/
>>   obj-$(CONFIG_ARCH_SHMOBILE_MULTI)    += shmobile/
>>   obj-$(CONFIG_ARCH_SIRF)            += sirf/
>>   obj-$(CONFIG_ARCH_SOCFPGA)        += socfpga/
>>
>
> This patch makes samsung/ subdirectory compile depending on 
> CONFIG_COMMON_CLK_SAMSUNG, but nothing selects it yet and thus breaking 
> bisection.
>
> Best regards,
> Tomasz
>

Thanks for review.
OK, I will take care of this in next revision.

-- 
Best Regards,
Pankaj Dubey

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH v2 3/4] ARM: select COMMON_CLK_SAMSUNG for ARCH_EXYNOS and ARCH_S3C64XX
  2014-03-12  4:32 [PATCH v2 0/4] Introduce new Kconfig for Samsung common clock Pankaj Dubey
  2014-03-12  4:32 ` [PATCH v2 1/4] clk: samsung: add new Kconfig for Samsung common clock options Pankaj Dubey
  2014-03-12  4:32 ` [PATCH v2 2/4] drivers: clk: use CONFIG_COMMON_CLK_SAMSUNG for Samsung clock support Pankaj Dubey
@ 2014-03-12  4:33 ` Pankaj Dubey
  2014-03-12  4:33 ` [PATCH v2 4/4] ARM: S3C24XX: remove S3C24XX specific clock Kconfig options Pankaj Dubey
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 16+ messages in thread
From: Pankaj Dubey @ 2014-03-12  4:33 UTC (permalink / raw)
  To: linux-arm-kernel

This patch selects COMMON_CLK_SAMSUNG for EXYNOS and S3C64XX SoC
and removes COMMON_CLK selection as COMMON_CLK_SAMSUNG selects it's dependency.

CC: Russell King <linux@arm•linux.org.uk>
Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung•com>
---
 arch/arm/Kconfig |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index e254198..0c15aa7 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -755,7 +755,7 @@ config ARCH_S3C64XX
 	select ARM_VIC
 	select CLKDEV_LOOKUP
 	select CLKSRC_SAMSUNG_PWM
-	select COMMON_CLK
+	select COMMON_CLK_SAMSUNG
 	select CPU_V6K
 	select GENERIC_CLOCKEVENTS
 	select GPIO_SAMSUNG
@@ -834,7 +834,7 @@ config ARCH_EXYNOS
 	select ARCH_REQUIRE_GPIOLIB
 	select ARCH_SPARSEMEM_ENABLE
 	select ARM_GIC
-	select COMMON_CLK
+	select COMMON_CLK_SAMSUNG
 	select CPU_V7
 	select GENERIC_CLOCKEVENTS
 	select HAVE_S3C2410_I2C if I2C
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v2 4/4] ARM: S3C24XX: remove S3C24XX specific clock Kconfig options
  2014-03-12  4:32 [PATCH v2 0/4] Introduce new Kconfig for Samsung common clock Pankaj Dubey
                   ` (2 preceding siblings ...)
  2014-03-12  4:33 ` [PATCH v2 3/4] ARM: select COMMON_CLK_SAMSUNG for ARCH_EXYNOS and ARCH_S3C64XX Pankaj Dubey
@ 2014-03-12  4:33 ` Pankaj Dubey
  2014-03-19 10:39 ` [PATCH v2 0/4] Introduce new Kconfig for Samsung common clock Pankaj Dubey
  2014-03-20  4:55 ` [PATCH v3 " Pankaj Dubey
  5 siblings, 0 replies; 16+ messages in thread
From: Pankaj Dubey @ 2014-03-12  4:33 UTC (permalink / raw)
  To: linux-arm-kernel

This patch removes S3C24XX specific clock Kconfig options as
it has been moved into "drivers/clk/samsung/Kconfig" also removes
COMMON_CLK selection as COMMON_CLK_SAMSUNG is selecting it's dependency.

CC: Ben Dooks <ben-linux@fluff•org>
CC: Kukjin Kim <kgene.kim@samsung•com>
CC: Russell King <linux@arm•linux.org.uk>
Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung•com>
---
 arch/arm/mach-s3c24xx/Kconfig |   14 --------------
 1 file changed, 14 deletions(-)

diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig
index 80373da..2d1232e 100644
--- a/arch/arm/mach-s3c24xx/Kconfig
+++ b/arch/arm/mach-s3c24xx/Kconfig
@@ -39,7 +39,6 @@ config CPU_S3C2410
 
 config CPU_S3C2412
 	bool "SAMSUNG S3C2412"
-	select COMMON_CLK
 	select CPU_ARM926T
 	select CPU_LLSERIAL_S3C2440
 	select S3C2412_COMMON_CLK
@@ -50,7 +49,6 @@ config CPU_S3C2412
 
 config CPU_S3C2416
 	bool "SAMSUNG S3C2416/S3C2450"
-	select COMMON_CLK
 	select CPU_ARM926T
 	select CPU_LLSERIAL_S3C2440
 	select S3C2416_PM if PM
@@ -88,7 +86,6 @@ config CPU_S3C244X
 
 config CPU_S3C2443
 	bool "SAMSUNG S3C2443"
-	select COMMON_CLK
 	select CPU_ARM920T
 	select CPU_LLSERIAL_S3C2440
 	select S3C2443_COMMON_CLK
@@ -364,11 +361,6 @@ config S3C2412_PM_SLEEP
 
 if CPU_S3C2412
 
-config S3C2412_COMMON_CLK
-	bool
-	help
-	  Build the s3c2412 clock driver based on the common clock framework.
-
 config CPU_S3C2412_ONLY
 	bool
 	depends on !CPU_S3C2410 && !CPU_S3C2416 && !CPU_S3C2440 && \
@@ -651,12 +643,6 @@ endif	# CPU_S3C2442
 
 if CPU_S3C2443 || CPU_S3C2416
 
-config S3C2443_COMMON_CLK
-	bool
-	help
-	  Temporary symbol to build the clock driver based on the common clock
-	  framework.
-
 config S3C2443_DMA
 	bool
 	help
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v2 0/4] Introduce new Kconfig for Samsung common clock
  2014-03-12  4:32 [PATCH v2 0/4] Introduce new Kconfig for Samsung common clock Pankaj Dubey
                   ` (3 preceding siblings ...)
  2014-03-12  4:33 ` [PATCH v2 4/4] ARM: S3C24XX: remove S3C24XX specific clock Kconfig options Pankaj Dubey
@ 2014-03-19 10:39 ` Pankaj Dubey
  2014-03-20  4:55 ` [PATCH v3 " Pankaj Dubey
  5 siblings, 0 replies; 16+ messages in thread
From: Pankaj Dubey @ 2014-03-19 10:39 UTC (permalink / raw)
  To: linux-arm-kernel

On 03/12/2014 01:32 PM, Pankaj Dubey wrote:
> Introduce a new Kconfig file for Samsung common clock infrastructure
> related config options. As current Samsung common clock gets compiled
> based on PLAT_SAMSUNG, but moving ahead with ARM64 we can not have any
> more such config options, so this patch introduce new COMMON_CLK_SAMSUNG
> invisible option. This option also select COMMON_CLK so ARCH Kconfig just
> need to select COMMON_CLK_SAMSUNG in case they want to use Samsung common
> clock.
>
> This series is based on Kukjin's for-next branch.
>
> V2:
>   1) Adding new Kconfig file for Samsung common clock.
>   2) Make COMMON_CLK_SAMSUNG option invisible. (as suggested by Tomasz Figa)
>   3) Let COMMON_CLK_SAMSUNG select COMMON_CLK. (as suggested by Tomasz Figa)
>   4) Move S3C24XX clock config option in new Kconfig file.
>
> Pankaj Dubey (4):
>    clk: samsung: add new Kconfig for Samsung common clock options
>    drivers: clk: use CONFIG_COMMON_CLK_SAMSUNG for Samsung clock support
>    ARM: select COMMON_CLK_SAMSUNG for ARCH_EXYNOS and ARCH_S3C64XX
>    ARM: S3C24XX: remove S3C24XX specific clock Kconfig options
>
>   arch/arm/Kconfig              |    4 ++--
>   arch/arm/mach-s3c24xx/Kconfig |   14 --------------
>   drivers/clk/Kconfig           |    2 ++
>   drivers/clk/Makefile          |    2 +-
>   drivers/clk/samsung/Kconfig   |   11 +++++++++++
>   5 files changed, 16 insertions(+), 17 deletions(-)
>   create mode 100644 drivers/clk/samsung/Kconfig
>

+CC: Mike and Tomasz Figa

Sorry, during posting second version I forgot to CC Clock maintainer's,
so CC'ing now.

Link for this series: http://lkml.org/lkml/2014/3/12/10

-- 
Best Regards,
Pankaj Dubey

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH v3 0/4] Introduce new Kconfig for Samsung common clock
  2014-03-12  4:32 [PATCH v2 0/4] Introduce new Kconfig for Samsung common clock Pankaj Dubey
                   ` (4 preceding siblings ...)
  2014-03-19 10:39 ` [PATCH v2 0/4] Introduce new Kconfig for Samsung common clock Pankaj Dubey
@ 2014-03-20  4:55 ` Pankaj Dubey
  2014-03-20  4:55   ` [PATCH v3 1/4] clk: samsung: add new Kconfig for Samsung common clock option Pankaj Dubey
                     ` (4 more replies)
  5 siblings, 5 replies; 16+ messages in thread
From: Pankaj Dubey @ 2014-03-20  4:55 UTC (permalink / raw)
  To: linux-arm-kernel

Introduce a new Kconfig file for Samsung common clock infrastructure
related config options. As current Samsung common clock gets compiled
based on PLAT_SAMSUNG, but moving ahead with ARM64 we can not have any
more such config options, so this patch introduce new COMMON_CLK_SAMSUNG
invisible option. This option also select COMMON_CLK so ARCH Kconfig just
need to select COMMON_CLK_SAMSUNG in case they want to use Samsung common
clock.

This series is based on Kukjin's for-next branch.

V3: 
 1) Re-organized patches for preventing bisect issues.
 2) Rebase on top of latest Kukjin's for-next branch.
 3) Compile tested exynos_defconfig, s3c6400_defconfig and s3c2410_defconfig
    after each commit.

V2:
 1) Adding new Kconfig file for Samsung common clock.
 2) Make COMMON_CLK_SAMSUNG option invisible. (as suggested by Tomasz Figa)
 3) Let COMMON_CLK_SAMSUNG select COMMON_CLK. (as suggested by Tomasz Figa)
 4) Move S3C24XX clock config option in new Kconfig file.

Pankaj Dubey (4):
  clk: samsung: add new Kconfig for Samsung common clock option
  ARM: select COMMON_CLK_SAMSUNG for ARCH_EXYNOS and ARCH_S3C64XX
  ARM: S3C24XX: move S3C24XX clock Kconfig options to Samsung clock
    Kconfig file
  drivers: clk: use COMMON_CLK_SAMSUNG for Samsung clock support

 arch/arm/Kconfig              |    4 ++--
 arch/arm/mach-s3c24xx/Kconfig |   14 --------------
 drivers/clk/Kconfig           |    2 ++
 drivers/clk/Makefile          |    2 +-
 drivers/clk/samsung/Kconfig   |   12 ++++++++++++
 5 files changed, 17 insertions(+), 17 deletions(-)
 create mode 100644 drivers/clk/samsung/Kconfig

-- 
1.7.10.4

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH v3 1/4] clk: samsung: add new Kconfig for Samsung common clock option
  2014-03-20  4:55 ` [PATCH v3 " Pankaj Dubey
@ 2014-03-20  4:55   ` Pankaj Dubey
  2014-03-20  4:55   ` [PATCH v3 2/4] ARM: select COMMON_CLK_SAMSUNG for ARCH_EXYNOS and ARCH_S3C64XX Pankaj Dubey
                     ` (3 subsequent siblings)
  4 siblings, 0 replies; 16+ messages in thread
From: Pankaj Dubey @ 2014-03-20  4:55 UTC (permalink / raw)
  To: linux-arm-kernel

This patch adds new Kconfig file for adding new COMMON_CLK_SAMSUNG option.
Samsung platforms can select this for using common clock infrastructure.

CC: Tomasz Figa <t.figa@samsung•com>
CC: Mike Turquette <mturquette@linaro•org>
Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung•com>
---
 drivers/clk/Kconfig         |    2 ++
 drivers/clk/samsung/Kconfig |    3 +++
 2 files changed, 5 insertions(+)
 create mode 100644 drivers/clk/samsung/Kconfig

diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index 7641965..f2b6179 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -112,3 +112,5 @@ source "drivers/clk/qcom/Kconfig"
 endmenu
 
 source "drivers/clk/mvebu/Kconfig"
+
+source "drivers/clk/samsung/Kconfig"
diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig
new file mode 100644
index 0000000..fc8696b
--- /dev/null
+++ b/drivers/clk/samsung/Kconfig
@@ -0,0 +1,3 @@
+config COMMON_CLK_SAMSUNG
+	bool
+	select COMMON_CLK
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v3 2/4] ARM: select COMMON_CLK_SAMSUNG for ARCH_EXYNOS and ARCH_S3C64XX
  2014-03-20  4:55 ` [PATCH v3 " Pankaj Dubey
  2014-03-20  4:55   ` [PATCH v3 1/4] clk: samsung: add new Kconfig for Samsung common clock option Pankaj Dubey
@ 2014-03-20  4:55   ` Pankaj Dubey
  2014-03-20  4:55   ` [PATCH v3 3/4] ARM: S3C24XX: move S3C24XX clock Kconfig options to Samsung clock Kconfig file Pankaj Dubey
                     ` (2 subsequent siblings)
  4 siblings, 0 replies; 16+ messages in thread
From: Pankaj Dubey @ 2014-03-20  4:55 UTC (permalink / raw)
  To: linux-arm-kernel

This patch selects COMMON_CLK_SAMSUNG for EXYNOS and S3C64XX SoC
and removes COMMON_CLK selection as COMMON_CLK_SAMSUNG selects it's dependency.

CC: Russell King <linux@arm•linux.org.uk>
Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung•com>
---
 arch/arm/Kconfig |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index e254198..0c15aa7 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -755,7 +755,7 @@ config ARCH_S3C64XX
 	select ARM_VIC
 	select CLKDEV_LOOKUP
 	select CLKSRC_SAMSUNG_PWM
-	select COMMON_CLK
+	select COMMON_CLK_SAMSUNG
 	select CPU_V6K
 	select GENERIC_CLOCKEVENTS
 	select GPIO_SAMSUNG
@@ -834,7 +834,7 @@ config ARCH_EXYNOS
 	select ARCH_REQUIRE_GPIOLIB
 	select ARCH_SPARSEMEM_ENABLE
 	select ARM_GIC
-	select COMMON_CLK
+	select COMMON_CLK_SAMSUNG
 	select CPU_V7
 	select GENERIC_CLOCKEVENTS
 	select HAVE_S3C2410_I2C if I2C
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v3 3/4] ARM: S3C24XX: move S3C24XX clock Kconfig options to Samsung clock Kconfig file
  2014-03-20  4:55 ` [PATCH v3 " Pankaj Dubey
  2014-03-20  4:55   ` [PATCH v3 1/4] clk: samsung: add new Kconfig for Samsung common clock option Pankaj Dubey
  2014-03-20  4:55   ` [PATCH v3 2/4] ARM: select COMMON_CLK_SAMSUNG for ARCH_EXYNOS and ARCH_S3C64XX Pankaj Dubey
@ 2014-03-20  4:55   ` Pankaj Dubey
  2014-03-20  4:55   ` [PATCH v3 4/4] drivers: clk: use COMMON_CLK_SAMSUNG for Samsung clock support Pankaj Dubey
  2014-04-10  7:42   ` [PATCH v3 0/4] Introduce new Kconfig for Samsung common clock Pankaj Dubey
  4 siblings, 0 replies; 16+ messages in thread
From: Pankaj Dubey @ 2014-03-20  4:55 UTC (permalink / raw)
  To: linux-arm-kernel

This patch moves S3C24XX specific clock Kconfig options into
"clk/samsung/Kconfig" and also removes COMMON_CLK selection from
"mach-s3c24xx/Kconfig" as S3C24XX_COMMON_CLK is selecting it's dependency.

CC: Ben Dooks <ben-linux@fluff•org>
CC: Kukjin Kim <kgene.kim@samsung•com>
CC: Russell King <linux@arm•linux.org.uk>
CC: Mike Turquette <mturquette@linaro•org>
CC: Tomasz Figa <t.figa@samsung•com>
Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung•com>
---
 arch/arm/mach-s3c24xx/Kconfig |   14 --------------
 drivers/clk/samsung/Kconfig   |    9 +++++++++
 2 files changed, 9 insertions(+), 14 deletions(-)

diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig
index 80373da..2d1232e 100644
--- a/arch/arm/mach-s3c24xx/Kconfig
+++ b/arch/arm/mach-s3c24xx/Kconfig
@@ -39,7 +39,6 @@ config CPU_S3C2410
 
 config CPU_S3C2412
 	bool "SAMSUNG S3C2412"
-	select COMMON_CLK
 	select CPU_ARM926T
 	select CPU_LLSERIAL_S3C2440
 	select S3C2412_COMMON_CLK
@@ -50,7 +49,6 @@ config CPU_S3C2412
 
 config CPU_S3C2416
 	bool "SAMSUNG S3C2416/S3C2450"
-	select COMMON_CLK
 	select CPU_ARM926T
 	select CPU_LLSERIAL_S3C2440
 	select S3C2416_PM if PM
@@ -88,7 +86,6 @@ config CPU_S3C244X
 
 config CPU_S3C2443
 	bool "SAMSUNG S3C2443"
-	select COMMON_CLK
 	select CPU_ARM920T
 	select CPU_LLSERIAL_S3C2440
 	select S3C2443_COMMON_CLK
@@ -364,11 +361,6 @@ config S3C2412_PM_SLEEP
 
 if CPU_S3C2412
 
-config S3C2412_COMMON_CLK
-	bool
-	help
-	  Build the s3c2412 clock driver based on the common clock framework.
-
 config CPU_S3C2412_ONLY
 	bool
 	depends on !CPU_S3C2410 && !CPU_S3C2416 && !CPU_S3C2440 && \
@@ -651,12 +643,6 @@ endif	# CPU_S3C2442
 
 if CPU_S3C2443 || CPU_S3C2416
 
-config S3C2443_COMMON_CLK
-	bool
-	help
-	  Temporary symbol to build the clock driver based on the common clock
-	  framework.
-
 config S3C2443_DMA
 	bool
 	help
diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig
index fc8696b..baf28cb 100644
--- a/drivers/clk/samsung/Kconfig
+++ b/drivers/clk/samsung/Kconfig
@@ -1,3 +1,12 @@
 config COMMON_CLK_SAMSUNG
 	bool
 	select COMMON_CLK
+
+config S3C2412_COMMON_CLK
+	bool
+	select COMMON_CLK_SAMSUNG
+
+config S3C2443_COMMON_CLK
+	bool
+	select COMMON_CLK_SAMSUNG
+
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v3 4/4] drivers: clk: use COMMON_CLK_SAMSUNG for Samsung clock support
  2014-03-20  4:55 ` [PATCH v3 " Pankaj Dubey
                     ` (2 preceding siblings ...)
  2014-03-20  4:55   ` [PATCH v3 3/4] ARM: S3C24XX: move S3C24XX clock Kconfig options to Samsung clock Kconfig file Pankaj Dubey
@ 2014-03-20  4:55   ` Pankaj Dubey
  2014-04-10  7:42   ` [PATCH v3 0/4] Introduce new Kconfig for Samsung common clock Pankaj Dubey
  4 siblings, 0 replies; 16+ messages in thread
From: Pankaj Dubey @ 2014-03-20  4:55 UTC (permalink / raw)
  To: linux-arm-kernel

This patch replaces PLAT_SAMSUNG with COMMON_CLK_SAMSUNG for Samsung
common clock support. Any Samsung SoC want to use Samsung common clock
infrastructure can simply select COMMON_CLK_SAMSUNG.

CC: Tomasz Figa <t.figa@samsung•com>
Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung•com>
---
 drivers/clk/Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile
index a367a98..f1da6ee 100644
--- a/drivers/clk/Makefile
+++ b/drivers/clk/Makefile
@@ -38,7 +38,7 @@ obj-$(CONFIG_PLAT_ORION)		+= mvebu/
 obj-$(CONFIG_ARCH_MXS)			+= mxs/
 obj-$(CONFIG_COMMON_CLK_QCOM)		+= qcom/
 obj-$(CONFIG_ARCH_ROCKCHIP)		+= rockchip/
-obj-$(CONFIG_PLAT_SAMSUNG)		+= samsung/
+obj-$(CONFIG_COMMON_CLK_SAMSUNG)	+= samsung/
 obj-$(CONFIG_ARCH_SHMOBILE_MULTI)	+= shmobile/
 obj-$(CONFIG_ARCH_SIRF)			+= sirf/
 obj-$(CONFIG_ARCH_SOCFPGA)		+= socfpga/
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v3 0/4] Introduce new Kconfig for Samsung common clock
  2014-03-20  4:55 ` [PATCH v3 " Pankaj Dubey
                     ` (3 preceding siblings ...)
  2014-03-20  4:55   ` [PATCH v3 4/4] drivers: clk: use COMMON_CLK_SAMSUNG for Samsung clock support Pankaj Dubey
@ 2014-04-10  7:42   ` Pankaj Dubey
  4 siblings, 0 replies; 16+ messages in thread
From: Pankaj Dubey @ 2014-04-10  7:42 UTC (permalink / raw)
  To: linux-arm-kernel

On 03/20/2014 01:55 PM, Pankaj Dubey wrote:
> Introduce a new Kconfig file for Samsung common clock infrastructure
> related config options. As current Samsung common clock gets compiled
> based on PLAT_SAMSUNG, but moving ahead with ARM64 we can not have any
> more such config options, so this patch introduce new COMMON_CLK_SAMSUNG
> invisible option. This option also select COMMON_CLK so ARCH Kconfig just
> need to select COMMON_CLK_SAMSUNG in case they want to use Samsung common
> clock.
>
> This series is based on Kukjin's for-next branch.
>
> V3:
>   1) Re-organized patches for preventing bisect issues.
>   2) Rebase on top of latest Kukjin's for-next branch.
>   3) Compile tested exynos_defconfig, s3c6400_defconfig and s3c2410_defconfig
>      after each commit.
>
> V2:
>   1) Adding new Kconfig file for Samsung common clock.
>   2) Make COMMON_CLK_SAMSUNG option invisible. (as suggested by Tomasz Figa)
>   3) Let COMMON_CLK_SAMSUNG select COMMON_CLK. (as suggested by Tomasz Figa)
>   4) Move S3C24XX clock config option in new Kconfig file.
>
> Pankaj Dubey (4):
>    clk: samsung: add new Kconfig for Samsung common clock option
>    ARM: select COMMON_CLK_SAMSUNG for ARCH_EXYNOS and ARCH_S3C64XX
>    ARM: S3C24XX: move S3C24XX clock Kconfig options to Samsung clock
>      Kconfig file
>    drivers: clk: use COMMON_CLK_SAMSUNG for Samsung clock support
>
>   arch/arm/Kconfig              |    4 ++--
>   arch/arm/mach-s3c24xx/Kconfig |   14 --------------
>   drivers/clk/Kconfig           |    2 ++
>   drivers/clk/Makefile          |    2 +-
>   drivers/clk/samsung/Kconfig   |   12 ++++++++++++
>   5 files changed, 17 insertions(+), 17 deletions(-)
>   create mode 100644 drivers/clk/samsung/Kconfig
>

Gentle Ping.

-- 
Best Regards,
Pankaj Dubey

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2014-04-10  7:42 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-12  4:32 [PATCH v2 0/4] Introduce new Kconfig for Samsung common clock Pankaj Dubey
2014-03-12  4:32 ` [PATCH v2 1/4] clk: samsung: add new Kconfig for Samsung common clock options Pankaj Dubey
2014-03-19 12:19   ` Tomasz Figa
2014-03-20  4:27     ` Pankaj Dubey
2014-03-12  4:32 ` [PATCH v2 2/4] drivers: clk: use CONFIG_COMMON_CLK_SAMSUNG for Samsung clock support Pankaj Dubey
2014-03-19 12:18   ` Tomasz Figa
2014-03-20  4:23     ` Pankaj Dubey
2014-03-12  4:33 ` [PATCH v2 3/4] ARM: select COMMON_CLK_SAMSUNG for ARCH_EXYNOS and ARCH_S3C64XX Pankaj Dubey
2014-03-12  4:33 ` [PATCH v2 4/4] ARM: S3C24XX: remove S3C24XX specific clock Kconfig options Pankaj Dubey
2014-03-19 10:39 ` [PATCH v2 0/4] Introduce new Kconfig for Samsung common clock Pankaj Dubey
2014-03-20  4:55 ` [PATCH v3 " Pankaj Dubey
2014-03-20  4:55   ` [PATCH v3 1/4] clk: samsung: add new Kconfig for Samsung common clock option Pankaj Dubey
2014-03-20  4:55   ` [PATCH v3 2/4] ARM: select COMMON_CLK_SAMSUNG for ARCH_EXYNOS and ARCH_S3C64XX Pankaj Dubey
2014-03-20  4:55   ` [PATCH v3 3/4] ARM: S3C24XX: move S3C24XX clock Kconfig options to Samsung clock Kconfig file Pankaj Dubey
2014-03-20  4:55   ` [PATCH v3 4/4] drivers: clk: use COMMON_CLK_SAMSUNG for Samsung clock support Pankaj Dubey
2014-04-10  7:42   ` [PATCH v3 0/4] Introduce new Kconfig for Samsung common clock Pankaj Dubey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox