From: t.figa@samsung•com (Tomasz Figa)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/3] ARM: EXYNOS: Map PMU address through DT
Date: Wed, 19 Mar 2014 17:01:25 +0100 [thread overview]
Message-ID: <5329BF55.8000705@samsung.com> (raw)
In-Reply-To: <CAK9yfHyF9t0fsO86cqHvAzaWKa17=2MkFq6mhoL0-mwjw6OXQQ@mail.gmail.com>
On 17.03.2014 15:23, Sachin Kamat wrote:
> Hi Vikas,
>
> On 17 March 2014 18:39, Vikas Sajjan <vikas.sajjan@samsung•com> wrote:
>> Instead of hardcoding the PMU details for each SoC, pass this information
>> through device tree (DT).
>>
>> Signed-off-by: Vikas Sajjan <vikas.sajjan@samsung•com>
>> ---
>> .../devicetree/bindings/arm/samsung/pmu.txt | 5 +-
>> arch/arm/boot/dts/exynos4.dtsi | 5 ++
>> arch/arm/boot/dts/exynos5260.dtsi | 5 ++
>> arch/arm/mach-exynos/common.c | 51 +++++++++++++-------
>> arch/arm/mach-exynos/include/mach/map.h | 3 --
>> 5 files changed, 47 insertions(+), 22 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.txt b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
>> index f1f1552..667a7f0 100644
>> --- a/Documentation/devicetree/bindings/arm/samsung/pmu.txt
>> +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
>> @@ -2,14 +2,15 @@ SAMSUNG Exynos SoC series PMU Registers
>>
>> Properties:
>> - compatible : should contain two values. First value must be one from following list:
>> + - "samsung,exynos4210-pmu" - for Exynos4210 and Exynos4x12 SoC,
>> - "samsung,exynos5250-pmu" - for Exynos5250 SoC,
>> - - "samsung,exynos5420-pmu" - for Exynos5420 SoC.
>> + - "samsung,exynos5420-pmu" - for Exynos5420 and Exynos5260 SoC.
>> second value must be always "syscon".
>>
>> - reg : offset and length of the register set.
>>
>> Example :
>> pmu_system_controller: system-controller at 10040000 {
>> - compatible = "samsung,exynos5250-pmu", "syscon";
>> + compatible = "samsung,exynos5250-pmu";
>
> If you have removed "syscon" deliberately above, then you should also
> remove the same in the
> binding description which says "second value must be always "syscon".".
>
I believe that "syscon" should be still present as I don't see any code
providing access to PMU registers to other drivers, that could replace
the standard syscon interface, being added by this series.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-03-19 16:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 13:09 [PATCH v2 0/3] Add initial support of PMU for exynos5260 Vikas Sajjan
2014-03-17 13:09 ` [PATCH v2 1/3] ARM: EXYNOS: Map PMU address through DT Vikas Sajjan
2014-03-17 14:23 ` Sachin Kamat
2014-03-19 16:01 ` Tomasz Figa [this message]
2014-04-15 18:28 ` Tomasz Figa
2014-04-17 3:44 ` Chanwoo Choi
2014-03-17 13:09 ` [PATCH v2 2/3] ARM: EXYNOS: Add initial support of PMU for Exynos5260 Vikas Sajjan
2014-04-15 18:34 ` Tomasz Figa
2014-04-16 5:34 ` Vikas Sajjan
2014-04-16 11:54 ` Tomasz Figa
2014-03-17 13:09 ` [PATCH v2 3/3] arm: exynos5260: add support for S2R Vikas Sajjan
2014-04-15 18:41 ` Tomasz Figa
2014-04-11 13:16 ` [PATCH v2 0/3] Add initial support of PMU for exynos5260 Vikas Sajjan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5329BF55.8000705@samsung.com \
--to=t.figa@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox