From: t.figa@samsung•com (Tomasz Figa)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 2/3] ARM: EXYNOS: Add initial support of PMU for Exynos5260
Date: Wed, 16 Apr 2014 13:54:52 +0200 [thread overview]
Message-ID: <534E6F8C.3040801@samsung.com> (raw)
In-Reply-To: <CAGm_ybhzQLbK8K5mj0WK8ww61PqurumkwkHqah2=5v-=VACJzA@mail.gmail.com>
Hi Vikas,
On 16.04.2014 07:34, Vikas Sajjan wrote:
> Hi Tomasz,
>
> On Wed, Apr 16, 2014 at 12:04 AM, Tomasz Figa <tomasz.figa@gmail•com> wrote:
>> Hi Vikas,
>>
>>
>> On 17.03.2014 14:09, Vikas Sajjan wrote:
>>>
>>> Adds PMU support of PMU for Exynos5260. Suspend-to-RAM can be built on
>>> top this.
>>>
>>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung•com>
>>> Signed-off-by: Vikas Sajjan <vikas.sajjan@samsung•com>
>>> ---
>>> arch/arm/mach-exynos/common.h | 26 ++++
>>> arch/arm/mach-exynos/pm.c | 34 +++--
>>> arch/arm/mach-exynos/pmu.c | 238
>>> ++++++++++++++++++++++++++++++
>>> arch/arm/mach-exynos/regs-pmu.h | 232
>>> +++++++++++++++++++++++++++++
>>> arch/arm/plat-samsung/include/plat/cpu.h | 8 +
>>> 5 files changed, 529 insertions(+), 9 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h
>>> index aba6a2a..a17f701 100644
>>> --- a/arch/arm/mach-exynos/common.h
>>> +++ b/arch/arm/mach-exynos/common.h
>>> @@ -56,6 +56,32 @@ enum sys_powerdown {
>>> NUM_SYS_POWERDOWN,
>>> };
>>>
>>> +enum running_cpu {
>>> + EXYNOS5_KFC,
>>> + EXYNOS5_ARM,
>>> +};
>>> +
>>> +enum reg_op {
>>> + REG_INIT, /* write new value */
>>> + REG_RESET, /* clear with zero */
>>> + REG_SET, /* bit set */
>>> + REG_CLEAR, /* bit clear */
>>> +};
>>> +
>>> +/* reg/value set */
>>> +#define EXYNOS_PMU_REG(REG, VAL, OP) \
>>> +{ \
>>> + .reg = (void __iomem *)REG, \
>>> + .val = VAL, \
>>> + .op = OP, \
>>> +}
>>> +
>>> +struct exynos_pmu_init_reg {
>>> + void __iomem *reg;
>>> + unsigned int val;
>>> + enum reg_op op;
>>> +};
>>> +
>>> extern unsigned long l2x0_regs_phys;
>>> struct exynos_pmu_conf {
>>> void __iomem *reg;
>>> diff --git a/arch/arm/mach-exynos/pm.c b/arch/arm/mach-exynos/pm.c
>>> index 15af0ce..dbe9670 100644
>>> --- a/arch/arm/mach-exynos/pm.c
>>> +++ b/arch/arm/mach-exynos/pm.c
>>> @@ -109,7 +109,7 @@ static int exynos_cpu_suspend(unsigned long arg)
>>> outer_flush_all();
>>> #endif
>>>
>>> - if (soc_is_exynos5250())
>>> + if (soc_is_exynos5250() || soc_is_exynos5260())
>>> flush_cache_all();
>>
>>
>> I think it's the right time for this code to be restructured. Adding more
>> and more SoCs over this cruft is making this code worse and worse.
>>
>
> I recently came across RFC [1] posted by pankaj on similar lines, did
> you get a chance to have look at this series.
>
> [1] https://lkml.org/lkml/2014/4/2/69
>
Right. I noticed it once, but didn't get to review it yet, as I'm a bit
busy with other things right now. Will try to take a look in next days.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-04-16 11:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 13:09 [PATCH v2 0/3] Add initial support of PMU for exynos5260 Vikas Sajjan
2014-03-17 13:09 ` [PATCH v2 1/3] ARM: EXYNOS: Map PMU address through DT Vikas Sajjan
2014-03-17 14:23 ` Sachin Kamat
2014-03-19 16:01 ` Tomasz Figa
2014-04-15 18:28 ` Tomasz Figa
2014-04-17 3:44 ` Chanwoo Choi
2014-03-17 13:09 ` [PATCH v2 2/3] ARM: EXYNOS: Add initial support of PMU for Exynos5260 Vikas Sajjan
2014-04-15 18:34 ` Tomasz Figa
2014-04-16 5:34 ` Vikas Sajjan
2014-04-16 11:54 ` Tomasz Figa [this message]
2014-03-17 13:09 ` [PATCH v2 3/3] arm: exynos5260: add support for S2R Vikas Sajjan
2014-04-15 18:41 ` Tomasz Figa
2014-04-11 13:16 ` [PATCH v2 0/3] Add initial support of PMU for exynos5260 Vikas Sajjan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534E6F8C.3040801@samsung.com \
--to=t.figa@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox