From: Marc Zyngier <maz@kernel•org>
To: kbuild test robot <lkp@intel•com>, Yash Shah <yash.shah@sifive•com>
Cc: kbuild-all@lists•01.org, Atish Patra <atish.patra@wdc•com>,
"Wesley W. Terpstra" <wesley@sifive•com>,
Linus Walleij <linus.walleij@linaro•org>,
Bartosz Golaszewski <bgolaszewski@baylibre•com>,
linux-arm-kernel@lists•infradead.org
Subject: Re: [arm-platforms:irq/irqchip-next 5/28] drivers/gpio/gpio-sifive.c:83:2: error: implicit declaration of function 'irq_chip_enable_parent'; did you mean 'gpiochip_enable_irq'?
Date: Mon, 20 Jan 2020 19:09:35 +0000 [thread overview]
Message-ID: <5332083498380e8cc461e618f024782b@kernel.org> (raw)
In-Reply-To: <202001210210.Abjd7Hni%lkp@intel.com>
Yash,
On 2020-01-20 18:59, kbuild test robot wrote:
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
> irq/irqchip-next
> head: c7f5b05c27a8501dc5a88bab49b6010e375e91f8
> commit: cd2abc8e87fef699d0da106103b65f6ca8dcbfe7 [5/28] gpio/sifive:
> Add GPIO driver for SiFive SoCs
> config: c6x-randconfig-a001-20200121 (attached as .config)
> compiler: c6x-elf-gcc (GCC) 7.5.0
> reproduce:
> wget
> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout cd2abc8e87fef699d0da106103b65f6ca8dcbfe7
> # save the attached .config to linux build tree
> GCC_VERSION=7.5.0 make.cross ARCH=c6x
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel•com>
>
> All errors (new ones prefixed by >>):
>
> drivers/gpio/gpio-sifive.c: In function 'sifive_gpio_irq_enable':
>>> drivers/gpio/gpio-sifive.c:83:2: error: implicit declaration of
>>> function 'irq_chip_enable_parent'; did you mean
>>> 'gpiochip_enable_irq'? [-Werror=implicit-function-declaration]
> irq_chip_enable_parent(d);
[...]
This is how I'm planning to fix this (at least for the time
being, as I don't want to break -next at this stage).
Let me know if you want to address it otherwise.
Thanks,
M.
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 6c63b79069f2..809dd54a2e82 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -481,7 +481,7 @@ config GPIO_SAMA5D2_PIOBU
config GPIO_SIFIVE
bool "SiFive GPIO support"
- depends on OF_GPIO
+ depends on OF_GPIO && IRQ_DOMAIN_HIERARCHY
select GPIO_GENERIC
select GPIOLIB_IRQCHIP
select REGMAP_MMIO
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-20 19:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 18:59 [arm-platforms:irq/irqchip-next 5/28] drivers/gpio/gpio-sifive.c:83:2: error: implicit declaration of function 'irq_chip_enable_parent'; did you mean 'gpiochip_enable_irq'? kbuild test robot
2020-01-20 19:09 ` Marc Zyngier [this message]
2020-01-23 15:23 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5332083498380e8cc461e618f024782b@kernel.org \
--to=maz@kernel$(echo .)org \
--cc=atish.patra@wdc$(echo .)com \
--cc=bgolaszewski@baylibre$(echo .)com \
--cc=kbuild-all@lists$(echo .)01.org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=lkp@intel$(echo .)com \
--cc=wesley@sifive$(echo .)com \
--cc=yash.shah@sifive$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox