From: linux@roeck-us•net (Guenter Roeck)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] watchdog: imx2_wdt: handle enabled watchdog properly
Date: Fri, 04 Apr 2014 08:41:34 -0700 [thread overview]
Message-ID: <533ED2AE.9010006@roeck-us.net> (raw)
In-Reply-To: <20140404152011.GC5529@katana>
On 04/04/2014 08:20 AM, Wolfram Sang wrote:
> On Fri, Apr 04, 2014 at 04:54:01PM +0200, Anatolij Gustschin wrote:
>> If the watchdog is already enabled (e.g. started by the boot loader),
>> we need to handle this case properly and start reloading the watchdog
>> time-out counter as frequently as needed.
>>
>> Signed-off-by: Anatolij Gustschin <agust@denx•de>
>> Cc: Wolfram Sang <wsa@the-dreams•de>
>> Cc: Wim Van Sebroeck <wim@iguana•be>
>
> Uh, this driver has not been converted to use the watchdog framework
> yet? I'd suggest this should be the first step.
>
Yes, that would make sense at this time, especially given the amount
of work going into it. There is also a separate patch set pending,
converting the driver to use regmap [1]; I am copying the author.
Maybe one of the people working with the driver would be willing
to do the conversion.
Guenter
[1] http://comments.gmane.org/gmane.linux.kernel/1677735
prev parent reply other threads:[~2014-04-04 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 14:54 [PATCH] watchdog: imx2_wdt: handle enabled watchdog properly Anatolij Gustschin
2014-04-04 15:20 ` Wolfram Sang
2014-04-04 15:41 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533ED2AE.9010006@roeck-us.net \
--to=linux@roeck-us$(echo .)net \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox