From: cw00.choi@samsung•com (Chanwoo Choi)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv4 7/7] ARM: dts: Add device tree sources for Exynos3250
Date: Fri, 09 May 2014 16:10:29 +0900 [thread overview]
Message-ID: <536C7F65.50503@samsung.com> (raw)
In-Reply-To: <536C6175.5000302@gmail.com>
Hi Tomasz,
On 05/09/2014 02:02 PM, Tomasz Figa wrote:
> Hi Chanwoo,
>
> On 09.05.2014 03:06, Chanwoo Choi wrote:
>> On 04/26/2014 09:51 AM, Tomasz Figa wrote:
>>> On 25.04.2014 03:16, Chanwoo Choi wrote:
>
> [snip]
>
>>>> + cpus {
>>>> + #address-cells = <1>;
>>>> + #size-cells = <0>;
>>>> +
>>>> + cpu at 0 {
>>>> + device_type = "cpu";
>>>> + compatible = "arm,cortex-a7";
>>>> + reg = <0>;
>>>> + clock-frequency = <1000000000>;
>>>> + };
>>>
>>> Why only one CPU? I believe Exynos3250 is dual core.
>>
>> I'll add cpu1 information.
>>
>>> Also are physical IDs of the cores really 0 and 1? On Exynos4210 for example they are 0x900 and 0x901, while on Exynos4212 they are 0xa00 and 0xa01. Please check this.
>>
>> The 'reg' property means only hardware id(hwid) of CPU.
>> You can check it on arm_dt_init_cpu_maps() in arch/arm/kernel/devtree.c.h.
>> or Documentation/devicetree/bindings/arm/cpus.txt.
>>
>
> Well, as described in Documentation/devicetree/bindings/arm/cpus.txt, on 32-bit ARM v7 or later CPUs the "reg" property should be equal to the lower 24-bits of MPIDR value of given CPU, which in addition to core ID includes also cluster ID, which can be non-zero, even on single cluster SoCs (like it is on Exynos4210 and 4x12).
I checked the lower 24-bit of MPIDR value for Exynos3250 in arm_dt_init_cpu_maps().
- the lower 24-bit of MPIDR for CPU0 is '0x0'.
>
>>>> + };
>>>> +
>>>> + fixed-rate-clocks {
>>>> + compatible = "simple-bus";
>>>> + #address-cells = <1>;
>>>> + #size-cells = <0>;
>
> [snip]
>
>>>> + cmu: clock-controller at 10030000 {
>>>> + compatible = "samsung,exynos3250-cmu";
>>>> + reg = <0x10030000 0x20000>;
>>>> + #clock-cells = <1>;
>>>> + };
>>>> +
>>>> + rtc at 10070000 {
>>>
>>> Please add label to the node, so it can be referenced from board dts files added later (using the method I explained above).
>>
>> OK, I'll add lable as following:
>>
>> rtc_0: rtc at 10070000 {
>
> There is no need to suffix the RTC with _0, as there is just one RTC in the SoC. So in this case rtc: rtc at 10070000 will be enough.
OK, I'll modify it without prefix('_0).
Best Regards,
Chanwoo Choi
next prev parent reply other threads:[~2014-05-09 7:10 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 1:16 [PATCHv4 0/7] Support new Exynos3250 SoC based on Cortex-A7 dual core Chanwoo Choi
2014-04-25 1:16 ` [PATCHv4 1/7] ARM: EXYNOS: Add Exynos3250 SoC ID Chanwoo Choi
2014-04-26 0:40 ` Tomasz Figa
2014-04-25 1:16 ` [PATCHv4 2/7] ARM: EXYNOS: Support secondary CPU boot of Exynos4212 Chanwoo Choi
2014-04-26 0:42 ` Tomasz Figa
2014-04-26 10:49 ` Kukjin Kim
2014-04-25 1:16 ` [PATCHv4 3/7] ARM: EXYNOS: Support secondary CPU boot of Exynos3250 Chanwoo Choi
2014-04-25 4:30 ` Tushar Behera
2014-04-25 5:43 ` Chanwoo Choi
2014-04-25 5:54 ` Tushar Behera
2014-04-25 5:56 ` Chanwoo Choi
2014-04-25 1:16 ` [PATCHv4 4/7] ARM: EXYNOS: Enter a15 lowpower mode for Exynos3250 based on Cortex-a7 Chanwoo Choi
2014-04-26 0:25 ` Tomasz Figa
2014-04-26 0:30 ` Russell King - ARM Linux
2014-04-30 8:00 ` Chanwoo Choi
2014-04-25 1:16 ` [PATCHv4 5/7] clk: samsung: exynos3250: Add clocks using common clock framework Chanwoo Choi
2014-04-26 0:39 ` Tomasz Figa
2014-05-13 11:49 ` Chanwoo Choi
2014-05-13 16:28 ` Tomasz Figa
2014-05-14 6:57 ` Chanwoo Choi
2014-05-14 13:45 ` Tomasz Figa
2014-04-25 1:16 ` [PATCHv4 6/7] dt-bindings: add documentation for Exynos3250 clock controller Chanwoo Choi
2014-04-25 1:16 ` [PATCHv4 7/7] ARM: dts: Add device tree sources for Exynos3250 Chanwoo Choi
2014-04-25 4:38 ` Tushar Behera
2014-04-25 5:03 ` Chanwoo Choi
2014-04-26 0:51 ` Tomasz Figa
2014-04-26 11:38 ` Tomasz Figa
2014-05-09 6:49 ` Chanwoo Choi
2014-05-09 8:01 ` Tomasz Figa
2014-05-09 8:15 ` Chanwoo Choi
2014-05-09 1:06 ` Chanwoo Choi
2014-05-09 5:02 ` Tomasz Figa
2014-05-09 7:10 ` Chanwoo Choi [this message]
2014-05-09 8:01 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536C7F65.50503@samsung.com \
--to=cw00.choi@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox