From: t.figa@samsung•com (Tomasz Figa)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv4 7/7] ARM: dts: Add device tree sources for Exynos3250
Date: Fri, 09 May 2014 10:01:12 +0200 [thread overview]
Message-ID: <536C8B48.90706@samsung.com> (raw)
In-Reply-To: <536C7A96.3000906@samsung.com>
On 09.05.2014 08:49, Chanwoo Choi wrote:
> Hi Tomasz,
>
> On 04/26/2014 08:38 PM, Tomasz Figa wrote:
>> On 26.04.2014 02:51, Tomasz Figa wrote:
>>> Hi Chanwoo,
>>>
>>> On 25.04.2014 03:16, Chanwoo Choi wrote:
>>>> From: Tomasz Figa <t.figa@samsung•com>
>>>>
>>>> This patch add new exynos3250.dtsi to support Exynos3250 SoC based on
>>>> Cortex-A7
>>>> dual core and includes following dt nodes:
>>>>
>>>> - GIC interrupt controller
>>>> - Pinctrl to control GPIOs
>>>> - Clock controller
>>>> - CPU information (Cortex-A7 dual core)
>>>> - UART to support serial port
>>>> - MCT (Multi Core Timer)
>>>> - ADC (Analog Digital Converter)
>>>> - I2C/SPI bus
>>>> - Power domain
>>>> - PMU (Performance Monitoring Unit)
>>>> - MSHC (Mobile Storage Host Controller)
>>>> - PWM (Pluse Width Modulation)
>>>> - AMBA bus
>>>>
>>>> Signed-off-by: Tomasz Figa <t.figa@samsung•com>
>>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung•com>
>>>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung•com>
>>>> Signed-off-by: Inki Dae <inki.dae@samsung•com>
>>>> Signed-off-by: Hyunhee Kim <hyunhee.kim@samsung•com>
>>>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung•com>
>>>> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung•com>
>>>> Cc: Ben Dooks <ben-linux@fluff•org>
>>>> Cc: Kukjin Kim <kgene.kim@samsung•com>
>>>> Cc: Rob Herring <robh+dt@kernel•org>
>>>> Cc: Pawel Moll <pawel.moll@arm•com>
>>>> Cc: Mark Rutland <mark.rutland@arm•com>
>>>> Cc: Ian Campbell <ijc+devicetree@hellion•org.uk>
>>>> Cc: Kumar Gala <galak@codeaurora•org>
>>>> Cc: Russell King <linux@arm•linux.org.uk>
>>>> Cc: devicetree at vger.kernel.org
>>>> ---
>>>> arch/arm/boot/dts/exynos3250-pinctrl.dtsi | 477 +++++++++++++++
>>>> arch/arm/boot/dts/exynos3250.dtsi | 405 +++++++++++++
>>>> arch/arm/boot/dts/exynos4212-tizenw.dts | 926
>>>> ++++++++++++++++++++++++++++++
>>>> 3 files changed, 1808 insertions(+)
>>>> create mode 100644 arch/arm/boot/dts/exynos3250-pinctrl.dtsi
>>>> create mode 100644 arch/arm/boot/dts/exynos3250.dtsi
>>>> create mode 100644 arch/arm/boot/dts/exynos4212-tizenw.dts
>>>>
>>>> diff --git a/arch/arm/boot/dts/exynos3250-pinctrl.dtsi
>>>> b/arch/arm/boot/dts/exynos3250-pinctrl.dtsi
>>>> new file mode 100644
>>>> index 0000000..976490b
>>>> --- /dev/null
>>>> +++ b/arch/arm/boot/dts/exynos3250-pinctrl.dtsi
>>>> @@ -0,0 +1,477 @@
>>>> +/*
>>>> + * Samsung's Exynos3250 SoCs pin-mux and pin-config device tree source
>>>> + *
>>>> + * Copyright (c) 2014 Samsung Electronics Co., Ltd.
>>>> + * http://www.samsung.com
>>>> + *
>>>> + * Samsung's Exynos3250 SoCs pin-mux and pin-config optiosn are
>>>> listed as device
>>>> + * tree nodes are listed in this file.
>>>> + *
>>>> + * This program is free software; you can redistribute it and/or modify
>>>> + * it under the terms of the GNU General Public License version 2 as
>>>> + * published by the Free Software Foundation.
>>>> +*/
>>>> +
>>>> +/ {
>>>> + pinctrl at 11400000 {
>>>
>>> Could you use references instead of re-specifying the whole tree
>>> hierarchy in every file a node is used?
>>>
>>> Instead of
>>>
>>> / {
>>> pinctrl at 11400000 {
>>>
>>> };
>>> };
>>>
>>> one may simply use
>>>
>>> &pinctrl_0 {
>>>
>>> };
>>>
>>> You might just need to change the location of #include
>>> "exynos3250-pinctrl.dtsi" from top of exynos3250.dtsi to bottom of it.
>>
>> Oh, well, you also should move all nodes of on-SoC devices under a simple-bus node called soc. You can see the patch adding dts file for Exynos5260 for an example [1].
>>
>> [1] http://thread.gmane.org/gmane.linux.kernel.samsung-soc/29360/focus=29361
>
>
> OK, I'll move nodes dependent on SoC under 'soc' dt node as example patch[1] except for 'amba-bus' dt node.
I don't see any reason why amba-bus node shouldn't be under soc node as
well. Any on-chip devices should be.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-05-09 8:01 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 1:16 [PATCHv4 0/7] Support new Exynos3250 SoC based on Cortex-A7 dual core Chanwoo Choi
2014-04-25 1:16 ` [PATCHv4 1/7] ARM: EXYNOS: Add Exynos3250 SoC ID Chanwoo Choi
2014-04-26 0:40 ` Tomasz Figa
2014-04-25 1:16 ` [PATCHv4 2/7] ARM: EXYNOS: Support secondary CPU boot of Exynos4212 Chanwoo Choi
2014-04-26 0:42 ` Tomasz Figa
2014-04-26 10:49 ` Kukjin Kim
2014-04-25 1:16 ` [PATCHv4 3/7] ARM: EXYNOS: Support secondary CPU boot of Exynos3250 Chanwoo Choi
2014-04-25 4:30 ` Tushar Behera
2014-04-25 5:43 ` Chanwoo Choi
2014-04-25 5:54 ` Tushar Behera
2014-04-25 5:56 ` Chanwoo Choi
2014-04-25 1:16 ` [PATCHv4 4/7] ARM: EXYNOS: Enter a15 lowpower mode for Exynos3250 based on Cortex-a7 Chanwoo Choi
2014-04-26 0:25 ` Tomasz Figa
2014-04-26 0:30 ` Russell King - ARM Linux
2014-04-30 8:00 ` Chanwoo Choi
2014-04-25 1:16 ` [PATCHv4 5/7] clk: samsung: exynos3250: Add clocks using common clock framework Chanwoo Choi
2014-04-26 0:39 ` Tomasz Figa
2014-05-13 11:49 ` Chanwoo Choi
2014-05-13 16:28 ` Tomasz Figa
2014-05-14 6:57 ` Chanwoo Choi
2014-05-14 13:45 ` Tomasz Figa
2014-04-25 1:16 ` [PATCHv4 6/7] dt-bindings: add documentation for Exynos3250 clock controller Chanwoo Choi
2014-04-25 1:16 ` [PATCHv4 7/7] ARM: dts: Add device tree sources for Exynos3250 Chanwoo Choi
2014-04-25 4:38 ` Tushar Behera
2014-04-25 5:03 ` Chanwoo Choi
2014-04-26 0:51 ` Tomasz Figa
2014-04-26 11:38 ` Tomasz Figa
2014-05-09 6:49 ` Chanwoo Choi
2014-05-09 8:01 ` Tomasz Figa [this message]
2014-05-09 8:15 ` Chanwoo Choi
2014-05-09 1:06 ` Chanwoo Choi
2014-05-09 5:02 ` Tomasz Figa
2014-05-09 7:10 ` Chanwoo Choi
2014-05-09 8:01 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536C8B48.90706@samsung.com \
--to=t.figa@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox