From: detheridge@ti•com (Darren Etheridge)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH/RESEND 9/9] drm/tilcdc: replace late_initcall with module_init
Date: Tue, 24 Jun 2014 17:04:36 -0500 [thread overview]
Message-ID: <53A9F5F4.3030806@ti.com> (raw)
In-Reply-To: <1403014631-18072-10-git-send-email-guido@vanguardiasur.com.ar>
On 06/17/2014 09:17 AM, Guido Mart?nez wrote:
> Use module_init instead of late_initcall, as is the norm for modular
> drivers.
>
> module_init was used until 6e8de0bd6a51fdeebd5d975c4fcc426f730b339b
> ("drm/tilcdc: add encoder slave (v2)") changed it to a late_initcall,
> but it does not explain why. Tests show it's working properly with
> module_init.
>
If I recall, the late_initcall stuff was done to try and make sure the
tda998x/i2c subsystem came up before tilcdc. However it didn't always
work so we added commit: 39de6194131c155901f96686a063212656d80c2e to try
and ensure the ordering. This might be why changing back to module_init
is fine (and I agree with your assessment from my testing).
> Signed-off-by: Guido Mart?nez <guido@vanguardiasur•com.ar>
> ---
> drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index 2c860c4..6be623b 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -629,7 +629,7 @@ static void __exit tilcdc_drm_fini(void)
> tilcdc_tfp410_fini();
> }
>
> -late_initcall(tilcdc_drm_init);
> +module_init(tilcdc_drm_init);
> module_exit(tilcdc_drm_fini);
>
> MODULE_AUTHOR("Rob Clark <robdclark@gmail•com");
>
next prev parent reply other threads:[~2014-06-24 22:04 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1402110128-30471-1-git-send-email-guido@vanguardiasur.com.ar>
2014-06-17 14:17 ` [PATCH/RESEND 0/9] drm: tilcdc driver fixes Guido Martínez
2014-06-17 14:17 ` [PATCH/RESEND 1/9] drm/i2c: tda998x: move drm_i2c_encoder_destroy call Guido Martínez
2014-06-24 16:38 ` Russell King - ARM Linux
2014-06-25 3:55 ` Guido Martínez
2014-06-17 14:17 ` [PATCH/RESEND 2/9] drm/tilcdc: panel: fix dangling sysfs connector node Guido Martínez
2014-06-17 14:17 ` [PATCH/RESEND 3/9] drm/tilcdc: slave: " Guido Martínez
2014-06-17 14:17 ` [PATCH/RESEND 4/9] drm/tilcdc: tfp410: " Guido Martínez
2014-06-17 14:17 ` [PATCH/RESEND 5/9] drm/tilcdc: panel: fix leak when unloading the module Guido Martínez
2014-06-17 14:17 ` [PATCH/RESEND 6/9] drm/tilcdc: fix release order on exit Guido Martínez
2014-06-17 14:17 ` [PATCH/RESEND 7/9] drm/tilcdc: fix double kfree Guido Martínez
2014-06-17 14:17 ` [PATCH/RESEND 8/9] drm/tilcdc: remove submodule destroy calls Guido Martínez
2014-06-24 22:06 ` Darren Etheridge
2014-06-25 3:53 ` Guido Martínez
2014-06-25 14:53 ` Ezequiel García
2014-06-17 14:17 ` [PATCH/RESEND 9/9] drm/tilcdc: replace late_initcall with module_init Guido Martínez
2014-06-24 22:04 ` Darren Etheridge [this message]
2014-06-25 13:00 ` Russell King - ARM Linux
2014-06-25 13:13 ` Russell King - ARM Linux
2014-06-25 14:32 ` Ezequiel García
2014-06-25 14:46 ` Russell King - ARM Linux
2014-06-25 15:48 ` Ezequiel García
2014-06-19 13:41 ` [PATCH/RESEND 0/9] drm: tilcdc driver fixes Darren Etheridge
2014-06-19 16:25 ` Guido Martínez
2014-06-24 0:26 ` Guido Martínez
2014-06-27 22:08 ` Darren Etheridge
2014-06-28 10:51 ` Rob Clark
2014-07-08 10:03 ` Daniel Vetter
2014-07-01 23:39 ` Guido Martínez
2014-07-02 2:31 ` Darren Etheridge
2014-07-02 4:08 ` Dave Airlie
2014-07-02 20:38 ` Ezequiel García
2014-07-08 1:32 ` Dave Airlie
2014-07-01 23:52 ` Guido Martínez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A9F5F4.3030806@ti.com \
--to=detheridge@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox