From: detheridge@ti•com (Darren Etheridge)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH/RESEND 0/9] drm: tilcdc driver fixes
Date: Fri, 27 Jun 2014 17:08:51 -0500 [thread overview]
Message-ID: <53ADEB73.8090301@ti.com> (raw)
In-Reply-To: <1403014631-18072-1-git-send-email-guido@vanguardiasur.com.ar>
Guido,
On 06/17/2014 09:17 AM, Guido Mart?nez wrote:
> The tilcdc driver could be compiled as a module, but was severely broken
> and could not be used as such. This patchset attempts to fix the issues
> preventing a proper load/unload of the module.
>
> Issues included dangling sysfs nodes, dangling devices, memory leaks and
> a double kfree.
>
> It now seems to be working ok. We have tested this by loading and
> unloading the driver repeteadly, with both panel and slave connectors
> and found no flaws.
>
> There is still one warning left on tilcdc_crtc_destroy, caused by
> destroying the connector while still in an ON status. We don't know why
> this happens or why it's an issue, so we did not fix it.
>
Yes I see what you mean, it triggers the WARN_ON in tilcdc_crtc_destroy
because DRM_MODE_DPMS_ON is still set. This WARN_ON does make some
sense because DPMS_OFF would have the effect of turning off clocks and
putting the monitor to sleep which seems logical considering we have
torn down the display. Adding a tilcdc_crtc_dpms(DPMS_OFF) right before
the WARN_ON confirms this, but it seems strange that this hasn't
happened automatically (+ Russell doesn't need to do it in his Armada
driver) - so I suspect there is a better way.
Otherwise I think this is a good and useful patch series.
Darren
> The first 7 patches are bug fixes which and should probably be applied
> in the stable trees. The last two are clean-ups.
>
>
> Resending this since I got no replies.
>
>
> Guido Mart?nez (9):
> drm/i2c: tda998x: move drm_i2c_encoder_destroy call
> drm/tilcdc: panel: fix dangling sysfs connector node
> drm/tilcdc: slave: fix dangling sysfs connector node
> drm/tilcdc: tfp410: fix dangling sysfs connector node
> drm/tilcdc: panel: fix leak when unloading the module
> drm/tilcdc: fix release order on exit
> drm/tilcdc: fix double kfree
> drm/tilcdc: remove submodule destroy calls
> drm/tilcdc: replace late_initcall with module_init
>
> drivers/gpu/drm/i2c/tda998x_drv.c | 2 +-
> drivers/gpu/drm/tilcdc/Module.symvers | 0
> drivers/gpu/drm/tilcdc/tilcdc_drv.c | 15 +++++--------
> drivers/gpu/drm/tilcdc/tilcdc_drv.h | 1 -
> drivers/gpu/drm/tilcdc/tilcdc_panel.c | 39 +++++++++++++++++-----------------
> drivers/gpu/drm/tilcdc/tilcdc_slave.c | 27 +++++++++++++----------
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 35 +++++++++++++++---------------
> 7 files changed, 59 insertions(+), 60 deletions(-)
> create mode 100644 drivers/gpu/drm/tilcdc/Module.symvers
>
next prev parent reply other threads:[~2014-06-27 22:08 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1402110128-30471-1-git-send-email-guido@vanguardiasur.com.ar>
2014-06-17 14:17 ` [PATCH/RESEND 0/9] drm: tilcdc driver fixes Guido Martínez
2014-06-17 14:17 ` [PATCH/RESEND 1/9] drm/i2c: tda998x: move drm_i2c_encoder_destroy call Guido Martínez
2014-06-24 16:38 ` Russell King - ARM Linux
2014-06-25 3:55 ` Guido Martínez
2014-06-17 14:17 ` [PATCH/RESEND 2/9] drm/tilcdc: panel: fix dangling sysfs connector node Guido Martínez
2014-06-17 14:17 ` [PATCH/RESEND 3/9] drm/tilcdc: slave: " Guido Martínez
2014-06-17 14:17 ` [PATCH/RESEND 4/9] drm/tilcdc: tfp410: " Guido Martínez
2014-06-17 14:17 ` [PATCH/RESEND 5/9] drm/tilcdc: panel: fix leak when unloading the module Guido Martínez
2014-06-17 14:17 ` [PATCH/RESEND 6/9] drm/tilcdc: fix release order on exit Guido Martínez
2014-06-17 14:17 ` [PATCH/RESEND 7/9] drm/tilcdc: fix double kfree Guido Martínez
2014-06-17 14:17 ` [PATCH/RESEND 8/9] drm/tilcdc: remove submodule destroy calls Guido Martínez
2014-06-24 22:06 ` Darren Etheridge
2014-06-25 3:53 ` Guido Martínez
2014-06-25 14:53 ` Ezequiel García
2014-06-17 14:17 ` [PATCH/RESEND 9/9] drm/tilcdc: replace late_initcall with module_init Guido Martínez
2014-06-24 22:04 ` Darren Etheridge
2014-06-25 13:00 ` Russell King - ARM Linux
2014-06-25 13:13 ` Russell King - ARM Linux
2014-06-25 14:32 ` Ezequiel García
2014-06-25 14:46 ` Russell King - ARM Linux
2014-06-25 15:48 ` Ezequiel García
2014-06-19 13:41 ` [PATCH/RESEND 0/9] drm: tilcdc driver fixes Darren Etheridge
2014-06-19 16:25 ` Guido Martínez
2014-06-24 0:26 ` Guido Martínez
2014-06-27 22:08 ` Darren Etheridge [this message]
2014-06-28 10:51 ` Rob Clark
2014-07-08 10:03 ` Daniel Vetter
2014-07-01 23:39 ` Guido Martínez
2014-07-02 2:31 ` Darren Etheridge
2014-07-02 4:08 ` Dave Airlie
2014-07-02 20:38 ` Ezequiel García
2014-07-08 1:32 ` Dave Airlie
2014-07-01 23:52 ` Guido Martínez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53ADEB73.8090301@ti.com \
--to=detheridge@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox