From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v1 6/9] usb: xhci: Add NVIDIA Tegra XHCI host-controller driver
Date: Fri, 27 Jun 2014 16:01:06 -0600 [thread overview]
Message-ID: <53ADE9A2.5020305@wwwdotorg.org> (raw)
In-Reply-To: <CAL1qeaEb2aV16F+sXWZ=FtEFW2rcGHhqVJk7+OmU5AtjZiHBDQ@mail.gmail.com>
On 06/27/2014 03:19 PM, Andrew Bresticker wrote:
> On Thu, Jun 26, 2014 at 11:07 AM, Stephen Warren <swarren@wwwdotorg•org> wrote:
>> On 06/25/2014 06:06 PM, Andrew Bresticker wrote:
>>> On Wed, Jun 25, 2014 at 3:37 PM, Stephen Warren <swarren@wwwdotorg•org> wrote:
>>>> On 06/18/2014 12:16 AM, Andrew Bresticker wrote:
>>>>> Add support for the on-chip XHCI host controller present on Tegra SoCs.
>>>>>
>>>>> The driver is currently very basic: it loads the controller with its
>>>>> firmware, starts the controller, and is able to service messages sent
>>>>> by the controller's firmware. The hardware supports device mode as
>>>>> well as runtime power-gating, but support for these is not yet
>>>>> implemented here.
>
>>>>> diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c
>
>>>>> +static int tegra_xhci_set_ss_clk(struct tegra_xhci_hcd *tegra,
>>>>> + unsigned long rate)
>>>>
>>>>> + switch (rate) {
>>>>> + case TEGRA_XHCI_SS_CLK_HIGH_SPEED:
>>>>> + /* Reparent to PLLU_480M. Set div first to avoid overclocking */
>>>>> + old_parent_rate = clk_get_rate(clk_get_parent(clk));
>>>>> + new_parent_rate = clk_get_rate(tegra->pll_u_480m);
>>>>> + div = new_parent_rate / rate;
>>>>> + ret = clk_set_rate(clk, old_parent_rate / div);
>>>>> + if (ret)
>>>>> + return ret;
>>>>> + ret = clk_set_parent(clk, tegra->pll_u_480m);
>>>>> + if (ret)
>>>>> + return ret;
>>>>
>>>> Don't you need to call clk_set_rate() again after reparenting, since the
>>>> divisor will be different, and the rounding too.
>>>
>>> Nope, the divider we set before remains in-tact after clk_set_parent().
>>
>> Oh I see, the clk_set_rate() call is setting up div so it's appropriate
>> after the new parent is selected.
>>
>> Wouldn't it be better to just stop the clock, assert reset, reparent the
>> clock, and then set the desired rate directly?
>
> I'm not sure how that would be better than making it more obvious as
> to how we arrive at the final rate. Keep in mind that the XHCI host
> is running at this point (we usually get the scale-up message as a
> USB3 device is being enumerated) and that disabling the clock and/or
> asserting reset to the SS partition clock may not be the best idea...
Oh, this happens while the device is running rather than when
initializing it? Applying reset is probably a bad idea then. Still,
perhaps stopping the clock for a short time is fine? What about:
clk_disable_unprepare(clk);
clk_set_parent(clk, tegra->pll_u_480m);
clk_set_rate(clk, rate);
clk_prepare_enable(clk);
That seems much more direct to me. The code above feels over-complex to me.
If the clock really can't be stopped, then I suppose the existing code
in the patch is fine. I'd like to see a final clk_get_rate(clk) call
added, and the value compared against the expected value, to make sure
no rounding/truncation of the divider happened though.
next prev parent reply other threads:[~2014-06-27 22:01 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 6:16 [PATCH v1 0/9] Tegra XHCI support Andrew Bresticker
2014-06-18 6:16 ` [PATCH v1 1/9] of: Add NVIDIA Tegra XUSB mailbox binding Andrew Bresticker
2014-06-25 21:42 ` Stephen Warren
2014-06-25 22:37 ` Andrew Bresticker
2014-06-25 23:00 ` Stephen Warren
2014-06-18 6:16 ` [PATCH v1 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver Andrew Bresticker
2014-06-25 22:02 ` Stephen Warren
2014-06-25 23:07 ` Andrew Bresticker
2014-06-18 6:16 ` [PATCH v1 3/9] of: Update Tegra XUSB pad controller binding for USB Andrew Bresticker
2014-06-25 21:46 ` Stephen Warren
2014-06-25 22:25 ` Andrew Bresticker
2014-06-26 20:00 ` Stephen Warren
2014-06-18 6:16 ` [PATCH v1 4/9] pinctrl: tegra-xusb: Add USB PHY support Andrew Bresticker
2014-06-25 22:12 ` Stephen Warren
2014-06-25 23:30 ` Andrew Bresticker
2014-06-26 18:08 ` Stephen Warren
2014-06-27 21:22 ` Andrew Bresticker
2014-06-27 15:00 ` Felipe Balbi
2014-06-27 16:05 ` Stephen Warren
2014-06-18 6:16 ` [PATCH v1 5/9] of: Add NVIDIA Tegra XHCI controller binding Andrew Bresticker
2014-06-25 21:52 ` Stephen Warren
2014-06-25 23:01 ` Andrew Bresticker
2014-06-25 23:13 ` Stephen Warren
2014-06-25 21:54 ` Stephen Warren
2014-06-25 23:02 ` Andrew Bresticker
2014-06-25 23:14 ` Stephen Warren
2014-06-18 6:16 ` [PATCH v1 6/9] usb: xhci: Add NVIDIA Tegra XHCI host-controller driver Andrew Bresticker
2014-06-20 16:58 ` Julius Werner
2014-07-08 21:52 ` Andrew Bresticker
2014-07-09 14:08 ` Alan Stern
2014-07-10 10:40 ` Arnd Bergmann
2014-06-25 22:37 ` Stephen Warren
2014-06-26 0:06 ` Andrew Bresticker
2014-06-26 18:07 ` Stephen Warren
2014-06-27 21:19 ` Andrew Bresticker
2014-06-27 22:01 ` Stephen Warren [this message]
2014-06-18 6:16 ` [PATCH v1 7/9] ARM: tegra: Add Tegra124 XUSB mailbox and XHCI controller Andrew Bresticker
2014-06-18 6:16 ` [PATCH v1 8/9] ARM: tegra: jetson-tk1: Add XHCI support Andrew Bresticker
2014-06-18 6:16 ` [PATCH v1 9/9] ARM: tegra: venice2: " Andrew Bresticker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53ADE9A2.5020305@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox