From: santosh.shilimkar@ti•com (Santosh Shilimkar)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 0/3] ARM: mvebu: disable I/O coherency on !SMP
Date: Thu, 17 Jul 2014 12:04:26 -0400 [thread overview]
Message-ID: <53C7F40A.800@ti.com> (raw)
In-Reply-To: <5105942.b7kcvNdlC8@wuerfel>
On Thursday 17 July 2014 11:53 AM, Arnd Bergmann wrote:
> On Thursday 17 July 2014 16:34:01 Russell King - ARM Linux wrote:
>> On Thu, Jul 17, 2014 at 04:40:21PM +0200, Arnd Bergmann wrote:
>>> On Thursday 17 July 2014 15:27:20 Will Deacon wrote:
>>>> Just an FYI, but I've had to check internally to clarify the behaviour
>>>> around TLB conflict aborts. We're changing live page tables here, but the
>>>> *only* thing to differ is the output address, which I would hope is ok but
>>>> need to check to be sure.
>>>
>>> The two cases are slightly different:
>>>
>>> - The existing keystone code changes the output address but not the flags
>>> - The hypothetical mvebu code needs to change the flags but not the address.
>>
>> Don't base too much confidence in the keystone code:
>
> What I meant was that verifying the correctness of one of the two above
> with the architecture team doesn't mean that the other one is okay too.
>
>> map_start = init_mm.start_code;
>> map_end = init_mm.brk;
>>
>> phys = __pa(map_start) & PMD_MASK;
>> do {
>> ...
>> phys += PMD_SIZE;
>> } while (phys < map_end);
>>
>> Consider what happens when map_end is not PMD aligned - it misses the
>> PMD covering the end of the kernel BSS, which will be quite a common
>> case. Obviously something that needs fixing...
>
> Ouch.
>
Thanks for spotting it RMK. Will have a loot at it.
regards,
Santosh
next prev parent reply other threads:[~2014-07-17 16:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 16:21 [PATCH 0/3] ARM: mvebu: disable I/O coherency on !SMP Thomas Petazzoni
2014-07-02 16:21 ` [PATCH 1/3] ARM: mvebu: make the coherency_ll.S functions work with no coherency fabric Thomas Petazzoni
2014-07-02 16:21 ` [PATCH 2/3] ARM: mvebu: disable I/O coherency on non-SMP situations on Armada 370/XP Thomas Petazzoni
2014-07-02 16:21 ` [PATCH 3/3] ARM: mvebu: add missing of_node_put() call in coherency.c Thomas Petazzoni
2014-07-02 16:27 ` [PATCH 0/3] ARM: mvebu: disable I/O coherency on !SMP Andrew Lunn
2014-07-02 16:41 ` Russell King - ARM Linux
2014-07-02 17:18 ` Thomas Petazzoni
2014-07-02 17:58 ` Russell King - ARM Linux
2014-07-02 20:28 ` Thomas Petazzoni
2014-07-02 21:33 ` Russell King - ARM Linux
2014-07-02 21:50 ` Thomas Petazzoni
2014-07-17 8:24 ` Thomas Petazzoni
2014-07-17 8:33 ` Russell King - ARM Linux
2014-07-17 8:45 ` Thomas Petazzoni
2014-07-17 10:27 ` Russell King - ARM Linux
2014-07-17 10:16 ` Russell King - ARM Linux
2014-07-17 12:39 ` Arnd Bergmann
2014-07-17 13:12 ` Russell King - ARM Linux
2014-07-17 14:27 ` Will Deacon
2014-07-17 14:40 ` Arnd Bergmann
2014-07-17 15:34 ` Russell King - ARM Linux
2014-07-17 15:53 ` Arnd Bergmann
2014-07-17 16:04 ` Santosh Shilimkar [this message]
2014-07-17 16:10 ` Russell King - ARM Linux
2014-07-17 16:18 ` Santosh Shilimkar
2014-07-28 17:46 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C7F40A.800@ti.com \
--to=santosh.shilimkar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox