From: afaerber@suse•de (Andreas Färber)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 4/4] ARM: dts: Add exynos5250-spring device tree
Date: Thu, 31 Jul 2014 19:14:59 +0200 [thread overview]
Message-ID: <53DA7993.1000800@suse.de> (raw)
In-Reply-To: <CAP_ceTz+KRJzF9XV=_aLE+6sV6d5GqCtQ_daKtpFJfCZQ1erpA@mail.gmail.com>
Hi,
Am 31.07.2014 19:00, schrieb Vincent Palatin:
> Always a bit late to the game.
> One small comment inline.
>
> Reviewed-by: Vincent Palatin <vpalatin@chromium•org>
Thanks,
>
> On Thu, Jul 31, 2014 at 9:08 AM, Andreas F?rber <afaerber@suse•de> wrote:
>> + usb3_vbus_reg: regulator-usb3 {
>> + compatible = "regulator-fixed";
>> + regulator-name = "P5.0V_USB3CON";
>> + regulator-min-microvolt = <5000000>;
>> + regulator-max-microvolt = <5000000>;
>> + gpio = <&gpe1 0 GPIO_ACTIVE_LOW>;
>> + enable-active-high;
>> + };
>
> GPE1_0 GPIO is the HSIC hub (SMSC 3503) reset# line (already defined
> below afaik).
Yes, that was a suggestion you made on v1.
> On this design there is no external USB3 port, so no VBUS reg/load
> switch for USB3.
Could you be a little clearer? Are you suggesting to drop the gpio
property? I just re-tested that without the regulator node plus the
vbus-supply below I don't get any USB2 (so maybe rename the regulator?).
Regards,
Andreas
>> +
>> + usb at 12110000 {
>> + samsung,vbus-gpio = <&gpx1 1 GPIO_ACTIVE_HIGH>;
>> + };
>> +
>> + usb-hub {
>> + compatible = "smsc,usb3503a";
>> + reset-gpios = <&hsic_reset>;
>> + };
[...]
>> +&usbdrd_phy {
>> + vbus-supply = <&usb3_vbus_reg>;
>> +};
>> +
>> +#include "cros-ec-keyboard.dtsi"
>> --
>> 1.9.3
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg
next prev parent reply other threads:[~2014-07-31 17:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 16:08 [PATCH v4 0/4] ARM: dts: exynos: Prepare Spring Andreas Färber
2014-07-31 16:08 ` [PATCH v4 1/4] ARM: dts: Fix MMC pinctrl for exynos5250-snow Andreas Färber
2014-07-31 18:41 ` Kukjin Kim
2014-07-31 19:20 ` Tomasz Figa
2014-07-31 16:08 ` [PATCH v4 2/4] ARM: dts: Fold exynos5250-cros-common into exynos5250-snow Andreas Färber
2014-07-31 19:22 ` Tomasz Figa
2014-07-31 16:08 ` [PATCH v4 3/4] ARM: dts: Clean up exynos5250-snow Andreas Färber
2014-07-31 19:19 ` Tomasz Figa
2014-07-31 19:21 ` Andreas Färber
2014-07-31 16:08 ` [PATCH v4 4/4] ARM: dts: Add exynos5250-spring device tree Andreas Färber
2014-07-31 17:00 ` Vincent Palatin
2014-07-31 17:14 ` Andreas Färber [this message]
2014-07-31 17:38 ` Andreas Färber
2014-07-31 18:51 ` Vincent Palatin
2014-07-31 19:05 ` Tomasz Figa
2014-07-31 19:20 ` Andreas Färber
2014-07-31 19:40 ` Tomasz Figa
2014-07-31 23:17 ` Andreas Färber
2014-07-31 23:26 ` Tomasz Figa
2014-07-31 23:31 ` Andreas Färber
2014-08-02 5:15 ` Doug Anderson
2014-08-02 7:49 ` Andreas Färber
2014-07-31 20:36 ` Andreas Färber
2014-07-31 21:09 ` Tomasz Figa
2014-08-01 3:17 ` Andreas Färber
2014-08-02 12:40 ` Tomasz Figa
2014-07-31 16:21 ` [PATCH v4 0/4] ARM: dts: exynos: Prepare Spring Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DA7993.1000800@suse.de \
--to=afaerber@suse$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox