From: afaerber@suse•de (Andreas Färber)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 4/4] ARM: dts: Add exynos5250-spring device tree
Date: Sat, 02 Aug 2014 09:49:53 +0200 [thread overview]
Message-ID: <53DC9821.3010108@suse.de> (raw)
In-Reply-To: <CAD=FV=XVM4FUMxjindZGXku5DZ1MkTWq=Smmt_Fs7=_i4MBFKw@mail.gmail.com>
Am 02.08.2014 07:15, schrieb Doug Anderson:
> On Thu, Jul 31, 2014 at 12:40 PM, Tomasz Figa <tomasz.figa@gmail•com> wrote:
>> On 31.07.2014 21:20, Andreas F?rber wrote:
>>> Am 31.07.2014 21:05, schrieb Tomasz Figa:
>>>> On 31.07.2014 18:08, Andreas F?rber wrote:
>>>>> +&sd1_clk {
>>>>> + samsung,pin-drv = <0>;
>>>>> +};
>>>>> +
>>>>> +&sd1_cmd {
>>>>> + samsung,pin-pud = <3>;
>>>>> + samsung,pin-drv = <0>;
>>>>> +};
>>>>> +
>>>>> +&sd1_cd {
>>>>> + samsung,pin-drv = <0>;
>>>>> +};
>>>>> +
>>>>> +&sd1_bus4 {
>>>>> + samsung,pin-drv = <0>;
>>>>> +};
>>>>
>>>> Here generic settings are being overridden, so it might be a good idea
>>>> to explain why, like with i2c pull-up above.
>>>
>>> Snow does not have an explanation either, so please suggest what comment
>>> you'd like to see. Consider me just a user with no specs. :)
>>
>> Doug, Vincent, someone else?
>
> The comment is just in a different place--it's in the dw_mmc node.
> Probably belongs here, though:
>
> /*
> * Wifi is a SiP, so can keep drive strengths low
> * to reduce EMI.
> */
>
I did copy such a comment for the MMC node in v5, still present in v6.
Andreas
> I guess the cmd line isn't documented. There is no external pull on
> the command line and on most boards there is one. Our hardware guys
> thought we didn't need it and apparently we don't...
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg
next prev parent reply other threads:[~2014-08-02 7:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 16:08 [PATCH v4 0/4] ARM: dts: exynos: Prepare Spring Andreas Färber
2014-07-31 16:08 ` [PATCH v4 1/4] ARM: dts: Fix MMC pinctrl for exynos5250-snow Andreas Färber
2014-07-31 18:41 ` Kukjin Kim
2014-07-31 19:20 ` Tomasz Figa
2014-07-31 16:08 ` [PATCH v4 2/4] ARM: dts: Fold exynos5250-cros-common into exynos5250-snow Andreas Färber
2014-07-31 19:22 ` Tomasz Figa
2014-07-31 16:08 ` [PATCH v4 3/4] ARM: dts: Clean up exynos5250-snow Andreas Färber
2014-07-31 19:19 ` Tomasz Figa
2014-07-31 19:21 ` Andreas Färber
2014-07-31 16:08 ` [PATCH v4 4/4] ARM: dts: Add exynos5250-spring device tree Andreas Färber
2014-07-31 17:00 ` Vincent Palatin
2014-07-31 17:14 ` Andreas Färber
2014-07-31 17:38 ` Andreas Färber
2014-07-31 18:51 ` Vincent Palatin
2014-07-31 19:05 ` Tomasz Figa
2014-07-31 19:20 ` Andreas Färber
2014-07-31 19:40 ` Tomasz Figa
2014-07-31 23:17 ` Andreas Färber
2014-07-31 23:26 ` Tomasz Figa
2014-07-31 23:31 ` Andreas Färber
2014-08-02 5:15 ` Doug Anderson
2014-08-02 7:49 ` Andreas Färber [this message]
2014-07-31 20:36 ` Andreas Färber
2014-07-31 21:09 ` Tomasz Figa
2014-08-01 3:17 ` Andreas Färber
2014-08-02 12:40 ` Tomasz Figa
2014-07-31 16:21 ` [PATCH v4 0/4] ARM: dts: exynos: Prepare Spring Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DC9821.3010108@suse.de \
--to=afaerber@suse$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox