From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] ARM: tegra: add Acer Chromebook 13 device tree
Date: Mon, 18 Aug 2014 10:10:06 -0600 [thread overview]
Message-ID: <53F2255E.7090208@wwwdotorg.org> (raw)
In-Reply-To: <53EF76CF.9050808@suse.de>
On 08/16/2014 09:20 AM, Andreas F?rber wrote:
> Hi,
>
> Am 13.08.2014 21:14, schrieb Dylan Reid:
>> The Acer Chromebook 13, codenamed Big, contains an NVIDIA tegra124
>> processor and is similar to the Venice2 reference platform.
>>
>> The keyboard, USB 2, audio, HDMI, sdcard, and emmc have been tested
>> and work on the 1266x768 models. The HD models haven't yet been
>> tested.
>>
>> WiFi does not work yet, it needs at least some PMIC changes to enable
>> the 32k clock.
>>
>> The elan trackpad is not yet functional but hopefully will be soon as
>> there are patches under review.
>>
>> There is also an issue on reboot because the TPM isn't reset. It will
>> cause the stock firmware to enter recovery mode. This can be worked
>> around by an EC-reset, press the refresh and power keys at the same
>> time.
>> diff --git a/arch/arm/boot/dts/tegra124-nyan-big.dts b/arch/arm/boot/dts/tegra124-nyan-big.dts
>> new file mode 100644
>> index 0000000..79f1852
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/tegra124-nyan-big.dts
>> @@ -0,0 +1,1136 @@
>> +/dts-v1/;
>> +
>> +#include <dt-bindings/input/input.h>
>> +#include "tegra124.dtsi"
>> +
>> +/ {
>> + model = "Acer Chromebook 13";
>> + compatible = "google,nyan-big", "nvidia,tegra124";
>
> In light of v1 and the above commit message referring to this as Google
> Big, shouldn't this be "google,big", "nvidia,tegra124" and optionally
> "google,nyan" as secondary string, independent of the new file name?
Despite this board having been derived from Nyan, it isn't Nyan, so I
don't think Nyan should be part of any compatible value, nor a separate
compatible value.
>> + pinmux: pinmux at 0,70000868 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinmux_default>;
>> +
>> + pinmux_default: common {
>> + dap_mclk1_pw4 {
>
> Any need to have the nodes this way? Shouldn't this rather be
> dap-mclk1-pw4 as node name by conventions, with a dap_mclk1_pw4 label
> for referencing if needed? Same below, obviously.
Underscores are consistent with at least all the other Tegra DTs, so I
think this is best as is.
>> + pwm: pwm at 0,7000a000 {
>
> Add the label to the .dtsi where the node is first declared? Then you
> can override it the safer &pwm { ... }; way. Same for all other nodes
> being extended/overridden here - that's what your colleagues requested
> for Spring. It'll help with the 80 char limit further below by reducing
> indentation.
We certainly do have the pwm label in *.dtsi for other SoCs, so we
should probably move the label there.
Using the &pwm {} syntax would be inconsistent with all the other Tegra
DTs, and isn't really any safer; the HW isn't going to change, so once
this is written, it should continue to "just work".
next prev parent reply other threads:[~2014-08-18 16:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 19:14 [PATCH v2] ARM: tegra: add Acer Chromebook 13 device tree Dylan Reid
2014-08-16 15:20 ` Andreas Färber
2014-08-18 16:10 ` Stephen Warren [this message]
2014-08-18 17:03 ` Andreas Färber
2014-08-18 23:24 ` Andrew Bresticker
2014-08-18 23:43 ` Stephen Warren
2014-08-19 0:11 ` Andrew Bresticker
2014-08-19 21:47 ` Stephen Warren
2014-08-20 5:36 ` Thierry Reding
2014-08-20 13:37 ` Olof Johansson
2014-08-20 15:25 ` Thierry Reding
2014-08-20 17:25 ` Andrew Bresticker
2014-08-20 13:29 ` Olof Johansson
2014-08-20 14:32 ` Thierry Reding
2014-08-20 15:40 ` Olof Johansson
2014-08-21 7:19 ` Thierry Reding
2014-08-18 23:05 ` Andrew Bresticker
2014-09-04 19:40 ` Stephen Warren
2014-09-04 20:33 ` Dylan Reid
2014-09-04 21:04 ` Stephen Warren
2014-09-04 21:08 ` Dylan Reid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F2255E.7090208@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox