From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] ARM: tegra: add Acer Chromebook 13 device tree
Date: Thu, 04 Sep 2014 15:04:55 -0600 [thread overview]
Message-ID: <5408D3F7.5080200@wwwdotorg.org> (raw)
In-Reply-To: <CAEUnVG5xdbGZS5pFef0mkCB15pCCFR=vW5rELwU--KTBCT_feQ@mail.gmail.com>
On 09/04/2014 02:33 PM, Dylan Reid wrote:
> On Thu, Sep 4, 2014 at 12:40 PM, Stephen Warren <swarren@wwwdotorg•org> wrote:
>> On 08/13/2014 01:14 PM, Dylan Reid wrote:
>>>
>>> The Acer Chromebook 13, codenamed Big, contains an NVIDIA tegra124
>>> processor and is similar to the Venice2 reference platform.
>>>
>>> The keyboard, USB 2, audio, HDMI, sdcard, and emmc have been tested
>>> and work on the 1266x768 models. The HD models haven't yet been
>>> tested.
>>>
>>> WiFi does not work yet, it needs at least some PMIC changes to enable
>>> the 32k clock.
>>>
>>> The elan trackpad is not yet functional but hopefully will be soon as
>>> there are patches under review.
>>>
>>> There is also an issue on reboot because the TPM isn't reset. It will
>>> cause the stock firmware to enter recovery mode. This can be worked
>>> around by an EC-reset, press the refresh and power keys at the same
>>> time.
>>
>>
>> BTW, I'm only waiting on a few minor fixes for issues pointed out by Andreas
>> before applying this patch:
>
> Thanks Stephen,
>
> Sorry I've been MIA, things have been a little crazy here.
>
>> * Resolution typo in the commit message.
>> * Sort order of the Makefile addition.
>> * pwm: label move.
>
> If I move the pwm label, should I move the others as well? Do we want
> to use the same method that has been used for exynos5250? Exynos has
> a label on most things that are overridden and the .dts files that
> override them, like exynos5250-snow.dts, access them with &label
> syntax. It's easy for me to do, but it will involve converting
> venice2 and jetson as well to avoid label re-defines.
I think anything that's first defined in tegra124.dtsi should have the
label defined in tegra124.dtsi, provided the label makes sens across all
boards. From v2 of the patch, that looks like: dpaux, pwm. It looks like
the pinmux label isn't used, so I'd suggest dropping that. The label
name hdmi_ddc feels board-specific (since different boards could at
least theoretically use different I2C controllers for DDC), so I'd leave
that in the board dts file myself.
The &label { ... } syntax wouldn't be consistent with any of the other
Tegra files at the moment, so I'd suggest sticking to the overall DT
structure you already have in patch v2. I admit it's unfortunate that
Exynos and Tegra use different node reference styles, but consistency
between all the Tegra DT files feels most important to me right now:-)
next prev parent reply other threads:[~2014-09-04 21:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 19:14 [PATCH v2] ARM: tegra: add Acer Chromebook 13 device tree Dylan Reid
2014-08-16 15:20 ` Andreas Färber
2014-08-18 16:10 ` Stephen Warren
2014-08-18 17:03 ` Andreas Färber
2014-08-18 23:24 ` Andrew Bresticker
2014-08-18 23:43 ` Stephen Warren
2014-08-19 0:11 ` Andrew Bresticker
2014-08-19 21:47 ` Stephen Warren
2014-08-20 5:36 ` Thierry Reding
2014-08-20 13:37 ` Olof Johansson
2014-08-20 15:25 ` Thierry Reding
2014-08-20 17:25 ` Andrew Bresticker
2014-08-20 13:29 ` Olof Johansson
2014-08-20 14:32 ` Thierry Reding
2014-08-20 15:40 ` Olof Johansson
2014-08-21 7:19 ` Thierry Reding
2014-08-18 23:05 ` Andrew Bresticker
2014-09-04 19:40 ` Stephen Warren
2014-09-04 20:33 ` Dylan Reid
2014-09-04 21:04 ` Stephen Warren [this message]
2014-09-04 21:08 ` Dylan Reid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5408D3F7.5080200@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox