From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/9] of: Add NVIDIA Tegra XUSB mailbox binding
Date: Mon, 25 Aug 2014 12:48:23 -0600 [thread overview]
Message-ID: <53FB84F7.8030509@wwwdotorg.org> (raw)
In-Reply-To: <1408381705-3623-2-git-send-email-abrestic@chromium.org>
On 08/18/2014 11:08 AM, Andrew Bresticker wrote:
> Add device-tree bindings for the Tegra XUSB mailbox which will be used
> for communication between the Tegra xHCI controller's firmware and the
> host processor.
> diff --git a/Documentation/devicetree/bindings/mailbox/nvidia,tegra124-xusb-mbox.txt b/Documentation/devicetree/bindings/mailbox/nvidia,tegra124-xusb-mbox.txt
> +NVIDIA Tegra XUSB mailbox
> +=========================
> +
> +The Tegra XUSB mailbox is used by the Tegra xHCI controller's firmware to
> +communicate requests to the host and PHY drivers.
> +
> +Required properties:
> +--------------------
> + - compatible: Should be "nvidia,tegra124-xusb-mbox".
> + - reg: Address and length of the XUSB FPCI registers.
> + - interrupts: XUSB mailbox interrupt.
> + - #mbox-cells: Should be 1. The specifier is the index of the mailbox to
> + reference. See <dt-bindings/mailbox/tegra-xusb-mailbox.h> for the list
> + of valid values.
Is there a common mailbox binding somewhere? I couldn't find one. While
the text above specifies the value for #mbox-cells, it doesn't specify
the details of what the property is used for (i.e. there's no
documentation of the consumer-side of this property, for parsing the
mboxes property). Typically, that would be part of a subsystem's common
binding document, and that document would be referenced here.
> diff --git a/include/dt-bindings/mailbox/tegra-xusb-mailbox.h b/include/dt-bindings/mailbox/tegra-xusb-mailbox.h
> +#define TEGRA_XUSB_MBOX_CHAN_HOST 0
> +#define TEGRA_XUSB_MBOX_CHAN_PHY 1
I can't work out how these values relate to hardware at all. Are they in
fact properties of the particular firmware that's loaded into the XUSB
module? If so, I don't think the DT should contain these values at all.
I wonder if the individual MBOX_CMD_* values from patch 2 are any
better, although I think those are also defined by the firmware, not the
hardware?
next prev parent reply other threads:[~2014-08-25 18:48 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 17:08 [PATCH v2 0/9] Tegra xHCI support Andrew Bresticker
2014-08-18 17:08 ` [PATCH v2 1/9] of: Add NVIDIA Tegra XUSB mailbox binding Andrew Bresticker
2014-08-25 18:48 ` Stephen Warren [this message]
2014-08-25 19:06 ` Stephen Warren
2014-08-27 16:33 ` Andrew Bresticker
2014-08-18 17:08 ` [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver Andrew Bresticker
2014-08-25 19:01 ` Stephen Warren
2014-08-26 6:57 ` Thierry Reding
2014-08-26 7:43 ` Arnd Bergmann
2014-08-26 7:50 ` Thierry Reding
2014-08-26 8:09 ` Arnd Bergmann
2014-08-26 9:08 ` Thierry Reding
2014-08-26 9:54 ` Arnd Bergmann
2014-08-26 10:20 ` Thierry Reding
2014-08-26 11:35 ` Arnd Bergmann
2014-08-26 11:45 ` Thierry Reding
2014-08-26 8:54 ` David Laight
2014-08-26 10:04 ` Arnd Bergmann
2014-08-27 17:38 ` Andrew Bresticker
2014-08-27 17:50 ` Stephen Warren
2014-08-27 18:13 ` Andrew Bresticker
2014-08-27 18:19 ` Stephen Warren
2014-08-27 21:56 ` Andrew Bresticker
2014-08-27 22:30 ` Stephen Warren
2014-08-27 19:26 ` Jassi Brar
2014-08-18 17:08 ` [PATCH v2 3/9] of: Update Tegra XUSB pad controller binding for USB Andrew Bresticker
2014-08-25 19:12 ` Stephen Warren
2014-08-27 16:36 ` Andrew Bresticker
2014-08-27 16:42 ` Stephen Warren
2014-08-18 17:08 ` [PATCH v2 4/9] pinctrl: tegra-xusb: Add USB PHY support Andrew Bresticker
2014-08-25 19:22 ` Stephen Warren
2014-08-26 7:29 ` Mikko Perttunen
2014-08-27 16:44 ` Andrew Bresticker
2014-08-29 13:36 ` Linus Walleij
2014-08-18 17:08 ` [PATCH v2 5/9] of: Add NVIDIA Tegra xHCI controller binding Andrew Bresticker
2014-08-25 19:26 ` Stephen Warren
2014-08-18 17:08 ` [PATCH v2 6/9] usb: xhci: Add NVIDIA Tegra xHCI host-controller driver Andrew Bresticker
2014-08-25 19:36 ` Stephen Warren
2014-08-30 21:15 ` Greg Kroah-Hartman
2014-08-31 19:04 ` Andrew Bresticker
2014-08-18 17:08 ` [PATCH v2 7/9] ARM: tegra: Add Tegra124 XUSB mailbox and xHCI controller Andrew Bresticker
2014-08-18 17:08 ` [PATCH v2 8/9] ARM: tegra: jetson-tk1: Add xHCI support Andrew Bresticker
2014-08-18 17:08 ` [PATCH v2 9/9] ARM: tegra: venice2: " Andrew Bresticker
2014-08-18 17:30 ` [PATCH v2 0/9] Tegra " Stephen Warren
2014-08-18 19:35 ` Andrew Bresticker
2014-08-21 13:34 ` Tomeu Vizoso
2014-08-21 17:26 ` Andrew Bresticker
2014-08-22 11:23 ` Tomeu Vizoso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FB84F7.8030509@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox