From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 3/9] of: Update Tegra XUSB pad controller binding for USB
Date: Wed, 27 Aug 2014 10:42:19 -0600 [thread overview]
Message-ID: <53FE0A6B.8000607@wwwdotorg.org> (raw)
In-Reply-To: <CAL1qeaGHuMegpeyumD8GrFRmeufkiiUygAdqu1ECHrfSkixwOQ@mail.gmail.com>
On 08/27/2014 10:36 AM, Andrew Bresticker wrote:
> On Mon, Aug 25, 2014 at 12:12 PM, Stephen Warren <swarren@wwwdotorg•org> wrote:
>> On 08/18/2014 11:08 AM, Andrew Bresticker wrote:
>>> - #phy-cells: Should be 1. The specifier is the index of the PHY to
>>> reference.
>>> See <dt-bindings/pinctrl/pinctrl-tegra-xusb.h> for the list of valid
>>> values.
>>> +- mboxes: Must contain an entry for the XUSB PHY mailbox channel.
>>> + See ../mailbox/mailbox.txt for details.
>>
>>
>> Can we require the mbox-names property here, so that everything is looked up
>> by names. I know that the proposed mbox binding states that using indexes is
>> preferred over names, but that's just silly considering that names are
>> widely used in most other similar bindings, and are much easier to extend in
>> a backwards compatible fashion in the face of optional entries. As such, I'd
>> prefer that all Tegra bindings use foo-names properties where they exist.
>
> Sure, will do.
>
>>> +Optional properties:
>>> +-------------------
>>> +- vbus-otg-{0,1,2}-supply: VBUS regulator for the corresponding UTMI pad.
>>
>>
>> Why "-otg"? It's quite possible to have a regulator for VBUS even on systems
>> that don't support OTG, but rather simply have the ability to turn VBUS off.
>
> Because they're the VBUS supplies for the OTG 'lanes'. It doesn't
> really add anything, so I'll omit the "-otg".
Ah right. In that case, if the lanes are named "OTG" lanes in the HW
docs, I'm happy either way. If you did decide to keep the "-otg",
rewording as "VBUS regulator for the corresponding OTG UTMI pad" would
make the meaning clearer.
next prev parent reply other threads:[~2014-08-27 16:42 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 17:08 [PATCH v2 0/9] Tegra xHCI support Andrew Bresticker
2014-08-18 17:08 ` [PATCH v2 1/9] of: Add NVIDIA Tegra XUSB mailbox binding Andrew Bresticker
2014-08-25 18:48 ` Stephen Warren
2014-08-25 19:06 ` Stephen Warren
2014-08-27 16:33 ` Andrew Bresticker
2014-08-18 17:08 ` [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver Andrew Bresticker
2014-08-25 19:01 ` Stephen Warren
2014-08-26 6:57 ` Thierry Reding
2014-08-26 7:43 ` Arnd Bergmann
2014-08-26 7:50 ` Thierry Reding
2014-08-26 8:09 ` Arnd Bergmann
2014-08-26 9:08 ` Thierry Reding
2014-08-26 9:54 ` Arnd Bergmann
2014-08-26 10:20 ` Thierry Reding
2014-08-26 11:35 ` Arnd Bergmann
2014-08-26 11:45 ` Thierry Reding
2014-08-26 8:54 ` David Laight
2014-08-26 10:04 ` Arnd Bergmann
2014-08-27 17:38 ` Andrew Bresticker
2014-08-27 17:50 ` Stephen Warren
2014-08-27 18:13 ` Andrew Bresticker
2014-08-27 18:19 ` Stephen Warren
2014-08-27 21:56 ` Andrew Bresticker
2014-08-27 22:30 ` Stephen Warren
2014-08-27 19:26 ` Jassi Brar
2014-08-18 17:08 ` [PATCH v2 3/9] of: Update Tegra XUSB pad controller binding for USB Andrew Bresticker
2014-08-25 19:12 ` Stephen Warren
2014-08-27 16:36 ` Andrew Bresticker
2014-08-27 16:42 ` Stephen Warren [this message]
2014-08-18 17:08 ` [PATCH v2 4/9] pinctrl: tegra-xusb: Add USB PHY support Andrew Bresticker
2014-08-25 19:22 ` Stephen Warren
2014-08-26 7:29 ` Mikko Perttunen
2014-08-27 16:44 ` Andrew Bresticker
2014-08-29 13:36 ` Linus Walleij
2014-08-18 17:08 ` [PATCH v2 5/9] of: Add NVIDIA Tegra xHCI controller binding Andrew Bresticker
2014-08-25 19:26 ` Stephen Warren
2014-08-18 17:08 ` [PATCH v2 6/9] usb: xhci: Add NVIDIA Tegra xHCI host-controller driver Andrew Bresticker
2014-08-25 19:36 ` Stephen Warren
2014-08-30 21:15 ` Greg Kroah-Hartman
2014-08-31 19:04 ` Andrew Bresticker
2014-08-18 17:08 ` [PATCH v2 7/9] ARM: tegra: Add Tegra124 XUSB mailbox and xHCI controller Andrew Bresticker
2014-08-18 17:08 ` [PATCH v2 8/9] ARM: tegra: jetson-tk1: Add xHCI support Andrew Bresticker
2014-08-18 17:08 ` [PATCH v2 9/9] ARM: tegra: venice2: " Andrew Bresticker
2014-08-18 17:30 ` [PATCH v2 0/9] Tegra " Stephen Warren
2014-08-18 19:35 ` Andrew Bresticker
2014-08-21 13:34 ` Tomeu Vizoso
2014-08-21 17:26 ` Andrew Bresticker
2014-08-22 11:23 ` Tomeu Vizoso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FE0A6B.8000607@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox