From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 06/17] gpio: mvebu: add suspend/resume support
Date: Fri, 31 Oct 2014 08:52:15 +0100 [thread overview]
Message-ID: <54533FAF.7010505@free-electrons.com> (raw)
In-Reply-To: <CACRpkda-8p=e_12vpUNt3_Y0EVPDArEKJUi63B8CGemNwVuQ0w@mail.gmail.com>
Hi Linus,
>
>> + switch (mvchip->soc_variant) {
>> + case MVEBU_GPIO_SOC_VARIANT_ORION:
>> + mvchip->edge_mask_regs[0] =
>> + readl(mvchip->membase + GPIO_EDGE_MASK_OFF);
>> + mvchip->level_mask_regs[0] =
>> + readl(mvchip->membase + GPIO_LEVEL_MASK_OFF);
>> + break;
>
> You are assigning index [0] twice, why? There must be some
> reason, and it should be stated in a comment. If the first read
> is necessary for hardware reasons, don't assign it but
> discard the result.
Maybe I missed something but for me these 2 registers are different:
one is the _EDGE_ mask and the other the _LEVEL_ mask.
Gregory
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2014-10-31 7:52 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 11:59 [PATCH 00/17] Suspend to RAM support for Armada XP Thomas Petazzoni
2014-10-24 11:59 ` [PATCH 01/17] Documentation: dt-bindings: minimal documentation for MVEBU SDRAM controller Thomas Petazzoni
2014-11-03 17:05 ` Gregory CLEMENT
2014-10-24 11:59 ` [PATCH 02/17] ARM: mvebu: enable strex backoff delay Thomas Petazzoni
2014-11-03 17:08 ` Gregory CLEMENT
2014-10-24 11:59 ` [PATCH 03/17] irqchip: irq-armada-370-xp: use proper return value for ->set_affinity() Thomas Petazzoni
2014-11-03 17:20 ` Gregory CLEMENT
2014-11-07 4:09 ` Jason Cooper
2014-10-24 11:59 ` [PATCH 04/17] irqchip: irq-armada-370-xp: suspend/resume support Thomas Petazzoni
2014-11-03 17:38 ` Gregory CLEMENT
2014-11-13 16:32 ` Thomas Petazzoni
2014-10-24 11:59 ` [PATCH 05/17] clocksource: time-armada-370-xp: add " Thomas Petazzoni
2014-11-03 17:45 ` Gregory CLEMENT
2014-10-24 11:59 ` [PATCH 06/17] gpio: mvebu: " Thomas Petazzoni
2014-10-24 16:30 ` David Cohen
2014-10-24 20:45 ` Andrew Lunn
2014-10-27 5:27 ` Alexandre Courbot
2014-10-27 17:45 ` David Cohen
2014-10-31 7:00 ` Linus Walleij
2014-10-31 7:52 ` Gregory CLEMENT [this message]
2014-10-31 8:14 ` Thomas Petazzoni
2014-11-03 13:26 ` Linus Walleij
2014-11-03 13:29 ` Linus Walleij
2014-11-03 17:53 ` Gregory CLEMENT
2014-11-03 21:21 ` Thomas Petazzoni
2014-10-24 11:59 ` [PATCH 07/17] bus: mvebu-mbus: " Thomas Petazzoni
2014-11-03 18:08 ` Gregory CLEMENT
2014-11-03 21:20 ` Thomas Petazzoni
2014-10-24 11:59 ` [PATCH 08/17] bus: mvebu-mbus: provide a mechanism to save SDRAM window configuration Thomas Petazzoni
2014-11-04 9:17 ` Gregory CLEMENT
2014-10-24 11:59 ` [PATCH 09/17] clk: mvebu: add suspend/resume for gatable clocks Thomas Petazzoni
2014-11-04 9:32 ` Gregory CLEMENT
2014-10-24 11:59 ` [PATCH 10/17] ARM: mvebu: implement suspend/resume support for Armada XP Thomas Petazzoni
2014-11-04 10:00 ` Gregory CLEMENT
2014-11-13 17:00 ` Thomas Petazzoni
2014-10-24 11:59 ` [PATCH 11/17] ARM: mvebu: reserve the first 10 KB of each memory bank for suspend/resume Thomas Petazzoni
2014-11-04 10:09 ` Gregory CLEMENT
2014-10-24 11:59 ` [PATCH 12/17] ARM: mvebu: Armada XP GP specific suspend/resume code Thomas Petazzoni
2014-10-24 14:20 ` Andrew Lunn
2014-10-24 14:28 ` Thomas Petazzoni
2014-10-24 14:51 ` Andrew Lunn
2014-10-27 12:51 ` Thomas Petazzoni
2014-10-27 14:19 ` Andrew Lunn
2014-10-27 14:40 ` Thomas Petazzoni
2014-10-27 14:59 ` Andrew Lunn
2014-10-27 15:12 ` Thomas Petazzoni
2014-10-27 15:15 ` Andrew Lunn
2014-11-10 13:53 ` Gregory CLEMENT
2014-10-24 11:59 ` [PATCH 13/17] ARM: mvebu: make sure MMU is disabled in armada_370_xp_cpu_resume Thomas Petazzoni
2014-11-10 14:05 ` Gregory CLEMENT
2014-10-24 11:59 ` [PATCH 14/17] ARM: mvebu: synchronize secondary CPU clocks on resume Thomas Petazzoni
2014-11-10 14:12 ` Gregory CLEMENT
2014-10-24 11:59 ` [PATCH 15/17] ARM: mvebu: add suspend/resume DT information for Armada XP GP Thomas Petazzoni
2014-11-10 14:14 ` Gregory CLEMENT
2014-10-24 11:59 ` [PATCH 16/17] ARM: mvebu: adjust mbus controller description on Armada 370/XP Thomas Petazzoni
2014-11-10 14:15 ` Gregory CLEMENT
2014-10-24 11:59 ` [PATCH 17/17] ARM: mvebu: add SDRAM controller description for Armada XP Thomas Petazzoni
2014-11-10 14:25 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54533FAF.7010505@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox