From: s.nawrocki@samsung•com (Sylwester Nawrocki)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/3] clk: samsung: remove unnecessary inclusion of header files from clk.h
Date: Tue, 02 Dec 2014 16:23:57 +0100 [thread overview]
Message-ID: <547DD98D.3000101@samsung.com> (raw)
In-Reply-To: <1411796519-19417-4-git-send-email-pankaj.dubey@samsung.com>
Hi Pankaj,
On 27/09/14 07:41, Pankaj Dubey wrote:
> Let's remove unnecessary include of header files from clk.h and add
> required one in clk.c
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung•com>
> ---
> drivers/clk/samsung/clk.c | 3 ++-
> drivers/clk/samsung/clk.h | 4 ----
> 2 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk.c b/drivers/clk/samsung/clk.c
> index 31bf391..952f9ec 100644
> --- a/drivers/clk/samsung/clk.c
> +++ b/drivers/clk/samsung/clk.c
> @@ -11,7 +11,8 @@
> * clock framework for Samsung platforms.
> */
>
> -#include <linux/syscore_ops.h>
I've dropped this change when applying since it causes a build break:
drivers/clk/samsung/clk.c:338:15: error: variable ?samsung_clk_syscore_ops? has initializer but incomplete type
drivers/clk/samsung/clk.c:339:2: error: unknown field ?suspend? specified in initializer
drivers/clk/samsung/clk.c:339:2: warning: excess elements in struct initializer [enabled by default]
drivers/clk/samsung/clk.c:339:2: warning: (near initialization for ?samsung_clk_syscore_ops?) [enabled by default]
drivers/clk/samsung/clk.c:340:2: error: unknown field ?resume? specified in initializer
drivers/clk/samsung/clk.c:340:2: warning: excess elements in struct initializer [enabled by default]
drivers/clk/samsung/clk.c:340:2: warning: (near initialization for ?samsung_clk_syscore_ops?) [enabled by default] CC drivers/dma/virt-dma.o
drivers/clk/samsung/clk.c: In function ?samsung_clk_sleep_init?:
drivers/clk/samsung/clk.c:359:3: error: implicit declaration of function ?register_syscore_ops? [-Werror=implicit-function-declaration]
Please make sure there is no build breaks with various configs when
sending patches.
--
Regards,
Sylwester
next prev parent reply other threads:[~2014-12-02 15:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-27 5:41 [PATCH 0/3] Some cleanup for samsung clock Pankaj Dubey
2014-09-27 5:41 ` [PATCH 1/3] clk: samsung: Spelling s/bwtween/between/ Pankaj Dubey
2014-09-27 12:56 ` Tomasz Figa
2014-09-27 5:41 ` [PATCH 2/3] clk: samsung: remove unnecessary CONFIG_OF from clk.c Pankaj Dubey
2014-09-27 13:20 ` Tomasz Figa
2014-09-29 7:30 ` Pankaj Dubey
2014-09-27 5:41 ` [PATCH 3/3] clk: samsung: remove unnecessary inclusion of header files from clk.h Pankaj Dubey
2014-12-02 15:23 ` Sylwester Nawrocki [this message]
2014-12-03 11:42 ` Pankaj Dubey
2014-12-03 12:04 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547DD98D.3000101@samsung.com \
--to=s.nawrocki@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox