From: pankaj.dubey@samsung•com (Pankaj Dubey)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/3] clk: samsung: remove unnecessary inclusion of header files from clk.h
Date: Wed, 03 Dec 2014 17:12:32 +0530 [thread overview]
Message-ID: <547EF728.90505@samsung.com> (raw)
In-Reply-To: <547DD98D.3000101@samsung.com>
Hi Sylwester,
On Tuesday 02 December 2014 08:53 PM, Sylwester Nawrocki wrote:
> Hi Pankaj,
>
> On 27/09/14 07:41, Pankaj Dubey wrote:
>> Let's remove unnecessary include of header files from clk.h and add
>> required one in clk.c
>>
>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung•com>
>> ---
>> drivers/clk/samsung/clk.c | 3 ++-
>> drivers/clk/samsung/clk.h | 4 ----
>> 2 files changed, 2 insertions(+), 5 deletions(-)
>>
> Please make sure there is no build breaks with various configs when
> sending patches.
I am sure that I compile tested this before submitting. Looks like
following commit [1] needs "linux/syscore-ops.h" in clk.c, before that
it was not needed.
1: clk: samsung: Factor out the common code to clk.c [SHA_ID:
16a9013b83b5106c83cf]
Anyways, I can see patches are not getting cleanly applied so, just now
I resend them [2] after rebasing please have a look.
2: http://comments.gmane.org/gmane.linux.kernel.samsung-soc/40639
Thanks,
Pankaj Dubey
>
> --
> Regards,
> Sylwester
>
next prev parent reply other threads:[~2014-12-03 11:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-27 5:41 [PATCH 0/3] Some cleanup for samsung clock Pankaj Dubey
2014-09-27 5:41 ` [PATCH 1/3] clk: samsung: Spelling s/bwtween/between/ Pankaj Dubey
2014-09-27 12:56 ` Tomasz Figa
2014-09-27 5:41 ` [PATCH 2/3] clk: samsung: remove unnecessary CONFIG_OF from clk.c Pankaj Dubey
2014-09-27 13:20 ` Tomasz Figa
2014-09-29 7:30 ` Pankaj Dubey
2014-09-27 5:41 ` [PATCH 3/3] clk: samsung: remove unnecessary inclusion of header files from clk.h Pankaj Dubey
2014-12-02 15:23 ` Sylwester Nawrocki
2014-12-03 11:42 ` Pankaj Dubey [this message]
2014-12-03 12:04 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547EF728.90505@samsung.com \
--to=pankaj.dubey@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox