public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed

From: pankaj.dubey@samsung•com (Pankaj Dubey)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 1/2] soc: samsung: add exynos chipid driver support
Date: Thu, 04 Dec 2014 10:30:36 +0530	[thread overview]
Message-ID: <547FEA74.1010900@samsung.com> (raw)
In-Reply-To: <19026872.NZqUJn3Abb@wuerfel>

Hi Arnd,

On Wednesday 03 December 2014 04:13 PM, Arnd Bergmann wrote:
>> Exynos SoCs have Chipid, for identification of product IDs
>> and SoC revisions. This patch intendes to provide initialization
>> code for all these functionalites, at the same time it provides some
>> sysfs entries for accessing these information to userspace.
>>
>> This driver usese existing binding for exnos-chipid.
>
> Nice!

Thanks for review.

>
> On Wednesday 03 December 2014 13:47:37 Pankaj Dubey wrote:
>
>> +       soc_dev_attr->soc_id = exynos_product_id_to_name(soc_product_id);
>> +
>> +       soc_dev = soc_device_register(soc_dev_attr);
>> +       if (IS_ERR(soc_dev))
>> +               goto free_rev;
>> +
>> +       device_create_file(soc_device_to_device(soc_dev), &exynos_product_attr);
>> +       device_create_file(soc_device_to_device(soc_dev),
>> +                               &exynos_main_rev_attr);
>> +       device_create_file(soc_device_to_device(soc_dev), &exynos_sub_rev_attr);
>> +
>
> I don't like the idea of having three extra nonstandard properties here,
> especially when you are not using the machine field for anything useful.
>

I did not get you here. Any suggestions how we can use 'machine' field 
more useful way.

> Also, all three of these just come from the same register, why expose
> them all as the machine and revision standard properties.
>

Agreed. These properties are basically giving same information but with 
small modification.
As you said these are getting exposed via standard properties as well, 
so I have no issue to drop them. Just waiting for more review from 
Samsung folks, will take care of this in next version.


Thanks,
Pankaj Dubey
> 	Arnd
>

next prev parent reply	other threads:[~2014-12-04  5:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-03  8:17 [PATCH v4 0/2] Introducing Exynos ChipId driver Pankaj Dubey
2014-12-03  8:17 ` [PATCH v4 1/2] soc: samsung: add exynos chipid driver support Pankaj Dubey
2014-12-03 10:43   ` Arnd Bergmann
2014-12-04  5:00     ` Pankaj Dubey [this message]
2014-12-04  9:12       ` Arnd Bergmann
     [not found]   ` <CAKew6eVTpu0qWQqd_sxqmRJF6qNMxJp5Mn0_ta5vO+pHAv66ug@mail.gmail.com>
2014-12-11  3:00     ` Pankaj Dubey
2014-12-03  8:17 ` [PATCH v4 2/2] ARM: EXYNOS: refactoring of mach-exynos to enable chipid driver Pankaj Dubey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547FEA74.1010900@samsung.com \
    --to=pankaj.dubey@samsung$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox