From: pankaj.dubey@samsung•com (Pankaj Dubey)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 1/2] soc: samsung: add exynos chipid driver support
Date: Thu, 11 Dec 2014 08:30:18 +0530 [thread overview]
Message-ID: <548908C2.1060906@samsung.com> (raw)
In-Reply-To: <CAKew6eVTpu0qWQqd_sxqmRJF6qNMxJp5Mn0_ta5vO+pHAv66ug@mail.gmail.com>
Hi Yadwinder,
On Thursday 04 December 2014 11:56 PM, Yadwinder Singh Brar wrote:
> Hi Pankaj,
>
>
> On Wed, Dec 3, 2014 at 1:47 PM, Pankaj Dubey <pankaj.dubey@samsung•com
> <mailto:pankaj.dubey@samsung•com>> wrote:
>
> Exynos SoCs have Chipid, for identification of product IDs
> and SoC revisions. This patch intendes to provide initialization
> code for all these functionalites, at the same time it provides some
> sysfs entries for accessing these information to userspace.
>
> This driver usese existing binding for exnos-chipid.
>
> [ ... ]
>
> +
> +static unsigned int soc_product_id;
> +static unsigned int soc_revision;
> +
> +int exynos_product_id(void)
> +{
> + return soc_product_id;
> +}
> +EXPORT_SYMBOL(exynos_product_id);
> +
> +int exynos_revision(void)
> +{
> + return soc_revision;
> +}
> +EXPORT_SYMBOL(exynos_revision);
> +
>
>
> How about exporting only a struct containing members : soc_revision,
> soc_product_id
OK, keeping in mind that chipid driver might be used from other drivers
as well (such as asv) other than from mach-exynos, we can do this.
> and may be some more like asv/fused_info and keeping these function as
Other members such as fused_info etc. can be added as and when required.
As of now there is no active user of all those.
> inlines ?
>
> +static const char *exynos_product_id_to_name(unsigned int product_id)
>
>
> __init ? hmm .. I think almost whole driver other than __ATTR funcs.
>
OK, I'll take care of this in next patch version.
> Otherwise it looks nice to me :)
>
> Best Regards,
> Yadwinder
Thanks for review.
Pankaj Dubey
next prev parent reply other threads:[~2014-12-11 3:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 8:17 [PATCH v4 0/2] Introducing Exynos ChipId driver Pankaj Dubey
2014-12-03 8:17 ` [PATCH v4 1/2] soc: samsung: add exynos chipid driver support Pankaj Dubey
2014-12-03 10:43 ` Arnd Bergmann
2014-12-04 5:00 ` Pankaj Dubey
2014-12-04 9:12 ` Arnd Bergmann
[not found] ` <CAKew6eVTpu0qWQqd_sxqmRJF6qNMxJp5Mn0_ta5vO+pHAv66ug@mail.gmail.com>
2014-12-11 3:00 ` Pankaj Dubey [this message]
2014-12-03 8:17 ` [PATCH v4 2/2] ARM: EXYNOS: refactoring of mach-exynos to enable chipid driver Pankaj Dubey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548908C2.1060906@samsung.com \
--to=pankaj.dubey@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox