From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/4] rtc: armada38x: Add the device tree binding documentation
Date: Wed, 14 Jan 2015 09:33:53 +0100 [thread overview]
Message-ID: <54B629F1.7060605@free-electrons.com> (raw)
In-Reply-To: <87iogai8sc.fsf@natisbad.org>
Hi Arnaud,
First, thanks for your extensive review.
On 14/01/2015 00:02, Arnaud Ebalard wrote:
> Hi Gregory,
>
> Gregory CLEMENT <gregory.clement@free-electrons•com> writes:
>
>> The Armada 38x SoCs come with a new RTC which differs from the one
>> used in the other mvebu SoCs until now. This patch describes the
>> binding of this RTC.
>>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons•com>
>> ---
>> .../devicetree/bindings/rtc/armada-380-rtc.txt | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/rtc/armada-380-rtc.txt
>>
>> diff --git a/Documentation/devicetree/bindings/rtc/armada-380-rtc.txt b/Documentation/devicetree/bindings/rtc/armada-380-rtc.txt
>> new file mode 100644
>> index 000000000000..2c56bef9dd7e
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/rtc/armada-380-rtc.txt
>> @@ -0,0 +1,17 @@
>> +* Real Time Clock of te Armada 38x SoCs
>> +
>> +RTC controller for the Armada 38x SoCs
>> +
>> +Required properties:
>> +- compatible : Should be "marvell,armada-380-rtc"
>> +- reg: physical base address of the controller and length of memory mapped
>> + region. The second entires is for the IP configuration part.
> ^^^^^^^
> entry
>
> I had to read probe function to understand precisely the purpose of each
> region, i.e. IMHO the description could be made a bit clearer.
Right, and as suggested by Maxime I will use reg-names
>
>> +- interrupts: IRQ line for the RTC.
>>
>> +
>> +Example:
>> +
>> +rtc at 184a8 {
>> + compatible = "marvell,armada-380-rtc";
>> + reg = <0xa3800 0x20>, <0x184a0 0x0c>;
>> + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
>> +};
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2015-01-14 8:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 15:32 [PATCH 0/4] Add a new RTC driver for recent mvebu SoCs Gregory CLEMENT
2015-01-09 15:32 ` [PATCH 1/4] rtc: armada38x: Add the device tree binding documentation Gregory CLEMENT
2015-01-13 23:02 ` Arnaud Ebalard
2015-01-14 8:13 ` Maxime Ripard
2015-01-14 8:33 ` Gregory CLEMENT [this message]
2015-01-09 15:32 ` [PATCH 2/4] drivers/rtc/rtc-armada38x: Add a new RTC driver for recent mvebu SoCs Gregory CLEMENT
2015-01-13 23:02 ` Arnaud Ebalard
2015-01-14 14:36 ` Gregory CLEMENT
2015-01-09 15:32 ` [PATCH 3/4] MAINTAINERS: Add the RTC driver for the Armada38x Gregory CLEMENT
2015-01-09 16:39 ` Sergei Shtylyov
2015-01-09 15:32 ` [PATCH 4/4] ARM: mvebu: add Device Tree description of RTC on Armada 38x Gregory CLEMENT
2015-01-13 23:03 ` Arnaud Ebalard
2015-01-14 8:14 ` Maxime Ripard
2015-01-14 8:38 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B629F1.7060605@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox