From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 4/4] ARM: mvebu: add Device Tree description of RTC on Armada 38x
Date: Wed, 14 Jan 2015 09:38:22 +0100 [thread overview]
Message-ID: <54B62AFE.1030909@free-electrons.com> (raw)
In-Reply-To: <874mrui8r3.fsf@natisbad.org>
Hi Arnaud,
On 14/01/2015 00:03, Arnaud Ebalard wrote:
> Hi Gregory,
>
> Gregory CLEMENT <gregory.clement@free-electrons•com> writes:
>
>> The Marvell Armada 38x SoCs contains an RTC which differs from the RTC
>> used in the other mvebu SoCs until now. This commit adds the Device
>> Tree description of this interface at the SoC level.
>>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons•com>
>> ---
>> arch/arm/boot/dts/armada-38x.dtsi | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi
>> index 04fe80d101f8..22909add8889 100644
>> --- a/arch/arm/boot/dts/armada-38x.dtsi
>> +++ b/arch/arm/boot/dts/armada-38x.dtsi
>> @@ -466,6 +466,12 @@
>> clocks = <&gateclk 4>;
>> };
>>
>> + rtc at 184a8 {
>> + compatible = "marvell,armada-380-rtc";
>> + reg = <0xa3800 0x20>, <0x184a0 0x0c>;
>> + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
>> + };
>> +
>
> Out of curiosity, why not naming the node rtc at a3800? Main argument:
> least expectation principle when reading the .dtsi and expecting
> increasing addresses. Or did I miss sth else?
It was a mistake, I should have used the 0xa3800 offset to name it because
most of the RTC registers are located here.
Thanks,
Gregory
>
>
>> sata at a8000 {
>> compatible = "marvell,armada-380-ahci";
>> reg = <0xa8000 0x2000>;
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
prev parent reply other threads:[~2015-01-14 8:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 15:32 [PATCH 0/4] Add a new RTC driver for recent mvebu SoCs Gregory CLEMENT
2015-01-09 15:32 ` [PATCH 1/4] rtc: armada38x: Add the device tree binding documentation Gregory CLEMENT
2015-01-13 23:02 ` Arnaud Ebalard
2015-01-14 8:13 ` Maxime Ripard
2015-01-14 8:33 ` Gregory CLEMENT
2015-01-09 15:32 ` [PATCH 2/4] drivers/rtc/rtc-armada38x: Add a new RTC driver for recent mvebu SoCs Gregory CLEMENT
2015-01-13 23:02 ` Arnaud Ebalard
2015-01-14 14:36 ` Gregory CLEMENT
2015-01-09 15:32 ` [PATCH 3/4] MAINTAINERS: Add the RTC driver for the Armada38x Gregory CLEMENT
2015-01-09 16:39 ` Sergei Shtylyov
2015-01-09 15:32 ` [PATCH 4/4] ARM: mvebu: add Device Tree description of RTC on Armada 38x Gregory CLEMENT
2015-01-13 23:03 ` Arnaud Ebalard
2015-01-14 8:14 ` Maxime Ripard
2015-01-14 8:38 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B62AFE.1030909@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox