From: tomi.valkeinen@ti•com (Tomi Valkeinen)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 01/23] ARM: OMAP2+: clock: move clock provider infrastructure to clock driver
Date: Mon, 26 Jan 2015 12:38:48 +0200 [thread overview]
Message-ID: <54C61938.8000303@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1501242142181.5450@utopia.booyaka.com>
On 24/01/15 23:51, Paul Walmsley wrote:
> + Tomi
>
> On Thu, 27 Nov 2014, Tero Kristo wrote:
>
>> Splits the clock provider init out of the PRM driver and moves it to
>> clock driver. This is needed so that once the PRCM drivers are separated,
>> they can logically just access the clock driver not needing to go through
>> common PRM code. This would be wrong in the case of control module for
>> example.
>>
>> Signed-off-by: Tero Kristo <t-kristo@ti•com>
>
> This patch moves things in the wrong direction (ie, rather than keeping
> the PRM register accesses in the PRM code, it moves PRM register accesses
> into the clock code). But I see that a subsequent patch in this series
> moves them back. So this change is temporary and that seems reasonable to
> me.
>
> However, as long as the clock code wants to do low-level register accesses
> to PRM/CM/SCM registers, there needs to be some way to keep register
> updates originating from the clock code from racing with register updates
> coming from other code (e.g. non-clock-related PRM/CM/SCM accesses). So
> I've changed this patch to use regmap (as below), and the followup patch
> later in the series will be changed too. Seems to work so far but let's
> see how things go with the rest of the series.
I'm not sure if I miss something, but regmap_write does not protect from
problems if there are multiple users for the same registers. You need to
use regmap_update_bits() to get a protected read/write sequence, in
which you can change only the bits that you want to change.
Tomi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150126/59dadd47/attachment.sig>
next prev parent reply other threads:[~2015-01-26 10:38 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 15:51 [PATCH 00/23] ARM: OMAP2+: PRCM cleanups towards 3.19 / part2 Tero Kristo
2014-11-27 15:51 ` [PATCH 01/23] ARM: OMAP2+: clock: move clock provider infrastructure to clock driver Tero Kristo
2015-01-24 21:51 ` Paul Walmsley
2015-01-26 10:38 ` Tomi Valkeinen [this message]
2015-01-26 15:49 ` Tony Lindgren
2015-01-27 11:34 ` Tomi Valkeinen
2015-01-27 16:50 ` Tony Lindgren
2015-02-13 15:06 ` Tero Kristo
2014-11-27 15:51 ` [PATCH 02/23] ARM: OMAP2+: PRCM: rename of_prcm_init to omap_prcm_init Tero Kristo
2014-11-27 15:51 ` [PATCH 03/23] ARM: OMAP2+: PRCM: split PRCM module init to their own driver files Tero Kristo
2014-11-27 15:51 ` [PATCH 04/23] ARM: OMAP24xx: clock: remove unused apll code Tero Kristo
2015-01-07 19:06 ` Tony Lindgren
2014-11-27 15:51 ` [PATCH 05/23] ARM: OMAP2: CM: remove unused PLL functions Tero Kristo
2015-01-07 19:06 ` Tony Lindgren
2014-11-27 15:51 ` [PATCH 06/23] ARM: OMAP3: PRM: invert the wkst_mask for the prm_clear_mod_irqs Tero Kristo
2014-11-27 15:51 ` [PATCH 07/23] ARM: OMAP2+: PRM: add generic API for clear_mod_irqs Tero Kristo
2014-11-27 15:51 ` [PATCH 08/23] ARM: OMAP3+: PRM: remove prm_get_reset_sources declaration from headers Tero Kristo
2015-01-07 19:06 ` Tony Lindgren
2014-11-27 15:51 ` [PATCH 09/23] ARM: OMAP3+: PRM: add common APIs for prm_vp_check/clear_txdone Tero Kristo
2014-11-27 15:51 ` [PATCH 10/23] ARM: OMAP4+: PRM: move omap_prm_base_init under OMAP4 PRM driver Tero Kristo
2014-11-27 15:51 ` [PATCH 11/23] ARM: OMAP4+: CM: move omap_cm_base_init under OMAP4 CM driver Tero Kristo
2014-11-27 15:51 ` [PATCH 12/23] ARM: OMAP2+: clock: add support for static clock memmap indexes Tero Kristo
2014-11-27 15:51 ` [PATCH 13/23] ARM: OMAP2+: CM: determine CM base address from device tree Tero Kristo
2015-01-24 19:39 ` Paul Walmsley
2015-02-13 15:07 ` Tero Kristo
2014-11-27 15:51 ` [PATCH 14/23] ARM: OMAP4: PRM: move omap4xxx_prm_init earlier in init order Tero Kristo
2014-11-27 15:51 ` [PATCH 15/23] ARM: OMAP2+: PRM: determine PRM base address from device tree Tero Kristo
2014-11-27 15:51 ` [PATCH 16/23] ARM: OMAP4: omapdss: remove legacy pad muxing support Tero Kristo
2014-11-27 16:09 ` Tomi Valkeinen
2014-11-28 7:58 ` Tero Kristo
2015-01-24 20:06 ` Paul Walmsley
2014-11-27 15:51 ` [PATCH 17/23] ARM: OMAP4: control: remove support for legacy padconf APIs Tero Kristo
2015-01-24 20:06 ` Paul Walmsley
2014-11-27 15:51 ` [PATCH 18/23] ARM: OMAP2+: control: determine control module base address from DT Tero Kristo
2014-11-27 15:51 ` [PATCH 19/23] ARM: OMAP2+: PRM: move SoC specific init calls within a generic API Tero Kristo
2014-11-27 15:51 ` [PATCH 20/23] ARM: OMAP4+: PRM: determine prm_device_inst based on DT compatibility Tero Kristo
2014-11-27 15:51 ` [PATCH 21/23] ARM: OMAP2+: CM: move SoC specific init calls within a generic API Tero Kristo
2014-11-27 15:51 ` [PATCH 22/23] ARM: OMAP4+: PRM: setup prm_features from the PRM init time flags Tero Kristo
2014-11-27 15:51 ` [PATCH 23/23] ARM: OMAP4+: PRM: get rid of cpu_is_omap44xx calls from interrupt init Tero Kristo
2014-11-27 19:15 ` [PATCH 00/23] ARM: OMAP2+: PRCM cleanups towards 3.19 / part2 Paul Walmsley
2014-12-01 15:58 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C61938.8000303@ti.com \
--to=tomi.valkeinen@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox