From: t-kristo@ti•com (Tero Kristo)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 13/23] ARM: OMAP2+: CM: determine CM base address from device tree
Date: Fri, 13 Feb 2015 17:07:34 +0200 [thread overview]
Message-ID: <54DE1336.1060407@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1501241937570.5450@utopia.booyaka.com>
On 01/24/2015 09:39 PM, Paul Walmsley wrote:
> Hi Tero
>
> On Thu, 27 Nov 2014, Tero Kristo wrote:
>
>> There is no need to provide the CM base address through a low-level API
>> from the low-level IO init, as this information is available through DT.
>> Re-routed the parsing function to be called from the CM drivers also to
>> simplify the implementation under io.c.
>>
>> Signed-off-by: Tero Kristo <t-kristo@ti•com>
>
> This one breaks boot on OMAP2430 (and presumably all other OMAP2xxx).
> Adding something like this seems to get it working.
Yeah, you are right. This patch also broke am33xx boot, I will fix this
in v2.
-Tero
>
>
> - Paul
>
> ---
> arch/arm/mach-omap2/cm_common.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/cm_common.c b/arch/arm/mach-omap2/cm_common.c
> index c2d7c7b3002c..1770364f0499 100644
> --- a/arch/arm/mach-omap2/cm_common.c
> +++ b/arch/arm/mach-omap2/cm_common.c
> @@ -234,7 +234,12 @@ static struct omap_prcm_init_data omap3_cm_data = {
> .offset = -OMAP3430_IVA2_MOD,
> };
>
> +static struct omap_prcm_init_data omap2_prcm_data = {
> + .index = CLK_MEMMAP_INDEX_CM1,
> +};
> +
> static struct of_device_id omap_cm_dt_match_table[] = {
> + { .compatible = "ti,omap2-prcm", .data = &omap2_prcm_data },
> { .compatible = "ti,omap3-cm", .data = &omap3_cm_data },
> { .compatible = "ti,omap4-cm1", .data = &cm_data },
> { .compatible = "ti,omap4-cm2", .data = &cm2_data },
>
next prev parent reply other threads:[~2015-02-13 15:07 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 15:51 [PATCH 00/23] ARM: OMAP2+: PRCM cleanups towards 3.19 / part2 Tero Kristo
2014-11-27 15:51 ` [PATCH 01/23] ARM: OMAP2+: clock: move clock provider infrastructure to clock driver Tero Kristo
2015-01-24 21:51 ` Paul Walmsley
2015-01-26 10:38 ` Tomi Valkeinen
2015-01-26 15:49 ` Tony Lindgren
2015-01-27 11:34 ` Tomi Valkeinen
2015-01-27 16:50 ` Tony Lindgren
2015-02-13 15:06 ` Tero Kristo
2014-11-27 15:51 ` [PATCH 02/23] ARM: OMAP2+: PRCM: rename of_prcm_init to omap_prcm_init Tero Kristo
2014-11-27 15:51 ` [PATCH 03/23] ARM: OMAP2+: PRCM: split PRCM module init to their own driver files Tero Kristo
2014-11-27 15:51 ` [PATCH 04/23] ARM: OMAP24xx: clock: remove unused apll code Tero Kristo
2015-01-07 19:06 ` Tony Lindgren
2014-11-27 15:51 ` [PATCH 05/23] ARM: OMAP2: CM: remove unused PLL functions Tero Kristo
2015-01-07 19:06 ` Tony Lindgren
2014-11-27 15:51 ` [PATCH 06/23] ARM: OMAP3: PRM: invert the wkst_mask for the prm_clear_mod_irqs Tero Kristo
2014-11-27 15:51 ` [PATCH 07/23] ARM: OMAP2+: PRM: add generic API for clear_mod_irqs Tero Kristo
2014-11-27 15:51 ` [PATCH 08/23] ARM: OMAP3+: PRM: remove prm_get_reset_sources declaration from headers Tero Kristo
2015-01-07 19:06 ` Tony Lindgren
2014-11-27 15:51 ` [PATCH 09/23] ARM: OMAP3+: PRM: add common APIs for prm_vp_check/clear_txdone Tero Kristo
2014-11-27 15:51 ` [PATCH 10/23] ARM: OMAP4+: PRM: move omap_prm_base_init under OMAP4 PRM driver Tero Kristo
2014-11-27 15:51 ` [PATCH 11/23] ARM: OMAP4+: CM: move omap_cm_base_init under OMAP4 CM driver Tero Kristo
2014-11-27 15:51 ` [PATCH 12/23] ARM: OMAP2+: clock: add support for static clock memmap indexes Tero Kristo
2014-11-27 15:51 ` [PATCH 13/23] ARM: OMAP2+: CM: determine CM base address from device tree Tero Kristo
2015-01-24 19:39 ` Paul Walmsley
2015-02-13 15:07 ` Tero Kristo [this message]
2014-11-27 15:51 ` [PATCH 14/23] ARM: OMAP4: PRM: move omap4xxx_prm_init earlier in init order Tero Kristo
2014-11-27 15:51 ` [PATCH 15/23] ARM: OMAP2+: PRM: determine PRM base address from device tree Tero Kristo
2014-11-27 15:51 ` [PATCH 16/23] ARM: OMAP4: omapdss: remove legacy pad muxing support Tero Kristo
2014-11-27 16:09 ` Tomi Valkeinen
2014-11-28 7:58 ` Tero Kristo
2015-01-24 20:06 ` Paul Walmsley
2014-11-27 15:51 ` [PATCH 17/23] ARM: OMAP4: control: remove support for legacy padconf APIs Tero Kristo
2015-01-24 20:06 ` Paul Walmsley
2014-11-27 15:51 ` [PATCH 18/23] ARM: OMAP2+: control: determine control module base address from DT Tero Kristo
2014-11-27 15:51 ` [PATCH 19/23] ARM: OMAP2+: PRM: move SoC specific init calls within a generic API Tero Kristo
2014-11-27 15:51 ` [PATCH 20/23] ARM: OMAP4+: PRM: determine prm_device_inst based on DT compatibility Tero Kristo
2014-11-27 15:51 ` [PATCH 21/23] ARM: OMAP2+: CM: move SoC specific init calls within a generic API Tero Kristo
2014-11-27 15:51 ` [PATCH 22/23] ARM: OMAP4+: PRM: setup prm_features from the PRM init time flags Tero Kristo
2014-11-27 15:51 ` [PATCH 23/23] ARM: OMAP4+: PRM: get rid of cpu_is_omap44xx calls from interrupt init Tero Kristo
2014-11-27 19:15 ` [PATCH 00/23] ARM: OMAP2+: PRCM cleanups towards 3.19 / part2 Paul Walmsley
2014-12-01 15:58 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DE1336.1060407@ti.com \
--to=t-kristo@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox