From: m.szyprowski@samsung•com (Marek Szyprowski)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v5 11/18] iommu: exynos: remove useless device_add/remove callbacks
Date: Mon, 26 Jan 2015 13:06:07 +0100 [thread overview]
Message-ID: <54C62DAF.6020809@samsung.com> (raw)
In-Reply-To: <20150126110059.GC30345@8bytes.org>
Hello,
On 2015-01-26 12:00, Joerg Roedel wrote:
> Hi Laurent,
>
> On Sun, Jan 25, 2015 at 05:38:22PM +0200, Laurent Pinchart wrote:
>> IOMMU groups still seem a bit unclear to me. Will Deacon has nicely explained
>> what they represent in
>> http://lists.infradead.org/pipermail/linux-arm-kernel/2014-December/310816.html.
>> The IOMMU core doesn't make groups
>> mandatory, but requires them in some code paths.
>>
>> For example the coldplug device add function add_iommu_group() called for all
>> devices already registered when bus_set_iommu() is called will try to warn of
>> devices added multiple times with a WARN_ON(dev->iommu_group). Another example
>> is the iommu_bus_notifier() function which will call the remove_device()
>> operation only when dev->iommu_group isn't NULL.
>>
>> I'm thus unsure whether groups should be made mandatory, or whether the IOMMU
>> core should be fixed to make them really optional (or, third option, whether
>> there's something I haven't understood properly).
> My plan is to make IOMMU groups mandatory. I am currently preparing and
> RFC patch-set to introduce default-domains (which will be per group). So
> when all IOMMU drivers are converted to make use of default domains the
> iommu groups will be mandatory.
Thanks for the comment, I will implement all that will be needed for it
to exynos
iommu driver, but I would like to ask if you plan to merge my existing
patches for
exynos iommu driver to your tree?
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2015-01-26 12:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 15:51 [PATCH v5 00/18] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 01/18] drm: exynos: detach from default dma-mapping domain on init Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 02/18] arm: exynos: pm_domains: add support for devices registered before arch_initcall Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 03/18] ARM: dts: exynos4: add sysmmu nodes Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 04/18] ARM: dts: exynos5250: " Marek Szyprowski
2015-01-27 6:25 ` Hongbo Zhang
2015-02-22 17:58 ` Andreas Färber
2015-01-23 15:51 ` [PATCH v5 05/18] ARM: dts: exynos5420: " Marek Szyprowski
2015-02-22 18:00 ` Andreas Färber
2015-01-23 15:51 ` [PATCH v5 06/18] iommu: exynos: don't read version register on every tlb operation Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 07/18] iommu: exynos: remove unused functions Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 08/18] iommu: exynos: remove useless spinlock Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 09/18] iommu: exynos: refactor function parameters to simplify code Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 10/18] iommu: exynos: remove unused functions, part 2 Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 11/18] iommu: exynos: remove useless device_add/remove callbacks Marek Szyprowski
2015-01-25 15:38 ` Laurent Pinchart
2015-01-26 11:00 ` Joerg Roedel
2015-01-26 11:09 ` Will Deacon
2015-01-26 12:06 ` Marek Szyprowski [this message]
2015-01-26 13:03 ` Laurent Pinchart
2015-01-26 13:47 ` Joerg Roedel
2015-01-23 15:51 ` [PATCH v5 12/18] iommu: exynos: add support for binding more than one sysmmu to master device Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 13/18] iommu: exynos: add support for runtime_pm Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 14/18] iommu: exynos: rename variables to reflect their purpose Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 15/18] iommu: exynos: document internal structures Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 16/18] iommu: exynos: remove excessive includes and sort others alphabetically Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 17/18] iommu: exynos: init from dt-specific callback instead of initcall Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 18/18] iommu: exynos: add callback for initializing devices from device tree Marek Szyprowski
2015-02-04 9:53 ` [PATCH v5 00/18] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem Hongbo Zhang
2015-02-04 13:54 ` Marek Szyprowski
2015-02-04 14:21 ` Joerg Roedel
2015-04-17 14:33 ` Javier Martinez Canillas
2015-04-17 14:48 ` Marek Szyprowski
2015-04-17 16:15 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C62DAF.6020809@samsung.com \
--to=m.szyprowski@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox