From: m.szyprowski@samsung•com (Marek Szyprowski)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v5 00/18] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem
Date: Fri, 17 Apr 2015 16:48:28 +0200 [thread overview]
Message-ID: <55311D3C.5050300@samsung.com> (raw)
In-Reply-To: <CABxcv=mXENvPHvvN5iOaUBZKORF49RhDs-tL_PBT4Urh54pd0Q@mail.gmail.com>
Hello,
On 2015-04-17 16:33, Javier Martinez Canillas wrote:
> Hello Marek,
>
> On Wed, Feb 4, 2015 at 3:21 PM, Joerg Roedel <joro@8bytes•org> wrote:
>> Hi Marek,
>>
>> On Fri, Jan 23, 2015 at 04:51:10PM +0100, Marek Szyprowski wrote:
>>> 1. All iommu related patches (with 'iommu: exynos') can be merged to
>>> iommu tree. They don't have any direct dependencies on the DTS, DRM and
>>> power domain initialization change - without them the driver will simply
>>> not initialize, when no exynos,sysmmu nodes are provided in device tree.
>>>
>>> Joerg, could you merge those patches?
>> Given the previous comments and tests on this patch set I am still
>> waiting for some Acked-bys and/or Tested-bys on this. Can you collect
>> these and resend then (probably after the v3.20 merge window)?
>>
> I rebased your patches on top of latest linux-next (next-20150415) and
> tested it on my Exynos5420 Peach Pit. HDMI display is working
> correctly (both console and X) when CONFIG_DRM_EXYNOS_IOMMU is
> enabled. I also see that the mixer is attached to the IOMMU domain:
>
> exynos-mixer 14450000.mixer: exynos_iommu_attach_device: Attached
> IOMMU with pgtable 0x6e5e0000
> ...
> exynos-sysmmu 14650000.sysmmu: Enabled
>
> As I mentioned before [0] on your v4 series, I still have the boot
> hang when CONFIG_DRM_EXYNOS_FIMD is enabled. You said that the cause
> is u-boot leaving the FIMD DMA engine enabled and so causing IOMMU
> page faults on init [1].
>
> I tried disabling the display on u-boot but the system hangs remains.
> But since I do a chain loading using the verified u-boot that comes
> with the Chromebooks, I don't know if the RO boot-loader is leaving
> something enabled.
>
> In any case since HDMI with sysmmu is working correctly, that issue is
> orthogonal to your series and can be fixed as a followup so:
>
> Tested-by: Javier Martinez Canillas <javier.martinez@collabora•co.uk>
In meantime I've managed to add UART adapter to our Chromebook Snow and
finally found the issue with FIMD. It was really nasty to debug, because
it causes a crash with console lock taken in register_framebuffer(), so
there was no debug/crash message - only complete system freeze. All this
was caused by fimd left enabled by bootloader, but with gate clock
disabled, so any access to its register caused freeze.
I need to cleanup the patches. I will rebase them and send once 4.1rc1 is
out. I'm sorry that I didn't let you know earlier, but I'm terribly busy
with other (internal) stuff right now.
> NOTE: Most of the patches don't apply cleanly so I pushed a branch [2]
> with my conflict resolution so you don't have to do the same. I also
> did some small changes like using bool instead of int when were
> assigning it to true and renaming some of the subject lines to match
> the format used by the subsystem.
>
> What I didn't change is to re-order the sysmmu device nodes according
> to the unit address that was asked by Andreas since the DTS patches
> are likely to conflict with the work Krzysztof is doing to use labels
> instead of overriding nodes in Exynos 4 and 5 DTS[i]. So you may need
> to change those anyways once Krzysztof patches land.
Thanks!
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2015-04-17 14:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 15:51 [PATCH v5 00/18] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 01/18] drm: exynos: detach from default dma-mapping domain on init Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 02/18] arm: exynos: pm_domains: add support for devices registered before arch_initcall Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 03/18] ARM: dts: exynos4: add sysmmu nodes Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 04/18] ARM: dts: exynos5250: " Marek Szyprowski
2015-01-27 6:25 ` Hongbo Zhang
2015-02-22 17:58 ` Andreas Färber
2015-01-23 15:51 ` [PATCH v5 05/18] ARM: dts: exynos5420: " Marek Szyprowski
2015-02-22 18:00 ` Andreas Färber
2015-01-23 15:51 ` [PATCH v5 06/18] iommu: exynos: don't read version register on every tlb operation Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 07/18] iommu: exynos: remove unused functions Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 08/18] iommu: exynos: remove useless spinlock Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 09/18] iommu: exynos: refactor function parameters to simplify code Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 10/18] iommu: exynos: remove unused functions, part 2 Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 11/18] iommu: exynos: remove useless device_add/remove callbacks Marek Szyprowski
2015-01-25 15:38 ` Laurent Pinchart
2015-01-26 11:00 ` Joerg Roedel
2015-01-26 11:09 ` Will Deacon
2015-01-26 12:06 ` Marek Szyprowski
2015-01-26 13:03 ` Laurent Pinchart
2015-01-26 13:47 ` Joerg Roedel
2015-01-23 15:51 ` [PATCH v5 12/18] iommu: exynos: add support for binding more than one sysmmu to master device Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 13/18] iommu: exynos: add support for runtime_pm Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 14/18] iommu: exynos: rename variables to reflect their purpose Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 15/18] iommu: exynos: document internal structures Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 16/18] iommu: exynos: remove excessive includes and sort others alphabetically Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 17/18] iommu: exynos: init from dt-specific callback instead of initcall Marek Szyprowski
2015-01-23 15:51 ` [PATCH v5 18/18] iommu: exynos: add callback for initializing devices from device tree Marek Szyprowski
2015-02-04 9:53 ` [PATCH v5 00/18] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem Hongbo Zhang
2015-02-04 13:54 ` Marek Szyprowski
2015-02-04 14:21 ` Joerg Roedel
2015-04-17 14:33 ` Javier Martinez Canillas
2015-04-17 14:48 ` Marek Szyprowski [this message]
2015-04-17 16:15 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55311D3C.5050300@samsung.com \
--to=m.szyprowski@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox