From: vigneshr@ti•com (Vignesh R)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v6 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save
Date: Thu, 5 Feb 2015 11:51:25 +0530 [thread overview]
Message-ID: <54D30BE5.4070906@ti.com> (raw)
In-Reply-To: <54BF7C14.1080907@ti.com>
On Wednesday 21 January 2015 03:44 PM, Vignesh R wrote:
> On Tuesday 20 January 2015 09:34 PM, Lee Jones wrote:
>> On Tue, 20 Jan 2015, R, Vignesh wrote:
>>> On 1/20/2015 5:23 PM, Lee Jones wrote:
>>>> On Wed, 07 Jan 2015, Vignesh R wrote:
>>>>
>>>>> In one shot mode, sequencer automatically disables all enabled steps at
>>>>> the end of each cycle. (both ADC steps and TSC steps) Hence these steps
>>>>> need not be saved in reg_se_cache for clearing these steps at a later
>>>>> stage.
>>>>> Also, when ADC wakes up Sequencer should not be busy executing any of the
>>>>> config steps except for the charge step. Previously charge step was 1 ADC
>>>>> clock cycle and hence it was ignored.
>>>>> TSC steps are always disabled at the end of each conversion cycle, hence
>>>>> there is no need to explicitly disable TSC steps by writing 0 to REG_SE.
>>>>>
>>>>> Signed-off-by: Vignesh R <vigneshr@ti•com>
>>>>> ---
>>>>>
>>>>> v5:
>>>>> - Remove unnecessary clearing of REG_SE
>>>>>
>>>>> drivers/mfd/ti_am335x_tscadc.c | 13 +++++--------
>>>>> include/linux/mfd/ti_am335x_tscadc.h | 1 +
>>>>> 2 files changed, 6 insertions(+), 8 deletions(-)
>>>>
>>>> Looks fine.
>>>>
>>>> For my own reference:
>>>> Acked-by: Lee Jones <lee.jones@linaro•org>
>>>>
>>>> Can this patch be applied on its own?
>>>>
>>>
>>> I prefer to wait until input patches are picked up.
>>
>> I have no problem with that, but is there a technical reason why?
>>
>
> Nothing, in particular. This patch alone has no impact on the
> performance of TSC/ADC unit. Patch 2/6 is necessary to observe the
> changes caused by this series. Hence, please wait until those patches
> are picked up.
Input maintainer has applied other patches. You can pick this one.
Regards
Vignesh R
next prev parent reply other threads:[~2015-02-05 6:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 5:49 [PATCH v6 0/6] Touchscreen performance related fixes Vignesh R
2015-01-07 5:49 ` [PATCH v6 1/6] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps Vignesh R
2015-01-07 5:49 ` [PATCH v6 2/6] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler Vignesh R
2015-01-30 5:26 ` Vignesh R
2015-02-03 19:49 ` Dmitry Torokhov
2015-01-07 5:49 ` [PATCH v6 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save Vignesh R
2015-01-20 11:53 ` Lee Jones
2015-01-20 12:40 ` R, Vignesh
2015-01-20 16:04 ` Lee Jones
2015-01-21 10:14 ` Vignesh R
2015-02-05 6:21 ` Vignesh R [this message]
2015-02-25 4:07 ` Vignesh R
2015-02-25 7:17 ` Lee Jones
2015-01-07 5:49 ` [PATCH v6 4/6] input: touchscreen: ti_am335x_tsc: Read charge delay from DT Vignesh R
2015-01-07 5:49 ` [PATCH v6 5/6] ARM: dts: AM335x: Make charge delay a DT parameter for TSC Vignesh R
2015-01-07 5:49 ` [PATCH v6 6/6] input: touchscreen: ti_am335x_tsc: Replace delta filtering with median filtering Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D30BE5.4070906@ti.com \
--to=vigneshr@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox