* [PATCH] [media] s5p-jpeg: Clear JPEG_CODEC_ON bits in sw reset function
@ 2014-12-17 6:22 Tony K Nadackal
2015-01-05 5:11 ` Tony K Nadackal
2015-02-23 15:04 ` Sylwester Nawrocki
0 siblings, 2 replies; 3+ messages in thread
From: Tony K Nadackal @ 2014-12-17 6:22 UTC (permalink / raw)
To: linux-arm-kernel
Bits EXYNOS4_DEC_MODE and EXYNOS4_ENC_MODE do not get cleared
on software reset. These bits need to be cleared explicitly.
Signed-off-by: Tony K Nadackal <tony.kn@samsung•com>
---
This patch is created and tested on top of linux-next-20141210.
It can be cleanly applied on media-next and kgene/for-next.
drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c b/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c
index ab6d6f43..e53f13a 100644
--- a/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c
+++ b/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c
@@ -21,6 +21,10 @@ void exynos4_jpeg_sw_reset(void __iomem *base)
unsigned int reg;
reg = readl(base + EXYNOS4_JPEG_CNTL_REG);
+ writel(reg & ~(EXYNOS4_DEC_MODE | EXYNOS4_ENC_MODE),
+ base + EXYNOS4_JPEG_CNTL_REG);
+
+ reg = readl(base + EXYNOS4_JPEG_CNTL_REG);
writel(reg & ~EXYNOS4_SOFT_RESET_HI, base + EXYNOS4_JPEG_CNTL_REG);
udelay(100);
--
2.2.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] [media] s5p-jpeg: Clear JPEG_CODEC_ON bits in sw reset function
2014-12-17 6:22 [PATCH] [media] s5p-jpeg: Clear JPEG_CODEC_ON bits in sw reset function Tony K Nadackal
@ 2015-01-05 5:11 ` Tony K Nadackal
2015-02-23 15:04 ` Sylwester Nawrocki
1 sibling, 0 replies; 3+ messages in thread
From: Tony K Nadackal @ 2015-01-05 5:11 UTC (permalink / raw)
To: linux-arm-kernel
Gentle Reminder.
Thanks
Tony
> -----Original Message-----
> From: Tony K Nadackal [mailto:tony.kn at samsung.com]
> Sent: Wednesday, December 17, 2014 11:52 AM
> To: linux-media at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-
> samsung-soc at vger.kernel.org
> Cc: mchehab at osg.samsung.com; j.anaszewski at samsung.com;
> kgene at kernel.org; k.debski at samsung.com; s.nawrocki at samsung.com;
> bhushan.r at samsung.com; Tony K Nadackal
> Subject: [PATCH] [media] s5p-jpeg: Clear JPEG_CODEC_ON bits in sw reset
> function
>
> Bits EXYNOS4_DEC_MODE and EXYNOS4_ENC_MODE do not get cleared on
> software reset. These bits need to be cleared explicitly.
>
> Signed-off-by: Tony K Nadackal <tony.kn@samsung•com>
> ---
> This patch is created and tested on top of linux-next-20141210.
> It can be cleanly applied on media-next and kgene/for-next.
>
>
> drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c
> b/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c
> index ab6d6f43..e53f13a 100644
> --- a/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c
> +++ b/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c
> @@ -21,6 +21,10 @@ void exynos4_jpeg_sw_reset(void __iomem *base)
> unsigned int reg;
>
> reg = readl(base + EXYNOS4_JPEG_CNTL_REG);
> + writel(reg & ~(EXYNOS4_DEC_MODE | EXYNOS4_ENC_MODE),
> + base + EXYNOS4_JPEG_CNTL_REG);
> +
> + reg = readl(base + EXYNOS4_JPEG_CNTL_REG);
> writel(reg & ~EXYNOS4_SOFT_RESET_HI, base +
> EXYNOS4_JPEG_CNTL_REG);
>
> udelay(100);
> --
> 2.2.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] [media] s5p-jpeg: Clear JPEG_CODEC_ON bits in sw reset function
2014-12-17 6:22 [PATCH] [media] s5p-jpeg: Clear JPEG_CODEC_ON bits in sw reset function Tony K Nadackal
2015-01-05 5:11 ` Tony K Nadackal
@ 2015-02-23 15:04 ` Sylwester Nawrocki
1 sibling, 0 replies; 3+ messages in thread
From: Sylwester Nawrocki @ 2015-02-23 15:04 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On 17/12/14 07:22, Tony K Nadackal wrote:
> Bits EXYNOS4_DEC_MODE and EXYNOS4_ENC_MODE do not get cleared
> on software reset. These bits need to be cleared explicitly.
>
> Signed-off-by: Tony K Nadackal <tony.kn@samsung•com>
> ---
> This patch is created and tested on top of linux-next-20141210.
> It can be cleanly applied on media-next and kgene/for-next.
>
>
> drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c b/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c
> index ab6d6f43..e53f13a 100644
> --- a/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c
> +++ b/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c
> @@ -21,6 +21,10 @@ void exynos4_jpeg_sw_reset(void __iomem *base)
> unsigned int reg;
>
> reg = readl(base + EXYNOS4_JPEG_CNTL_REG);
> + writel(reg & ~(EXYNOS4_DEC_MODE | EXYNOS4_ENC_MODE),
> + base + EXYNOS4_JPEG_CNTL_REG);
> +
> + reg = readl(base + EXYNOS4_JPEG_CNTL_REG);
Do we really need the second read? Wouldn't it also work as below ?
reg = readl(base + EXYNOS4_JPEG_CNTL_REG);
+ reg &= ~(EXYNOS4_DEC_MODE | EXYNOS4_ENC_MODE);
+ writel(reg, base + EXYNOS4_JPEG_CNTL_REG);
?
> writel(reg & ~EXYNOS4_SOFT_RESET_HI, base + EXYNOS4_JPEG_CNTL_REG);
>
> udelay(100);
--
Thanks,
Sylwester
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-23 15:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-17 6:22 [PATCH] [media] s5p-jpeg: Clear JPEG_CODEC_ON bits in sw reset function Tony K Nadackal
2015-01-05 5:11 ` Tony K Nadackal
2015-02-23 15:04 ` Sylwester Nawrocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox