From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 7/9] ARM: Add Kconfig support for bcm2836.
Date: Thu, 23 Apr 2015 21:30:03 -0600 [thread overview]
Message-ID: <5539B8BB.3090905@wwwdotorg.org> (raw)
In-Reply-To: <87lhhl9pzf.fsf@eliezer.anholt.net>
On 04/21/2015 02:38 PM, Eric Anholt wrote:
> Arnd Bergmann <arnd@arndb•de> writes:
>> On Tuesday 21 April 2015 11:09:54 Eric Anholt wrote:
>>> @@ -116,17 +122,19 @@ config ARCH_BCM283X config ARCH_BCM2835
>>> bool "Broadcom BCM2835 family" if ARCH_MULTI_V6 select
>>> ARCH_BCM283X - select ARCH_REQUIRE_GPIOLIB - select
>>> ARM_AMBA select ARM_ERRATA_411920 select ARM_TIMER_SP804 -
>>> select CLKSRC_OF - select PINCTRL - select
>>> PINCTRL_BCM2835 help This enables support for the Broadcom
>>> BCM2835 SoC. This SoC is used in the Raspberry Pi and Roku 2
>>> devices.
>>>
>>> +config ARCH_BCM2836 + bool "Broadcom BCM2836 family" if
>>> ARCH_MULTI_V7 + select ARCH_BCM283X + help +
>>> This enables support for the Broadcom BCM2836 SoC. This SoC is
>>> + used in the Raspberry Pi 2 +
>>
>> The description for the first one says "Broadcom BCM2835 family",
>> and I guess they are both in the same family. How about leaving
>> the CONFIG_BCM2835 symbol to mean one of them, and just
>> duplicating the DEBUG_LL symbols?
>>
>> You could do something like
>>
>> config ARCH_BCM2835 bool "Broadcom BCM2835 family" if
>> ARCH_MULTI_V6 || ARCH_MULTI_V7 select ARCH_BCM283X select
>> ARCH_REQUIRE_GPIOLIB select ARM_AMBA select ARM_ERRATA_411920 if
>> ARCH_MULTI_V6 select ARM_TIMER_SP804 if ARCH_MULTI_V6 select
>> CLKSRC_OF select PINCTRL select PINCTRL_BCM2835 help This enables
>> support for the Broadcom BCM2835 and BCM2836 SoCs. These SoCs is
>> used in the Raspberry Pi and Roku 2 devices.
>>
>> That should make it less confusing to the user, because they
>> don't have to know which specific SoC they are building for,
>> other than enabling the right architecture level.
>
> Seems reasonable to me. What do the 2835 maintainers think?
Yes, sounds reasonable to me.
next prev parent reply other threads:[~2015-04-24 3:30 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 18:09 BCM2836 (Raspberry Pi 2) port Eric Anholt
2015-04-21 18:09 ` [PATCH 1/9] dt-bindings: Add root properties for Raspberry Pi 2 Eric Anholt
2015-04-24 4:27 ` Stephen Warren
2015-04-21 18:09 ` [PATCH 2/9] ARM: BCM2835: Split peripheral definitions off to a common include Eric Anholt
2015-04-24 4:28 ` Stephen Warren
2015-04-21 18:09 ` [PATCH 3/9] ARM: Make a copy of the 2835 dts for the 2836 Eric Anholt
2015-04-24 4:35 ` Stephen Warren
2015-04-21 18:09 ` [PATCH 4/9] ARM: Update the device trees for 2836 Eric Anholt
2015-04-24 4:36 ` Stephen Warren
2015-04-21 18:09 ` [PATCH 5/9] ARM: BCM2836: Add io map initialization for bcm2836 Eric Anholt
2015-04-21 18:53 ` Arnd Bergmann
2015-04-21 20:37 ` Eric Anholt
2015-04-21 21:11 ` Arnd Bergmann
2015-04-21 23:02 ` Eric Anholt
2015-04-22 7:22 ` Arnd Bergmann
2015-04-24 7:16 ` Arnd Bergmann
2015-04-21 18:09 ` [PATCH 6/9] ARM: Make a Kconfig option for shared BCM2835/BCM2836 code Eric Anholt
2015-04-21 18:09 ` [PATCH 7/9] ARM: Add Kconfig support for bcm2836 Eric Anholt
2015-04-21 18:59 ` Arnd Bergmann
2015-04-21 20:38 ` Eric Anholt
2015-04-24 3:30 ` Stephen Warren [this message]
2015-04-21 18:09 ` [PATCH 8/9] ARM: Add MAINTAINERS for 2836 Eric Anholt
2015-04-24 4:38 ` Stephen Warren
2015-04-24 17:03 ` Eric Anholt
2015-04-21 18:09 ` [PATCH 9/9] ARM: BCM283x: Register fixed clocks for uart in the DT Eric Anholt
2015-04-24 4:44 ` Stephen Warren
2015-04-24 17:06 ` Eric Anholt
2015-04-25 4:23 ` Stephen Warren
2015-04-24 4:25 ` BCM2836 (Raspberry Pi 2) port Stephen Warren
2015-04-24 18:41 ` Eric Anholt
2015-04-24 18:57 ` Stephen Warren
2015-04-27 17:19 ` Eric Anholt
2015-05-08 16:14 ` Alexander Stein
2015-05-12 2:36 ` Stephen Warren
2015-05-12 15:39 ` Alexander Stein
2015-05-12 16:03 ` Stephen Warren
2015-05-12 17:32 ` Eric Anholt
2015-05-12 22:03 ` Stephen Warren
2015-05-13 17:46 ` Eric Anholt
2015-05-13 18:32 ` Stephen Warren
2015-05-13 18:59 ` Eric Anholt
2015-04-29 2:38 ` Stephen Warren
2015-04-29 3:41 ` Florian Fainelli
2015-05-06 18:51 ` Eric Anholt
2015-05-06 19:05 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5539B8BB.3090905@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox