From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 9/9] ARM: BCM283x: Register fixed clocks for uart in the DT.
Date: Fri, 24 Apr 2015 22:23:57 -0600 [thread overview]
Message-ID: <553B16DD.9090507@wwwdotorg.org> (raw)
In-Reply-To: <87vbglwj5c.fsf@eliezer.anholt.net>
On 04/24/2015 11:06 AM, Eric Anholt wrote:
> Stephen Warren <swarren@wwwdotorg•org> writes:
>
>> On 04/21/2015 12:09 PM, Eric Anholt wrote:
>>> We were previously relying on the fixed clock registration in
>>> clk-bcm2835, but there doesn't seem to be any real reason to
>>> not just define it in the DT (and for the 2836 port, I would
>>> have needed to change the clock's physical address in
>>> clk-bcm2835.c). Also, because we weren't registering the
>>> apb_pclk in clk-bcm2835 as a clock device, we were picking up
>>> the uart clock node as apb_pclk by accident.
>>
>> Doesn't the following do just that?
>>
>> clk = clk_register_fixed_rate(NULL, "apb_pclk", NULL,
>> CLK_IS_ROOT, 126000000);
>
> Nope! You also need the clk_register_clkdev for the type of
> lookup being done by APB to find it.
Oh right, that just creates a clock object without registering it in
the lookup table?
>> Anyway, with this patch, shouldn't we fix
>> drivers/clk/clk-bcm2835.c not to register clocks that match those
>> that are added to DT in this patch? Actually, to maintain DT ABI
>> (new kernels working with old or new DT), we probably need to
>> keep the code in clk-bcm2835.c, but make it conditional upon
>> whether there's a clock node in the DT file.
>
> Yeah, I hadn't modified the .c code because of DT ABI
Should the C file be modified not the create those clock objects if
the DT contains them?
next prev parent reply other threads:[~2015-04-25 4:23 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 18:09 BCM2836 (Raspberry Pi 2) port Eric Anholt
2015-04-21 18:09 ` [PATCH 1/9] dt-bindings: Add root properties for Raspberry Pi 2 Eric Anholt
2015-04-24 4:27 ` Stephen Warren
2015-04-21 18:09 ` [PATCH 2/9] ARM: BCM2835: Split peripheral definitions off to a common include Eric Anholt
2015-04-24 4:28 ` Stephen Warren
2015-04-21 18:09 ` [PATCH 3/9] ARM: Make a copy of the 2835 dts for the 2836 Eric Anholt
2015-04-24 4:35 ` Stephen Warren
2015-04-21 18:09 ` [PATCH 4/9] ARM: Update the device trees for 2836 Eric Anholt
2015-04-24 4:36 ` Stephen Warren
2015-04-21 18:09 ` [PATCH 5/9] ARM: BCM2836: Add io map initialization for bcm2836 Eric Anholt
2015-04-21 18:53 ` Arnd Bergmann
2015-04-21 20:37 ` Eric Anholt
2015-04-21 21:11 ` Arnd Bergmann
2015-04-21 23:02 ` Eric Anholt
2015-04-22 7:22 ` Arnd Bergmann
2015-04-24 7:16 ` Arnd Bergmann
2015-04-21 18:09 ` [PATCH 6/9] ARM: Make a Kconfig option for shared BCM2835/BCM2836 code Eric Anholt
2015-04-21 18:09 ` [PATCH 7/9] ARM: Add Kconfig support for bcm2836 Eric Anholt
2015-04-21 18:59 ` Arnd Bergmann
2015-04-21 20:38 ` Eric Anholt
2015-04-24 3:30 ` Stephen Warren
2015-04-21 18:09 ` [PATCH 8/9] ARM: Add MAINTAINERS for 2836 Eric Anholt
2015-04-24 4:38 ` Stephen Warren
2015-04-24 17:03 ` Eric Anholt
2015-04-21 18:09 ` [PATCH 9/9] ARM: BCM283x: Register fixed clocks for uart in the DT Eric Anholt
2015-04-24 4:44 ` Stephen Warren
2015-04-24 17:06 ` Eric Anholt
2015-04-25 4:23 ` Stephen Warren [this message]
2015-04-24 4:25 ` BCM2836 (Raspberry Pi 2) port Stephen Warren
2015-04-24 18:41 ` Eric Anholt
2015-04-24 18:57 ` Stephen Warren
2015-04-27 17:19 ` Eric Anholt
2015-05-08 16:14 ` Alexander Stein
2015-05-12 2:36 ` Stephen Warren
2015-05-12 15:39 ` Alexander Stein
2015-05-12 16:03 ` Stephen Warren
2015-05-12 17:32 ` Eric Anholt
2015-05-12 22:03 ` Stephen Warren
2015-05-13 17:46 ` Eric Anholt
2015-05-13 18:32 ` Stephen Warren
2015-05-13 18:59 ` Eric Anholt
2015-04-29 2:38 ` Stephen Warren
2015-04-29 3:41 ` Florian Fainelli
2015-05-06 18:51 ` Eric Anholt
2015-05-06 19:05 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553B16DD.9090507@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox