From: javier@osg•samsung.com (Javier Martinez Canillas)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 4/4] mfd: max77686: Split out regulator part from the DT binding
Date: Fri, 17 Jul 2015 09:26:40 +0200 [thread overview]
Message-ID: <55A8AE30.6040908@osg.samsung.com> (raw)
In-Reply-To: <CAJKOXPdTKP21eO0dcD_Ec0YA8H5Jhy2YAFjS8hnQLgVe5cCNrA@mail.gmail.com>
Hello Krzysztof,
On 07/17/2015 09:11 AM, Krzysztof Kozlowski wrote:
> 2015-07-17 15:59 GMT+09:00 Javier Martinez Canillas <javier@osg•samsung.com>:
>> Hello Krzysztof,
>>
>> On 07/17/2015 08:49 AM, Krzysztof Kozlowski wrote:
>>> 2015-07-17 15:46 GMT+09:00 Javier Martinez Canillas <javier@osg•samsung.com>:
>>>> Hello Krzysztof,
>>>>
>>>> On 07/17/2015 08:42 AM, Krzysztof Kozlowski wrote:
>>>>> 2015-07-17 15:29 GMT+09:00 Javier Martinez Canillas <javier@osg•samsung.com>:
>>>>>> The Maxim MAX77686 PMIC is a multi-function device with regulators,
>>>>>> clocks and a RTC. The DT bindings for the clocks are in a separate
>>>>>> file but the bindings for the regulators are inside the mfd part.
>>>>>>
>>>>>> To make it consistent with the clocks portion of the binding and
>>>>>> because is more natural to look for regulator bindings under the
>>>>>> bindings/regulator sub-directory, split the regulator portion of
>>>>>> the DT binding and add it as a separate file.
>>>>>>
>>>>>> Signed-off-by: Javier Martinez Canillas <javier@osg•samsung.com>
>>>>>>
>>>>>> ---
>>>>>>
>>>>>> Changes in v2:
>>>>>> - Use a generic name for the max77686 node in the regulator example.
>>>>>>
>>>>>> Documentation/devicetree/bindings/mfd/max77686.txt | 58 +-----------------
>>>>>> .../devicetree/bindings/regulator/max77686.txt | 71 ++++++++++++++++++++++
>>>>>> 2 files changed, 74 insertions(+), 55 deletions(-)
>>>>>> create mode 100644 Documentation/devicetree/bindings/regulator/max77686.txt
>>>>>
>>>>> Putting regulator bindings under regulator directory seems logical so
>>>>> I am fine with it.
>>>>>
>>>>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung•com>
>>>>>
>>>>
>>>> Thanks a lot for your review. For completeness, I talked with Lee Jones
>>>> over IRC yesterday asking him his opinion on whether MFD DT binding doc
>>>> should contain all the info or if it should be split across different
>>>> subsystems and he prefers the later. That's why I re-spun this series.
>>>
>>> Okay, this sounds good.
>>>
>>> One more thing - can you update the maintainers file? The bindings
>>> documentation is mentioned there for max77686.
>>>
>>
>> Sure, I see that also the max77802 files are missing in that section.
>> I'll included that as well.
>
> The max717802 are not there because they are not part of this
> maintainership :) . I wasn't involved in development of them (except
> reviewing) so I did not put myself as their maintainer.
>
Fair enough, I guess I should add an entry for max77802 then and
volunteer myself as maintainer since after all I added the driver.
>> But I'll wait to see if Lee pick this
>> series before posting the patch for MAINTAINERS.
>
> I think the maintainers should be updated in the same patchset (or
> even patch) to keep the state consistent.
>
Ok, I'll post a patch then to be applied on top of this series. I
could re-spin the whole series and add it to $subject but I'm not
sure if is worth it since it's only documentation and I prefer to
avoid spaming Lee and Mark with yet another revision.
> Best regards,
> Krzysztof
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2015-07-17 7:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 6:29 [PATCH v2 0/4] mfd: Improve DT binding docs for max77686 and max77802 Javier Martinez Canillas
2015-07-17 6:29 ` [PATCH v2 1/4] mfd: max77686: Don't suggest in binding to use a deprecated property Javier Martinez Canillas
2015-07-20 8:10 ` Lee Jones
2015-07-20 10:12 ` Javier Martinez Canillas
2015-07-27 10:28 ` Javier Martinez Canillas
2015-07-27 10:33 ` Mark Brown
2015-07-27 10:40 ` Javier Martinez Canillas
2015-07-17 6:29 ` [PATCH v2 2/4] mfd: max77686: Use a generic name for the PMIC node in the example Javier Martinez Canillas
2015-07-17 9:11 ` Sergei Shtylyov
2015-07-17 9:19 ` Javier Martinez Canillas
2015-07-17 6:29 ` [PATCH v2 3/4] mfd: Add DT binding for Maxim MAX77802 IC Javier Martinez Canillas
2015-07-17 6:36 ` Krzysztof Kozlowski
2015-07-23 15:16 ` Lee Jones
2015-07-23 16:09 ` Javier Martinez Canillas
2015-07-17 6:29 ` [PATCH v2 4/4] mfd: max77686: Split out regulator part from the DT binding Javier Martinez Canillas
2015-07-17 6:42 ` Krzysztof Kozlowski
2015-07-17 6:46 ` Javier Martinez Canillas
2015-07-17 6:49 ` Krzysztof Kozlowski
2015-07-17 6:59 ` Javier Martinez Canillas
2015-07-17 7:11 ` Krzysztof Kozlowski
2015-07-17 7:26 ` Javier Martinez Canillas [this message]
2015-07-20 8:08 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A8AE30.6040908@osg.samsung.com \
--to=javier@osg$(echo .)samsung.com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox