From: javier@osg•samsung.com (Javier Martinez Canillas)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/4] mfd: max77686: Don't suggest in binding to use a deprecated property
Date: Mon, 20 Jul 2015 12:12:22 +0200 [thread overview]
Message-ID: <55ACC986.5040408@osg.samsung.com> (raw)
In-Reply-To: <20150720081020.GD3061@x1>
Hello Lee,
Thanks a lot for your feedback.
On 07/20/2015 10:10 AM, Lee Jones wrote:
> On Fri, 17 Jul 2015, Javier Martinez Canillas wrote:
>
>> The regulator-compatible property from the regulator DT binding was
>> deprecated. But the max77686 DT binding doc still suggest to use it
>> instead of the regulator node name's which is the correct approach.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg•samsung.com>
>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung•com>
>
> By convention shouldn't this be buck at 1, or something?
>
> Need Mark to look at this.
>
That's a very good question, the ePAPR doc says:
"The unit-address must match the first address specified in the reg property
of the node. If the node has no reg property, the @ and unit-address must be
omitted and the node-name alone differentiates the node from other nodes at
the same level in the tree"
This PMIC uses a single I2C address for all the regulators and these are
controlled by writing to different I2C register addresses. So the regulator
nodes don't have a reg property in this case.
By looking at other regulators bindings, besides the generic regulator.txt
and fixed-regulator.txt DT bindings, there are only 5 (out of 40) that use
the node-name at unit-address convention mentioned in the ePAPR document.
AFAICT all these are for regulators that are actually in different addresses
but I could be wrong so let's see what Mark says.
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2015-07-20 10:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 6:29 [PATCH v2 0/4] mfd: Improve DT binding docs for max77686 and max77802 Javier Martinez Canillas
2015-07-17 6:29 ` [PATCH v2 1/4] mfd: max77686: Don't suggest in binding to use a deprecated property Javier Martinez Canillas
2015-07-20 8:10 ` Lee Jones
2015-07-20 10:12 ` Javier Martinez Canillas [this message]
2015-07-27 10:28 ` Javier Martinez Canillas
2015-07-27 10:33 ` Mark Brown
2015-07-27 10:40 ` Javier Martinez Canillas
2015-07-17 6:29 ` [PATCH v2 2/4] mfd: max77686: Use a generic name for the PMIC node in the example Javier Martinez Canillas
2015-07-17 9:11 ` Sergei Shtylyov
2015-07-17 9:19 ` Javier Martinez Canillas
2015-07-17 6:29 ` [PATCH v2 3/4] mfd: Add DT binding for Maxim MAX77802 IC Javier Martinez Canillas
2015-07-17 6:36 ` Krzysztof Kozlowski
2015-07-23 15:16 ` Lee Jones
2015-07-23 16:09 ` Javier Martinez Canillas
2015-07-17 6:29 ` [PATCH v2 4/4] mfd: max77686: Split out regulator part from the DT binding Javier Martinez Canillas
2015-07-17 6:42 ` Krzysztof Kozlowski
2015-07-17 6:46 ` Javier Martinez Canillas
2015-07-17 6:49 ` Krzysztof Kozlowski
2015-07-17 6:59 ` Javier Martinez Canillas
2015-07-17 7:11 ` Krzysztof Kozlowski
2015-07-17 7:26 ` Javier Martinez Canillas
2015-07-20 8:08 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ACC986.5040408@osg.samsung.com \
--to=javier@osg$(echo .)samsung.com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox