From: songjun.wu@atmel•com (Wu, Songjun)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier code
Date: Wed, 9 Sep 2015 11:16:08 +0800 [thread overview]
Message-ID: <55EFA478.1000109@atmel.com> (raw)
In-Reply-To: <20150908122322.GB9751@sirena.org.uk>
On 9/8/2015 20:23, Mark Brown wrote:
> On Tue, Sep 08, 2015 at 05:36:01PM +0800, Wu, Songjun wrote:
>> On 9/8/2015 00:23, Mark Brown wrote:
>
>>> OK, so that's not actually what the code was doing - it had separate
>>> enums for bass, mid and treble. If you make this a single enum with all
>>> the above options in it that seems like the best way of handling things.
>
>> A single enum seems not very friendly to user, there are tree EQs, bass,
>> medium and treble.
>> So I create tree enum controls to control three EQs.
>> The 'get' function is replaced by 'classd_get_eq_enum', if user operates one
>> of the tree EQ controls, the other two EQs will show 0 dB.
>
> If you want to have three controls you need to write code so that the
> user can only change one of them from 0dB at once, returning an error
> otherwise. That was why it looked like they were three separate
> controls.
>
If user operates two or tree controls at the same time, for my
understanding, these operations are serial actually in kernel, not
parallel, and the last operation will be effective. I only write the
function 'classd_get_eq_enum' to get the enumeration value, if user
changes one of controls, the other controls will get 0dB. Is my
understanding correct?
next prev parent reply other threads:[~2015-09-09 3:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1441086101-15303-1-git-send-email-songjun.wu@atmel.com>
[not found] ` <1441086101-15303-2-git-send-email-songjun.wu@atmel.com>
[not found] ` <20150903113716.GU12027@sirena.org.uk>
[not found] ` <55EC0AF5.8060403@atmel.com>
[not found] ` <20150907162350.GV5313@sirena.org.uk>
2015-09-08 9:36 ` [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier code Wu, Songjun
2015-09-08 12:23 ` Mark Brown
2015-09-09 3:16 ` Wu, Songjun [this message]
2015-09-09 9:52 ` Mark Brown
2015-09-10 2:31 ` Wu, Songjun
2015-09-11 10:34 ` Mark Brown
2015-09-14 6:34 ` Wu, Songjun
[not found] ` <1441086101-15303-3-git-send-email-songjun.wu@atmel.com>
[not found] ` <20150903114316.GV12027@sirena.org.uk>
[not found] ` <55EC0AFE.3080809@atmel.com>
[not found] ` <20150907162548.GW5313@sirena.org.uk>
2015-09-08 9:36 ` [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver Wu, Songjun
2015-09-08 12:23 ` Mark Brown
2015-09-09 3:16 ` Wu, Songjun
2015-09-15 3:11 ` Wu, Songjun
2015-09-16 19:42 ` Mark Brown
2015-09-17 3:07 ` Wu, Songjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EFA478.1000109@atmel.com \
--to=songjun.wu@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox