From: songjun.wu@atmel•com (Wu, Songjun)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier code
Date: Mon, 14 Sep 2015 14:34:02 +0800 [thread overview]
Message-ID: <55F66A5A.7010502@atmel.com> (raw)
In-Reply-To: <20150911103417.GF12027@sirena.org.uk>
On 9/11/2015 18:34, Mark Brown wrote:
> On Thu, Sep 10, 2015 at 10:31:04AM +0800, Wu, Songjun wrote:
>> On 9/9/2015 17:52, Mark Brown wrote:
>
>>> Yes, that's what's going to end up happening but it's not how controls
>>> are expected to behave - applications will expect changing one control
>>> to leave others unaffected so it's better to return an error rather than
>>> change the other control.
>
>> If application change non EQ controls, the others will be unaffected. But
>> the classD IP can only supports one EQ control at once, these three EQ
>> controls point to the same register field, if application set a different EQ
>> control, the error occurs, there will be many errors, it's not very
>> reasonable to application. The best way I think is if application set one EQ
>> control, the other EQ controls will change to 0dB, it's also consistent with
>> fact.
>
> There's no really good solutions here - this is why my initial
> suggestion was to have a single enumerated control.
>
You are right, your suggestion is reasonable, to have a single
enumerated control. The second version will be made and sent soon.
next prev parent reply other threads:[~2015-09-14 6:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1441086101-15303-1-git-send-email-songjun.wu@atmel.com>
[not found] ` <1441086101-15303-2-git-send-email-songjun.wu@atmel.com>
[not found] ` <20150903113716.GU12027@sirena.org.uk>
[not found] ` <55EC0AF5.8060403@atmel.com>
[not found] ` <20150907162350.GV5313@sirena.org.uk>
2015-09-08 9:36 ` [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier code Wu, Songjun
2015-09-08 12:23 ` Mark Brown
2015-09-09 3:16 ` Wu, Songjun
2015-09-09 9:52 ` Mark Brown
2015-09-10 2:31 ` Wu, Songjun
2015-09-11 10:34 ` Mark Brown
2015-09-14 6:34 ` Wu, Songjun [this message]
[not found] ` <1441086101-15303-3-git-send-email-songjun.wu@atmel.com>
[not found] ` <20150903114316.GV12027@sirena.org.uk>
[not found] ` <55EC0AFE.3080809@atmel.com>
[not found] ` <20150907162548.GW5313@sirena.org.uk>
2015-09-08 9:36 ` [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver Wu, Songjun
2015-09-08 12:23 ` Mark Brown
2015-09-09 3:16 ` Wu, Songjun
2015-09-15 3:11 ` Wu, Songjun
2015-09-16 19:42 ` Mark Brown
2015-09-17 3:07 ` Wu, Songjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F66A5A.7010502@atmel.com \
--to=songjun.wu@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox