From: j.anaszewski@samsung•com (Jacek Anaszewski)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v6 5/5] leds: netxbig: set led_classdev max_brightness
Date: Mon, 28 Sep 2015 10:02:35 +0200 [thread overview]
Message-ID: <5608F41B.4020307@samsung.com> (raw)
In-Reply-To: <1443301358-2131-6-git-send-email-simon.guinot@sequanux.org>
Hi Simon,
Does your device support reading the brightness currently set?
If so, it would be good to implement brightness_get op, because
AFAIR you mentioned that the firmware you are working with sets
always maximum brightness value. Having the op implemented would
allow to find this out.
On 09/26/2015 11:02 PM, Simon Guinot wrote:
> This patch sets the led_classdev max_brightness to the maximum level
> value supported by hardware. This allows to get rid of the brightness
> conversion operation (from software [0:LED_FULL] to hardware ranges) in
> brightness_set().
>
> Signed-off-by: Simon Guinot <simon.guinot@sequanux•org>
> ---
> drivers/leds/leds-netxbig.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/leds/leds-netxbig.c b/drivers/leds/leds-netxbig.c
> index b166fd9f4186..4b88b93244be 100644
> --- a/drivers/leds/leds-netxbig.c
> +++ b/drivers/leds/leds-netxbig.c
> @@ -116,7 +116,6 @@ struct netxbig_led_data {
> int mode_addr;
> int *mode_val;
> int bright_addr;
> - int bright_max;
> struct netxbig_led_timer *timer;
> int num_timer;
> enum netxbig_led_mode mode;
> @@ -178,7 +177,7 @@ static void netxbig_led_set(struct led_classdev *led_cdev,
> struct netxbig_led_data *led_dat =
> container_of(led_cdev, struct netxbig_led_data, cdev);
> enum netxbig_led_mode mode;
> - int mode_val, bright_val;
> + int mode_val;
> int set_brightness = 1;
> unsigned long flags;
>
> @@ -204,12 +203,9 @@ static void netxbig_led_set(struct led_classdev *led_cdev,
> * SATA LEDs. So, change the brightness setting for a single
> * SATA LED will affect all the others.
> */
> - if (set_brightness) {
> - bright_val = DIV_ROUND_UP(value * led_dat->bright_max,
> - LED_FULL);
> + if (set_brightness)
> gpio_ext_set_value(led_dat->gpio_ext,
> - led_dat->bright_addr, bright_val);
> - }
> + led_dat->bright_addr, value);
>
> spin_unlock_irqrestore(&led_dat->lock, flags);
> }
> @@ -306,11 +302,11 @@ static int create_netxbig_led(struct platform_device *pdev,
> */
> led_dat->sata = 0;
> led_dat->cdev.brightness = LED_OFF;
> + led_dat->cdev.max_brightness = template->bright_max;
> led_dat->cdev.flags |= LED_CORE_SUSPENDRESUME;
> led_dat->mode_addr = template->mode_addr;
> led_dat->mode_val = template->mode_val;
> led_dat->bright_addr = template->bright_addr;
> - led_dat->bright_max = template->bright_max;
> led_dat->timer = pdata->timer;
> led_dat->num_timer = pdata->num_timer;
> /*
>
--
Best Regards,
Jacek Anaszewski
next prev parent reply other threads:[~2015-09-28 8:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-26 21:02 [PATCH v6 0/5] Add DT support for netxbig LEDs Simon Guinot
2015-09-26 21:02 ` [PATCH v6 1/5] leds: netxbig: add device tree binding Simon Guinot
2015-09-26 21:02 ` [PATCH v6 2/5] ARM: Kirkwood: add LED DT entries for netxbig boards Simon Guinot
2015-09-26 21:02 ` [PATCH v6 3/5] ARM: mvebu: remove static LED setup " Simon Guinot
2015-09-26 21:02 ` [PATCH v6 4/5] leds: netxbig: convert to use the devm_ functions Simon Guinot
2015-09-26 21:02 ` [PATCH v6 5/5] leds: netxbig: set led_classdev max_brightness Simon Guinot
2015-09-28 8:02 ` Jacek Anaszewski [this message]
2015-09-28 9:19 ` Simon Guinot
2015-09-28 10:15 ` Jacek Anaszewski
2015-09-28 11:50 ` Simon Guinot
2015-09-28 12:24 ` Jacek Anaszewski
2015-09-28 13:25 ` Simon Guinot
2015-09-28 13:43 ` Jacek Anaszewski
2015-10-09 9:43 ` [PATCH v6 0/5] Add DT support for netxbig LEDs Jacek Anaszewski
2015-10-15 7:16 ` Gregory CLEMENT
2015-10-15 8:11 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5608F41B.4020307@samsung.com \
--to=j.anaszewski@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox