From: j.anaszewski@samsung•com (Jacek Anaszewski)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v6 0/5] Add DT support for netxbig LEDs
Date: Fri, 09 Oct 2015 11:43:37 +0200 [thread overview]
Message-ID: <56178C49.4070704@samsung.com> (raw)
In-Reply-To: <1443301358-2131-1-git-send-email-simon.guinot@sequanux.org>
On 09/26/2015 11:02 PM, Simon Guinot wrote:
> Hello,
>
> This patch series adds DT support for the LEDs found on the
> Kirkwood-based LaCie boards 2Big and 5Big Network v2.
>
> Changes for v2:
> - Check timer mode value retrieved from DT.
> - In netxbig_leds_get_of_pdata, don't use unsigned long variables to get
> timer delay values from DT with function of_property_read_u32_index.
> Instead, use a temporary u32 variable. This allows to silence a static
> checker warning.
> - Make timer property optional in the binding documentation. It is now
> aligned with the driver code.
>
> Changes for v3:
> - Fix pointer usage with the temporary u32 variable while calling
> of_property_read_u32_index.
>
> Changes for v4:
> - In DT binding document netxbig-gpio-ext.txt, detail byte order for
> registers and latch mechanism for "enable-gpio".
> - In leds-netxbig.c, add some error messages.
> - In leds-netxbig.c, fix some "sizeof" style issues.
> - In leds-netxbig.c, in netxbig_leds_get_of_pdata(), move the
> of_property_read_string() calls after the error-prone checks.
> - Add some Acked-by.
>
> Changes for v5:
> - Rename DT property "bright-max" into the more common "max-brightness".
> - Make use of the "max-brightness" DT property. Instead of counting the
> data pins of the GPIO extension bus, use "max-brightness" to get the
> maximum brightness level.
> - Add a patch to convert the leds-netxbig driver to the devm_ functions.
>
> Changes for v6:
> - Add a patch to set led_classdev max_brightness in the leds-netxbig
> driver.
> - Decrement the current child node refcount with of_node_put() when an
> error happens while iterating with for_each_child_of_node().
>
> Thanks,
>
> Simon
>
> Simon Guinot (5):
> leds: netxbig: add device tree binding
> ARM: Kirkwood: add LED DT entries for netxbig boards
> ARM: mvebu: remove static LED setup for netxbig boards
> leds: netxbig: convert to use the devm_ functions
> leds: netxbig: set led_classdev max_brightness
>
> .../devicetree/bindings/gpio/netxbig-gpio-ext.txt | 22 ++
> .../devicetree/bindings/leds/leds-netxbig.txt | 92 ++++++
> arch/arm/boot/dts/kirkwood-net5big.dts | 60 ++++
> arch/arm/boot/dts/kirkwood-netxbig.dtsi | 80 +++++
> arch/arm/mach-mvebu/Kconfig | 7 -
> arch/arm/mach-mvebu/Makefile | 1 -
> arch/arm/mach-mvebu/board.h | 21 --
> arch/arm/mach-mvebu/kirkwood.c | 4 -
> arch/arm/mach-mvebu/netxbig.c | 191 ------------
> drivers/leds/leds-netxbig.c | 336 ++++++++++++++++-----
> include/dt-bindings/leds/leds-netxbig.h | 18 ++
> .../linux/platform_data/leds-kirkwood-netxbig.h | 1 +
> 12 files changed, 531 insertions(+), 302 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/gpio/netxbig-gpio-ext.txt
> create mode 100644 Documentation/devicetree/bindings/leds/leds-netxbig.txt
> delete mode 100644 arch/arm/mach-mvebu/board.h
> delete mode 100644 arch/arm/mach-mvebu/netxbig.c
> create mode 100644 include/dt-bindings/leds/leds-netxbig.h
>
Since no comment regarding DT bindings has appeared for a long time,
I decided to merge the patch set without DT maintainer's ack, thanks.
--
Best Regards,
Jacek Anaszewski
next prev parent reply other threads:[~2015-10-09 9:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-26 21:02 [PATCH v6 0/5] Add DT support for netxbig LEDs Simon Guinot
2015-09-26 21:02 ` [PATCH v6 1/5] leds: netxbig: add device tree binding Simon Guinot
2015-09-26 21:02 ` [PATCH v6 2/5] ARM: Kirkwood: add LED DT entries for netxbig boards Simon Guinot
2015-09-26 21:02 ` [PATCH v6 3/5] ARM: mvebu: remove static LED setup " Simon Guinot
2015-09-26 21:02 ` [PATCH v6 4/5] leds: netxbig: convert to use the devm_ functions Simon Guinot
2015-09-26 21:02 ` [PATCH v6 5/5] leds: netxbig: set led_classdev max_brightness Simon Guinot
2015-09-28 8:02 ` Jacek Anaszewski
2015-09-28 9:19 ` Simon Guinot
2015-09-28 10:15 ` Jacek Anaszewski
2015-09-28 11:50 ` Simon Guinot
2015-09-28 12:24 ` Jacek Anaszewski
2015-09-28 13:25 ` Simon Guinot
2015-09-28 13:43 ` Jacek Anaszewski
2015-10-09 9:43 ` Jacek Anaszewski [this message]
2015-10-15 7:16 ` [PATCH v6 0/5] Add DT support for netxbig LEDs Gregory CLEMENT
2015-10-15 8:11 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56178C49.4070704@samsung.com \
--to=j.anaszewski@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox