From: Nathan_Lynch@mentor•com (Nathan Lynch)
To: linux-arm-kernel@lists•infradead.org
Subject: typo in recent linux commit?
Date: Wed, 28 Oct 2015 07:51:05 -0500 [thread overview]
Message-ID: <5630C4B9.7080404@mentor.com> (raw)
In-Reply-To: <30294E2E-4011-4B50-BD26-787977A3F3BB@goldelico.com>
On 10/28/2015 03:41 AM, H.Nikolaus Schaller wrote:
> Hi,
>
> Am 28.10.2015 um 09:19 schrieb Efraim Yawitz <efraim.yawitz@gmail•com>:
>
>> Hi,
>>
>> I was just browsing recent commits to the linux kernel tree, and I saw this in a change to arch/arm/vdso/vdsomunge.c:
>>
>> +#define swab32(x) \
>> + ((((x) & 0x000000ff) << 24) | \
>> + (((x) & 0x0000ff00) << 8) | \
>> + (((x) & 0x00ff0000) >> 8) | \
>> + (((x) & 0xff000000) << 24))
>>
>>
>> Shouldn't that last '<<' be a '>>'?
>>
>> Ephraim Yawitz
>
> Yes, you are right! Thanks for spotting this.
> It appears that it was introduced during code simplification.
>
> @maintainers: should I write another patch or can you more easily replace the original one?
As the regression is already in Linus' tree, it needs an incremental
patch. Please also credit Ephraim with a Reported-by: .
Thanks.
prev parent reply other threads:[~2015-10-28 12:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAPKXbB6Y9esdQm-VevEfhTggA30vmFY424mwiTK9wZR=wORRHg@mail.gmail.com>
2015-10-28 8:41 ` typo in recent linux commit? H. Nikolaus Schaller
2015-10-28 12:51 ` Nathan Lynch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5630C4B9.7080404@mentor.com \
--to=nathan_lynch@mentor$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox