* typo in recent linux commit?
[not found] <CAPKXbB6Y9esdQm-VevEfhTggA30vmFY424mwiTK9wZR=wORRHg@mail.gmail.com>
@ 2015-10-28 8:41 ` H. Nikolaus Schaller
2015-10-28 12:51 ` Nathan Lynch
0 siblings, 1 reply; 2+ messages in thread
From: H. Nikolaus Schaller @ 2015-10-28 8:41 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
Am 28.10.2015 um 09:19 schrieb Efraim Yawitz <efraim.yawitz@gmail•com>:
> Hi,
>
> I was just browsing recent commits to the linux kernel tree, and I saw this in a change to arch/arm/vdso/vdsomunge.c:
>
> +#define swab32(x) \
> + ((((x) & 0x000000ff) << 24) | \
> + (((x) & 0x0000ff00) << 8) | \
> + (((x) & 0x00ff0000) >> 8) | \
> + (((x) & 0xff000000) << 24))
>
>
> Shouldn't that last '<<' be a '>>'?
>
> Ephraim Yawitz
Yes, you are right! Thanks for spotting this.
It appears that it was introduced during code simplification.
@maintainers: should I write another patch or can you more easily replace the original one?
BR,
Nikolaus Schaller
^ permalink raw reply [flat|nested] 2+ messages in thread* typo in recent linux commit?
2015-10-28 8:41 ` typo in recent linux commit? H. Nikolaus Schaller
@ 2015-10-28 12:51 ` Nathan Lynch
0 siblings, 0 replies; 2+ messages in thread
From: Nathan Lynch @ 2015-10-28 12:51 UTC (permalink / raw)
To: linux-arm-kernel
On 10/28/2015 03:41 AM, H.Nikolaus Schaller wrote:
> Hi,
>
> Am 28.10.2015 um 09:19 schrieb Efraim Yawitz <efraim.yawitz@gmail•com>:
>
>> Hi,
>>
>> I was just browsing recent commits to the linux kernel tree, and I saw this in a change to arch/arm/vdso/vdsomunge.c:
>>
>> +#define swab32(x) \
>> + ((((x) & 0x000000ff) << 24) | \
>> + (((x) & 0x0000ff00) << 8) | \
>> + (((x) & 0x00ff0000) >> 8) | \
>> + (((x) & 0xff000000) << 24))
>>
>>
>> Shouldn't that last '<<' be a '>>'?
>>
>> Ephraim Yawitz
>
> Yes, you are right! Thanks for spotting this.
> It appears that it was introduced during code simplification.
>
> @maintainers: should I write another patch or can you more easily replace the original one?
As the regression is already in Linus' tree, it needs an incremental
patch. Please also credit Ephraim with a Reported-by: .
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-28 12:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CAPKXbB6Y9esdQm-VevEfhTggA30vmFY424mwiTK9wZR=wORRHg@mail.gmail.com>
2015-10-28 8:41 ` typo in recent linux commit? H. Nikolaus Schaller
2015-10-28 12:51 ` Nathan Lynch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox