From: k.kozlowski@samsung•com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 3/4] drivers: exynos-srom: Add support for bank configuration
Date: Thu, 29 Oct 2015 15:59:31 +0900 [thread overview]
Message-ID: <5631C3D3.1050309@samsung.com> (raw)
In-Reply-To: <006b01d11216$9831dc40$c89594c0$@samsung.com>
On 29.10.2015 15:54, Pavel Fedin wrote:
> Hello!
>
Where is the contents of email and patch?
>>> + for_each_child_of_node(np, child)
>>> + decode_sromc(srom, child);
>>
>> You ignore the return value here so bank may be not configured but
>> device probe will return 0.
>
> Yes, so that banks which are described correctly, will still be configured.
But the system won't get any information about the failure. Device using
these banks should not probe in such case.
>
>> Maybe clean up and fail the probe?
>
> I think it's not fatal, so cleanup is not necessary. May be dev_warn() in this case?
Now this is just silently ignoring return value (which is not needed
then) and not printing any errors. But that actually depends on previous
comment - whether the driver will fail the probe.
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-10-29 6:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 7:57 [PATCH v3 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410 Pavel Fedin
2015-10-28 7:57 ` [PATCH v3 1/4] Documentation: dt-bindings: Describe SROMc configuration Pavel Fedin
2015-10-29 2:27 ` Krzysztof Kozlowski
2015-10-29 7:45 ` Pavel Fedin
2015-10-29 10:29 ` Krzysztof Kozlowski
2015-10-29 11:43 ` Pavel Fedin
2015-10-30 6:09 ` Krzysztof Kozlowski
2015-10-28 7:57 ` [PATCH v3 2/4] ARM: dts: Add SROMc to Exynos 5410 Pavel Fedin
2015-10-28 7:57 ` [PATCH v3 3/4] drivers: exynos-srom: Add support for bank configuration Pavel Fedin
2015-10-29 2:16 ` Krzysztof Kozlowski
2015-10-29 6:54 ` Pavel Fedin
2015-10-29 6:59 ` Krzysztof Kozlowski [this message]
2015-10-29 8:17 ` Pavel Fedin
2015-10-28 7:57 ` [PATCH v3 4/4] ARM: dts: Add Ethernet chip to SMDK5410 Pavel Fedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5631C3D3.1050309@samsung.com \
--to=k.kozlowski@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox