From: k.kozlowski@samsung•com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 1/4] Documentation: dt-bindings: Describe SROMc configuration
Date: Fri, 30 Oct 2015 15:09:28 +0900 [thread overview]
Message-ID: <56330998.5060706@samsung.com> (raw)
In-Reply-To: <003c01d1123f$002a3220$007e9660$@samsung.com>
On 29.10.2015 20:43, Pavel Fedin wrote:
> Hello!
>
>>>> Any vendor prefix here? How generic is this?
>>>
>>> I just don't know... Does *everything* really need a vendor prefix? How readable would that
>> be? "compatible" property already says
>>> that it's samsung-exynos-specific. And IMHO it's quite obvious that properties of vendor-
>> specific device are automatically
>>> vendor-specific.
>>> Ok, i am currently fixing up the rest and will post v4 soon, and will Cc: it to devicetree
>> ML.
>>
>> Which my reply you are referring to? You stripped part of some
>> sentence and put it without *any context*. Just random sentence.
>> I asked for vendor prefix in few places... srom-timing? width? And I
>> do not remember where I used exactly these words.
>
> Ok, sorry, i promise to improve. :)
> Anyway, i have figured out how to add sub-devices, and heavily modified the whole thing. And indeed, vendor prefix is now very useful, so i added it to all three properties. Making v4...
Actually now I found:
Documentation/devicetree/bindings/net/gpmc-eth.txt
Aren't you duplicating this work? This looks very, very similar.
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-10-30 6:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 7:57 [PATCH v3 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410 Pavel Fedin
2015-10-28 7:57 ` [PATCH v3 1/4] Documentation: dt-bindings: Describe SROMc configuration Pavel Fedin
2015-10-29 2:27 ` Krzysztof Kozlowski
2015-10-29 7:45 ` Pavel Fedin
2015-10-29 10:29 ` Krzysztof Kozlowski
2015-10-29 11:43 ` Pavel Fedin
2015-10-30 6:09 ` Krzysztof Kozlowski [this message]
2015-10-28 7:57 ` [PATCH v3 2/4] ARM: dts: Add SROMc to Exynos 5410 Pavel Fedin
2015-10-28 7:57 ` [PATCH v3 3/4] drivers: exynos-srom: Add support for bank configuration Pavel Fedin
2015-10-29 2:16 ` Krzysztof Kozlowski
2015-10-29 6:54 ` Pavel Fedin
2015-10-29 6:59 ` Krzysztof Kozlowski
2015-10-29 8:17 ` Pavel Fedin
2015-10-28 7:57 ` [PATCH v3 4/4] ARM: dts: Add Ethernet chip to SMDK5410 Pavel Fedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56330998.5060706@samsung.com \
--to=k.kozlowski@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox