From: grinberg@compulab•co.il (Igor Grinberg)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] ARM: dts: imx7d: cl-som-imx7: add basic module support
Date: Mon, 21 Dec 2015 10:07:29 +0200 [thread overview]
Message-ID: <5677B341.6040203@compulab.co.il> (raw)
In-Reply-To: <20151221063608.GB4703@tiger>
Hi Shawn,
On 12/21/15 08:36, Shawn Guo wrote:
> On Wed, Dec 16, 2015 at 04:01:08PM +0200, Igor Grinberg wrote:
>> Hi Shawn,
>>
>> On 12/14/15 04:43, Shawn Guo wrote:
>>> On Thu, Dec 10, 2015 at 04:01:37PM +0200, Igor Grinberg wrote:
>>>> From: Ilya Ledvich <ilya@compulab•co.il>
>>
>> [...]
>>
>>>> diff --git a/Documentation/devicetree/bindings/arm/fsl.txt b/Documentation/devicetree/bindings/arm/fsl.txt
>>>> index 34c88b0..30b0ba1 100644
>>>> --- a/Documentation/devicetree/bindings/arm/fsl.txt
>>>> +++ b/Documentation/devicetree/bindings/arm/fsl.txt
>>>> @@ -53,6 +53,10 @@ i.MX6 Quad SABRE Automotive Board
>>>> Required root node properties:
>>>> - compatible = "fsl,imx6q-sabreauto", "fsl,imx6q";
>>>>
>>>> +i.MX7D CL-SOM-iMX7 Board
>>>> +Required root node properties:
>>>> + - compatible = "compulab,cl-som-imx7", "fsl,imx7d";
>>>> +
>>>
>>> This is not a board produced by FSL, so it should be documented in
>>> fsl.txt.
>>
>> You mean _should not_ be documented in fsl.txt, right?
>
> Right. Sorry.
>
>> Ok, I have no problem with that, we've just used the same approach OMAP
>> takes - all the OMAP based boards are documented in the same file:
>> Documentation/devicetree/bindings/arm/omap/omap.txt
>
> omap.txt is probably fine, as it's not ti.txt.
Have you considered creating a kind of imx.txt?
>
>>
>> Do you think we should document it in:
>> Documentation/devicetree/bindings/arm/compulab-boards.txt
>> (this file should already exist in arm-soc/next/dt)?
>
> Yeah, if the file already exist, it's the best option. But, as it
> doesn't exist on my tree, I can not apply this change.
It is already in linux-next.
Who do you think should apply the v2 patch then?
May be the arm-soc guys? (Cc'ed Olof and Arnd)
>
>>
>>>
>>>> Generic i.MX boards
>>>> -------------------
>>>>
>>>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>>>> index 30bbc37..83ed521 100644
>>>> --- a/arch/arm/boot/dts/Makefile
>>>> +++ b/arch/arm/boot/dts/Makefile
>>>> @@ -350,6 +350,7 @@ dtb-$(CONFIG_SOC_IMX6SX) += \
>>>> dtb-$(CONFIG_SOC_IMX6UL) += \
>>>> imx6ul-14x14-evk.dtb
>>>> dtb-$(CONFIG_SOC_IMX7D) += \
>>>> + imx7d-cl-som-imx7.dtb \
>>>> imx7d-sdb.dtb
>>>> dtb-$(CONFIG_SOC_LS1021A) += \
>>>> ls1021a-qds.dtb \
>>>> diff --git a/arch/arm/boot/dts/imx7d-cl-som-imx7.dts b/arch/arm/boot/dts/imx7d-cl-som-imx7.dts
>>>> new file mode 100644
>>>> index 0000000..ba05198
>>>> --- /dev/null
>>>> +++ b/arch/arm/boot/dts/imx7d-cl-som-imx7.dts
>>>> @@ -0,0 +1,150 @@
>>>> +/*
>>>> + * Support for CompuLab CL-SOM-iMX7 System-on-Module
>>>> + *
>>>> + * Copyright (C) 2015 CompuLab Ltd. - http://www.compulab.co.il/
>>>> + * Author: Ilya Ledvich <ilya@compulab•co.il>
>>>> + *
>>>> + * This program is free software; you can redistribute it and/or modify it
>>>> + * under the terms of the GNU General Public License version 2 as published by
>>>> + * the Free Software Foundation.
>>>> + */
>>>
>>> GPL/X11 dual licence is generally suggested for newly added dts files,
>>> as it will let non-Linux OS use them.
>>
>> I don't remember we've used this one before...
>> Can you please point to an example?
>
> The following command will give you a plenty of examples.
>
> $ git grep X11 arch/arm/boot/dts
10x!
--
Regards,
Igor.
next prev parent reply other threads:[~2015-12-21 8:07 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 7:14 [PATCH 0/8] Add support for CL-SOM-iMX7 and SBC-iMX7 Ilya Ledvich
2015-12-07 7:14 ` [PATCH 1/8] ARM: dts: imx7d: cl-som-imx7: add basic module support Ilya Ledvich
2015-12-08 15:14 ` Rob Herring
2015-12-10 14:01 ` [PATCH v2] " Igor Grinberg
2015-12-14 2:43 ` Shawn Guo
2015-12-16 14:01 ` Igor Grinberg
2015-12-21 6:36 ` Shawn Guo
2015-12-21 8:07 ` Igor Grinberg [this message]
2015-12-21 13:54 ` Shawn Guo
2015-12-21 13:59 ` Shawn Guo
2015-12-22 7:38 ` Igor Grinberg
2015-12-07 7:14 ` [PATCH 2/8] ARM: dts: imx7d: cl-som-imx7: add usb otg support Ilya Ledvich
2015-12-07 7:14 ` [PATCH 3/8] ARM: dts: imx7d: cl-som-imx7: add eMMC support Ilya Ledvich
2015-12-07 7:14 ` [PATCH 4/8] ARM: dts: imx7d: cl-som-imx7: add fec1 support Ilya Ledvich
2015-12-07 7:14 ` [PATCH 5/8] ARM: dts: imx7d: cl-som-imx7: add eeprom support Ilya Ledvich
2015-12-07 7:14 ` [PATCH 6/8] ARM: dts: imx7d: cl-som-imx7: add gpio extender support Ilya Ledvich
2015-12-07 7:14 ` [PATCH 7/8] ARM: dts: imx7d: cl-som-imx7: add fec2 support Ilya Ledvich
2015-12-07 7:14 ` [PATCH 8/8] ARM: dts: imx7d: sbc-imx7: add basic board support Ilya Ledvich
2015-12-08 15:16 ` Rob Herring
2015-12-14 2:47 ` [PATCH 0/8] Add support for CL-SOM-iMX7 and SBC-iMX7 Shawn Guo
2015-12-16 14:09 ` Igor Grinberg
2015-12-21 6:41 ` Shawn Guo
2015-12-21 7:54 ` Igor Grinberg
2015-12-22 8:15 ` [PATCH v2 0/2] " Ilya Ledvich
2015-12-22 8:15 ` [PATCH v2 1/2] ARM: dts: imx7d: cl-som-imx7: add basic module support Ilya Ledvich
2015-12-22 12:17 ` Shawn Guo
2015-12-22 14:07 ` Igor Grinberg
2015-12-22 8:15 ` [PATCH v2 2/2] ARM: dts: imx7d: sbc-imx7: add basic board support Ilya Ledvich
2015-12-22 12:19 ` Shawn Guo
2015-12-22 14:13 ` Igor Grinberg
2015-12-22 12:13 ` [PATCH v2 0/2] Add support for CL-SOM-iMX7 and SBC-iMX7 Shawn Guo
2015-12-22 14:14 ` Igor Grinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5677B341.6040203@compulab.co.il \
--to=grinberg@compulab$(echo .)co.il \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox